Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 538976 - media-libs/imlib-1.9.15-r4 with media-libs/giflib-5.1.1 - .../src/modules/loaders/loader_gif.c:68:19: error: too few arguments to function ‘DGifCloseFile’
Summary: media-libs/imlib-1.9.15-r4 with media-libs/giflib-5.1.1 - .../src/modules/loa...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Library (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Graphics Project
URL:
Whiteboard:
Keywords: PATCH
: 486372 571664 (view as bug list)
Depends on:
Blocks: giflib-5
  Show dependency tree
 
Reported: 2015-02-05 20:57 UTC by Andrew John Hughes
Modified: 2016-10-09 11:05 UTC (History)
5 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Support for giflib 5.0 (imlib-giflib5.patch,3.21 KB, patch)
2015-02-05 21:01 UTC, Andrew John Hughes
Details | Diff
Support for giflib 5.1 (imlib-giflib5.1.patch,3.71 KB, patch)
2015-02-05 21:02 UTC, Andrew John Hughes
Details | Diff
Support for giflib 5.1 (imlib-giflib5.1.patch,2.78 KB, patch)
2015-02-05 21:04 UTC, Andrew John Hughes
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andrew John Hughes 2015-02-05 20:57:06 UTC
5.1 changes the signature of DGifCloseFile to take a second argument, the address of an integer in which to store the error code.

Reproducible: Always

Steps to Reproduce:
1. Install giflib 5.1.1
2. Try to build imlib
3.
Actual Results:  
Fails

Expected Results:  
Succeeds

Portage 2.2.15 (python 2.7.8-final-0, hardened/linux/amd64, gcc-4.9.1, glibc-2.20, 3.18.4-hardened.rivendell x86_64)
=================================================================
System uname: Linux-3.18.4-hardened.rivendell-x86_64-Intel-R-_Xeon-R-_CPU_X5482_@_3.20GHz-with-gentoo-2.2
KiB Mem:     8216292 total,    735824 free
KiB Swap:    6147416 total,   5845956 free
Timestamp of tree: Thu, 05 Feb 2015 07:15:01 +0000
sh bash 4.3_p30-r1
ld GNU gold (Gentoo 2.24 p1.4 2.24) 1.11
app-shells/bash:          4.3_p30-r1
dev-java/java-config:     2.2.0
dev-lang/perl:            5.20.1-r3
dev-lang/python:          2.7.8, 3.4.2
dev-util/cmake:           3.1.0
dev-util/pkgconfig:       0.28-r2
sys-apps/baselayout:      2.2
sys-apps/openrc:          0.13.8
sys-apps/sandbox:         2.6-r1
sys-devel/autoconf:       2.13, 2.69
sys-devel/automake:       1.9.6-r4, 1.10.3-r1, 1.11.6-r1, 1.12.6, 1.13.4, 1.14.1
sys-devel/binutils:       2.24-r3
sys-devel/gcc:            4.8.2, 4.9.1
sys-devel/gcc-config:     1.8
sys-devel/libtool:        2.4.4
sys-devel/make:           4.1-r1
sys-kernel/linux-headers: 3.17-r1 (virtual/os-headers)
sys-libs/glibc:           2.20
Comment 1 Andrew John Hughes 2015-02-05 21:01:52 UTC
Created attachment 395648 [details, diff]
Support for giflib 5.0
Comment 2 Andrew John Hughes 2015-02-05 21:02:12 UTC
Created attachment 395650 [details, diff]
Support for giflib 5.1
Comment 3 Andrew John Hughes 2015-02-05 21:03:06 UTC
I've attached both a fix for the 5.1 fix and my earlier fix for 5.0, which I couldn't see in the bug database already. They can be applied in order or combined. With both applied, imlib builds against giflib 5.1.
Comment 4 Andrew John Hughes 2015-02-05 21:04:36 UTC
Created attachment 395652 [details, diff]
Support for giflib 5.1

Removed temp file from the 5.1 patch
Comment 5 Jeroen Roovers (RETIRED) gentoo-dev 2015-02-06 09:30:22 UTC
*** Bug 538948 has been marked as a duplicate of this bug. ***
Comment 6 Andrew John Hughes 2015-02-06 15:24:20 UTC
This isn't a duplicate; imlib and imlib2 are different packages.
Comment 7 Adam Shea 2016-01-15 18:38:42 UTC
media-libs/libwebp-0.4.0 fails with error: too few arguments to function ‘DGifCloseFile’

media-libs/libwebp-0.4.2 works.
Comment 8 Pacho Ramos gentoo-dev 2016-10-09 10:51:54 UTC
*** Bug 486372 has been marked as a duplicate of this bug. ***
Comment 9 Pacho Ramos gentoo-dev 2016-10-09 10:54:05 UTC
*** Bug 571664 has been marked as a duplicate of this bug. ***
Comment 10 Pacho Ramos gentoo-dev 2016-10-09 11:05:57 UTC
should be fixed in 1.9.15-r5