Created attachment 395602 [details] libshairplay-1.0_pre20130416.ebuild "Apple airplay and raop protocol server" Originally I filed a report to add this ebuild as a required addon for media-tv/xbmc. But since it isn't a native KODI (XBMC) addon but rather a generic server library I decided to open a new report pointing to the correct category. Ebuild and patches attached.
Created attachment 395604 [details, diff] files/01-libshairplay-1.0-fixipv4ipv6race
Created attachment 395606 [details, diff] files/02-libshairplay-1.0-fixpasswordauthitunes
This report obsoletes https://bugs.gentoo.org/show_bug.cgi?id=458734
Comment on attachment 395602 [details] libshairplay-1.0_pre20130416.ebuild Missing Gentoo header. >EAPI="5" > >inherit autotools git-2 > >MY_PV="1.0_pre20130416" >EGIT_REPO_URI="git://github.com/juhovh/shairplay.git" > >if [[ ${PV} == ${MY_PV} ]] ; then > EGIT_COMMIT="139d5ef" >fi github packages releases so there is absolutely no need to mix git-2.eclass into this. If no release is packaged, then it should be packaged elsewhere and not rely on complex version control systems to do a simple download. >DESCRIPTION="Apple airplay and raop protocol server" >HOMEPAGE="https://github.com/juhovh/shairplay" > >LICENSE="LGPL-2.1 MIT BSD" >SLOT="0" >IUSE="static-libs" >KEYWORDS="~amd64 ~x86" > >COMMON_DEPEND=">=dev-libs/openssl-1.0.0 > media-libs/libao" Weird whitespace. >RDEPEND="${COMMON_DEPEND}" >DEPEND="${COMMON_DEPEND}" You might as well remove COMMON_DEPEND and simply make either RDEPEND or DEPEND include the other. >src_unpack() { > git-2_src_unpack >} That should be the default. >src_prepare() { > epatch "${FILESDIR}"/01-${PN}-1.0-fixipv4ipv6race.patch > epatch "${FILESDIR}"/02-${PN}-1.0-fixpasswordauthitunes.patch These aren't accepted upstream yet? > eautoreconf >} > >src_configure() { > econf \ > $(use_enable static-libs static) >} > >src_install() { > default > use static-libs || find "${ED}" -name '*.la' -delete >} inherit eutils // prune_libtool_files
> Missing Gentoo header. I always imagined the Gentoo headers would get added automatically by some vcs hook as soon as an ebuild gets added to the official tree. But I can add that of course. > github packages releases so there is absolutely no need to mix git-2.eclass into this. If no release is packaged, > then it should be packaged elsewhere and not rely on complex version control systems to do a simple download. Indeed there exist no packaged releases. What do you imagine when you talk about "elsewhere"? > Weird whitespace. Oops, I will fix that. > You might as well remove COMMON_DEPEND and simply make either RDEPEND or DEPEND include the other. Ok. > That should be the default. Do you mean ``` src_unpack() { git-2_src_unpack || default } ``` ? > >src_prepare() { > > epatch "${FILESDIR}"/01-${PN}-1.0-fixipv4ipv6race.patch > > epatch "${FILESDIR}"/02-${PN}-1.0-fixpasswordauthitunes.patch > > These aren't accepted upstream yet? I'm not quite sure, but I'll look it up. These patches together with commit 139d5ef are the current dependency for KODI (XBMC). > inherit eutils // prune_libtool_files Like ``` src_install() { default use static-libs || prune_libtool_files --all } ``` ?
Created attachment 406330 [details] libshairplay-1.0_pre20150708.ebuild Version bump. Needed by media-tv/kodi-9999 live ebuild. Obsoletes patches which have been accepted upstream. Details: https://github.com/xbmc/xbmc/pull/7093
Created attachment 409398 [details] libshairplay-1.0_pre20150819.ebuild Upgraded to git-r3 eclass
Created attachment 410256 [details] net-libs/shairplay-0_pre20150825.ebuild
Created attachment 427442 [details] net-libs/shairplay-0_pre20160304.ebuild Synced to version used by KODI upstream.
Created attachment 436718 [details] net-libs/shairplay-0_pre20160304.ebuild Various fixes
Pull request: https://github.com/gentoo/gentoo/pull/3425
Pull request accepted: https://github.com/gentoo/gentoo/commit/e7b104c04e9cf231ccbff86dd3375a50244f7184
