Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 532420 - GLEP 42 Display-If-Profile incompatible with /etc/portage/make.profile being a directory
Summary: GLEP 42 Display-If-Profile incompatible with /etc/portage/make.profile being ...
Status: CONFIRMED
Alias: None
Product: Portage Development
Classification: Unclassified
Component: Core - Configuration (show other bugs)
Hardware: All All
: Normal normal (vote)
Assignee: Portage team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-12-13 08:49 UTC by Arfrever Frehtes Taifersar Arahesis
Modified: 2023-07-11 04:40 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Arfrever Frehtes Taifersar Arahesis 2014-12-13 08:49:44 UTC
GLEP 42 Display-If-Profile does not work when /etc/portage/make.profile is a directory with "parent" file referring to used profile(s).
(I.e. /etc/portage/make.profile is not a symbolic link.)
Comment 1 Zac Medico gentoo-dev 2014-12-20 18:21:08 UTC
In LocationsManager.py, we can an attribute to _profile_node which refers to the the path relative to the containing repo. Then, in news.py, we can access those attributes via settings._locations_manager.profiles_complex and match them all against the the Display-If-Profile path.
Comment 2 John Helmert III archtester Gentoo Infrastructure gentoo-dev Security 2022-11-08 00:43:53 UTC
There's been a ton of news items with Display-If-Profile in the last few years and make.profile has been a symlink on most systems for as long as I can remember. In that time, this bug hasn't come up. Is it fixed?
Comment 3 Khumba 2023-07-09 16:01:39 UTC
Thanks to a forum post I just realized that I didn't get notified about 2023-05-20-kde-pipewire-wayland.  I have my own set of profiles that I use, which inherit from default/linux/amd64/17.1/desktop/plasma/systemd.  /etc/portage/make.profile is a symlink into an overlay.

So it seems that Display-If-Profile might not work as expected with users' custom profiles in general.  It would be really great if we could check the closure of all profiles as Zac suggests.
Comment 4 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2023-07-10 03:41:46 UTC
Yeah, that sounds reasonable to me, although I'd need to check if the GLEP allows us to have that behaviour or if we need to amend it.

Patches welcome if interested.
Comment 5 Khumba 2023-07-11 04:40:48 UTC
Sure, I can take a look at this.