Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 532312 - net-im/turses-0.2.23 version bump
Summary: net-im/turses-0.2.23 version bump
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: No maintainer - Look at https://wiki.gentoo.org/wiki/Project:Proxy_Maintainers if you want to take care of it
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-12-11 19:46 UTC by Alessandro Molari
Modified: 2015-06-05 06:36 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
turses-0.2.23.ebuild (turses-0.2.23.ebuild,902 bytes, text/plain)
2015-01-16 22:33 UTC, Adam Jones
Details
turses-0.2.23.ebuild (turses-0.2.23.ebuild,972 bytes, text/plain)
2015-05-29 07:32 UTC, Alessandro Molari
Details
test errors (turses_test_log,13.62 KB, application/octet-stream)
2015-05-29 07:37 UTC, Alessandro Molari
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Alessandro Molari 2014-12-11 19:46:07 UTC
I was not sure about the section, but there are 10 versions ahead of the application net-im/turses.
Is it possible to update the version to the latest one (0.2.23)?

Thanks
Comment 1 Adam Jones 2015-01-16 22:33:56 UTC
Created attachment 394118 [details]
turses-0.2.23.ebuild

A straightforward version bump of the existing ebuild seems to build and run happily.
Comment 2 Alessandro Molari 2015-01-16 22:35:38 UTC
Thanks so much :)
Comment 3 Alessandro Molari 2015-05-28 06:50:58 UTC
Can we merge the ebuild in the repository?
Comment 4 Justin Lecher (RETIRED) gentoo-dev 2015-05-28 07:15:19 UTC
Could you please send us a PR (https://github.com/gentoo/gentoo-portage-rsync-mirror)
Comment 5 Alessandro Molari 2015-05-28 09:18:48 UTC
I've added the ebuild, did repoman full, created a pull request (https://github.com/gentoo/gentoo-portage-rsync-mirror/pull/132).
Comment 6 Pacho Ramos gentoo-dev 2015-05-28 20:53:19 UTC
Are you willing to proxy maintain this?
https://wiki.gentoo.org/wiki/Project:Proxy_Maintainers

@proxy-maint? Are you in sync with the rsync mirror people?
Comment 7 Alessandro Molari 2015-05-29 07:32:48 UTC
Created attachment 404260 [details]
turses-0.2.23.ebuild
Comment 8 Alessandro Molari 2015-05-29 07:35:52 UTC
Following the suggestions here: https://github.com/gentoo/gentoo-portage-rsync-mirror/pull/132

I've fixed most of the mistakes:

repoman, manifest and merge are ok.

The only problem I have is with 

ebuild turses-0.2.23.ebuild test

which fails. For details see the attachment "test errors".

Can some one help me?

Thanks
Comment 9 Alessandro Molari 2015-05-29 07:37:19 UTC
Created attachment 404262 [details]
test errors
Comment 10 Justin Lecher (RETIRED) gentoo-dev 2015-05-29 08:58:03 UTC
(In reply to Alessandro Molari from comment #7)
> Created attachment 404260 [details]
> turses-0.2.23.ebuild

Could you please update the pullrequest?
Comment 11 Justin Lecher (RETIRED) gentoo-dev 2015-05-29 09:19:33 UTC
Comment on attachment 404260 [details]
turses-0.2.23.ebuild

># Copyright 1999-2014 Gentoo Foundation
># Distributed under the terms of the GNU General Public License v2
># $Header: /var/cvsroot/gentoo-x86/net-im/turses/turses-0.2.13-r1.ebuild,v 1.2 2014/08/05 18:34:08 mrueg Exp $
>
>EAPI=5
>
>PYTHON_COMPAT=( python2_7 )
>
>inherit distutils-r1 eutils
>
>DESCRIPTION="Command line twitter client"
>HOMEPAGE="https://github.com/alejandrogomez/turses"
>SRC_URI="https://github.com/alejandrogomez/${PN}/archive/v${PV}.tar.gz -> ${P}.tar.gz"
>
>LICENSE="GPL-3"
>SLOT="0"
>KEYWORDS="~amd64 ~x86"
>IUSE="test"
>
>DEPEND="
>	dev-python/oauth2[${PYTHON_USEDEP}]
>	dev-python/setuptools[${PYTHON_USEDEP}]
>	>dev-python/tweepy-2.2[${PYTHON_USEDEP}]
>	<dev-python/tweepy-3[${PYTHON_USEDEP}]
>	dev-python/urwid[${PYTHON_USEDEP}]
>	test? (
>		dev-python/mock[${PYTHON_USEDEP}]
>		dev-python/pytest[${PYTHON_USEDEP}]
>		dev-python/coverage[${PYTHON_USEDEP}]
>		dev-python/tox[${PYTHON_USEDEP}]
>	)
>"
>
>DOCS=( AUTHORS HISTORY.rst README.rst )
>
>python_test() {
>	esetup.py test

run py.test as upstream (https://github.com/dialelo/turses/blob/master/.travis.yml). that should remove your errors.
>}
Comment 12 Ian Delaney (RETIRED) gentoo-dev 2015-06-01 12:05:05 UTC
~/cvsPortage/gentoo-x86/net-im/turses $ ebuild turses-0.2.23.ebuild clean tes

>>> Source compiled.
>>> Test phase: net-im/turses-0.2.23
 * python2_7: running distutils-r1_run_phase python_test
=============== test session starts ====================================
platform linux2 -- Python 2.7.9 -- py-1.4.26 -- pytest-2.7.0
rootdir: /mnt/gen2/TmpDir/portage/net-im/turses-0.2.23/work/turses-0.2.23, inifile: 
collected 124 items

tests/test_api.py ..........................
tests/test_config.py .............
tests/test_core.py ..........
tests/test_meta.py ...
tests/test_models.py ...........................................................
tests/test_session.py ..
tests/test_ui.py ......
tests/test_utils.py .....

============== 124 passed in 1.80 seconds ===============================

(In reply to Alessandro Molari from comment #9)
> Created attachment 404262 [details]
> test errors

See:
net-im/turses-0.2.23/work/turses-0.2.23/tox.ini:

commands =
    pip install -r {toxinidir}/requirements/dev.txt --use-mirrors --quiet
    py.test
To set a test phase with a tox.ini present a package's source, observe the setting of commands =
This tells how the suite is actually run. So in this case,
python_test() {
         esetup.py test

doesn't work.  Run with either 'py.test' or 'py.test tests'
now peruse the dozens of other ebuilds in the python herd and add the || die $msg since py.test is an exe file in the installed system.

Now note;

~/cvsPortage/gentoo-x86/net-im/turses $ l /mnt/gen2/TmpDir/portage/net-im/turses-0.2.23/work/turses-0.2.23/docs
Makefile  conf.py  dev  images  index.rst  user

There is a whole doc build in the source. Why was this skipped?  A doc build is a very standard process. There are many of the python herd in the tree to use as a template. I am 99% sure one will simply drop in and just work.

You can update the pr but I request to duplicate the update to the ebuild in attachments here which is what I normally use. Alternatively just a link to the pr
Comment 13 Ian Delaney (RETIRED) gentoo-dev 2015-06-02 14:45:36 UTC
Also, for the test phase, dev-python/tox[${PYTHON_USEDEP}] is NOT required. tox is a testrunner used typically by upstream developers and is never used to run testsuites in gentoo. See if you can determine why.
dev-python/coverage[${PYTHON_USEDEP}] is not essential but is fine
Comment 14 Alessandro Molari 2015-06-02 19:02:55 UTC
This is the link to the pull request: https://github.com/gentoo/gentoo-portage-rsync-mirror/pull/132
Comment 15 Ian Delaney (RETIRED) gentoo-dev 2015-06-03 02:48:37 UTC
Commented in the pr @ github
Comment 16 Justin Lecher (RETIRED) gentoo-dev 2015-06-05 06:36:39 UTC
+*turses-0.2.23 (05 Jun 2015)
+
+  05 Jun 2015; Justin Lecher <jlec@gentoo.org> +turses-0.2.23.ebuild,
+  metadata.xml:
+  Version Bump, bug #532312; thanks Adam Jones and Alessandro Molari for the
+  ebuild, https://github.com/gentoo/gentoo-portage-rsync-mirror/pull/132
+