Bug 530490 – gnome2-utils.eclass: incorrect sed script in gnome2_disable_deprecation_warning()

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Alexander Tsoy 2014-11-25 00:29:13 UTC]

Created attachment 390234 [details, diff]
gnome2-utils.eclass.patch

Please fix incorrect sed script introduced in commit [1]. It actually does not replace -DGSEAL_ENABLE, see [2] for example. 

[1] http://sources.gentoo.org/cgi-bin/viewvc.cgi/gentoo-x86/eclass/gnome2-utils.eclass?r1=1.33&r2=1.34
[2] https://bugs.gentoo.org/show_bug.cgi?id=448822#c5

[Comment 1 Alexander Tsoy 2014-11-25 06:29:45 UTC]

> +        -e 's:-DGSEAL_ENABLE(=[A-Za-z0-9_]*)?:$(NULL):g' \

'_' is unlikely to be used in the real life, so [:alnum:] character class should also work:

+        -e 's:-DGSEAL_ENABLE(=[[:alnum:]]*)?:$(NULL):g' \

[Comment 2 Pacho Ramos 2014-12-16 00:07:12 UTC]

(In reply to Alexander Tsoy from comment #1)
> > +        -e 's:-DGSEAL_ENABLE(=[A-Za-z0-9_]*)?:$(NULL):g' \
> 
> '_' is unlikely to be used in the real life, so [:alnum:] character class
> should also work:
> 
> +        -e 's:-DGSEAL_ENABLE(=[[:alnum:]]*)?:$(NULL):g' \

@gnome team, what option do you prefer? :)

[Comment 3 Pacho Ramos 2015-12-16 12:06:12 UTC]

Per bug 448822 we could probably use "true" instead of $(NULL) to prevent the same warning as bug 448822

[Comment 4 Pacho Ramos 2016-01-20 11:36:45 UTC]

I would go with the former plus using /bin/true:
+        -e 's:-DGSEAL_ENABLE(=[A-Za-z0-9_]*)?:$(/bin/true):g' \

[Comment 5 Pacho Ramos 2016-01-30 09:57:06 UTC]

[master ca71627] eclass/gnome2-utils.eclass: fix DGSEAL_ENABLE sed (#530490 by Alexander Tsoy)
 1 file changed, 1 insertion(+), 1 deletion(-)