Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 529702 - www-client/midori-0.5.10 version bump
Summary: www-client/midori-0.5.10 version bump
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal with 1 vote (vote)
Assignee: XFCE Team
URL:
Whiteboard:
Keywords: EBUILD, PATCH
Depends on:
Blocks:
 
Reported: 2014-11-18 15:59 UTC by Branko Grubic
Modified: 2015-06-24 20:48 UTC (History)
7 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
ebuild_diff (midori-0.5.8_0.5.9.ebuild.patch,875 bytes, patch)
2014-11-18 16:00 UTC, Branko Grubic
Details | Diff
current_diff_to_0.5.10 (midori_0.5.8-r1_0.5.10.diff,1.08 KB, patch)
2015-04-20 09:58 UTC, Branko Grubic
Details | Diff
0.5.8-r1-0.5.10_gcr_fix (midori_0.5.8-r1_0.5.10_no_gcrvala.diff,1.07 KB, patch)
2015-04-20 11:01 UTC, Branko Grubic
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Branko Grubic 2014-11-18 15:59:34 UTC
There is a new bugfix release of midori.
I edited current 'midori-0.5.8-r1.ebuild' and I was able to successfully build midori-0.5.9 with few simple chages (diff attached). 
I removed patch which fixes bug #498898 because upstream bug report says it is fixed in 0.5.9 (lp #1173744) 
Only test-build with "www-client/midori-0.5.9 (jit)" 

Only renaming ebuild and removing patches didn't work, it failed because prepare/build starts in wrong directory I changed "S=${WORKDIR}/${P}" which is default when I look at dev manual, so it probably needs to be removed if not needed for live ebuilds?

Reproducible: Always
Comment 1 Branko Grubic 2014-11-18 16:00:04 UTC
Created attachment 389634 [details, diff]
ebuild_diff
Comment 2 Christopher Head 2015-01-19 02:11:37 UTC
Yes, removing S=${WORKDIR} entirely seems to work fine, and according to devmanual.gentoo.org is the preferred way of handling this. As you did, I also removed the patch (both the epatch line and the SRC_URI entry). I built with only jit and webkit2 USE flags enabled.
Comment 3 Klaus Kusche 2015-02-15 08:37:15 UTC
Status?
Another vote for this one.
Comment 4 Branko Grubic 2015-04-20 09:58:03 UTC
Created attachment 401658 [details, diff]
current_diff_to_0.5.10

Updated to 0.5.10, this is the diff for current in portage midori-0.5.8-r1.ebuild


I don't know much about build systems, and cmake, but looking at the ChangeLog and CmakeLists.txt
From ChangeLog
"Make GCR mandatory for all builds"
I moved app-crypt/gcr-3 from !deprecated? ( ) so all builds depend on it, for me without app-crypt/gcr-3[vala] it failed at some point with ld errors with undefined reference ( " libmidori-core.so.0.0.0: undefined reference to gcr_certificate_details_widget_new' ") I don't know if [vala] is needed, but if I understand the midori developers/community they are trying to move more and more things to vala code?

Archive is different again, so we need 
S=${WORKDIR}  again not like in 0.5.9 ebuild diff


Things I didn't check!!! 
"Use GNotification >= 2.40 and use Midori.App API in webmedia" 
and 
"Clean up vapi dependency" 
Don't know how important they are and if ebuild need to be changed for those, and if they are related to packaging (both).

I only tested this build config ( www-client/midori-0.5.10 (jit) ) 
If anyone can test with www-client/midori[deprecated] (gtk2 stuff and different webkit, it would be nice (for me webkit takes too mucht time to build ~3hours)

I'll check if I can change the summary of this bug, if not, devs please change it for midori 0.5.10
Comment 5 Branko Grubic 2015-04-20 10:45:10 UTC
(In reply to bitlord from comment #4)
...
> I don't know much about build systems, and cmake, but looking at the
> ChangeLog and CmakeLists.txt
> From ChangeLog
> "Make GCR mandatory for all builds"
> I moved app-crypt/gcr-3 from !deprecated? ( ) so all builds depend on it,
> for me without app-crypt/gcr-3[vala] it failed at some point with ld errors
> with undefined reference ( " libmidori-core.so.0.0.0: undefined reference to
> gcr_certificate_details_widget_new' ") I don't know if [vala] is needed, but
> if I understand the midori developers/community they are trying to move more
> and more things to vala code?
> 
app-crypt/gcr-3[vala] is probably not needed, I tested again without USE="vala", looks like it builds fine, need to try with clean system/session again, not sure why it failed before, gcr rebuild possibly fixed it?
...
Comment 6 Branko Grubic 2015-04-20 11:01:49 UTC
Created attachment 401660 [details, diff]
0.5.8-r1-0.5.10_gcr_fix

not sure what was the problem, I blindly enabled USE="vala" for gcr which fixed the build, but the problem was something else, if someone else test this and it fails with errors like in previous comment, does app-crypt/gcr rebuild fixes it for you?
Not sure if toolchain update can break this, like gcc-4.8.3->4.8.4 update ... or something like that?
Comment 7 Branko Grubic 2015-04-20 11:20:11 UTC
(In reply to bitlord from comment #6)
..
> Not sure if toolchain update can break this, like gcc-4.8.3->4.8.4 update
> ... or something like that?

Sorry for spamming too much on this report, looks like it was my fault, I didn't rebuild libtool after gcc upgrade :( (every time you learn something new, not nice when you learn things you skipped before :(
Comment 8 Pacho Ramos gentoo-dev 2015-06-24 20:48:43 UTC
0.5.10 just addded