Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 527810 - net-misc/tor should only use RDEPEND for SELinux policy package dependency
Summary: net-misc/tor should only use RDEPEND for SELinux policy package dependency
Status: RESOLVED OBSOLETE
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Anthony Basile
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 527698
  Show dependency tree
 
Reported: 2014-11-01 11:46 UTC by Sven Vermeulen (RETIRED)
Modified: 2014-11-02 09:16 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Sven Vermeulen (RETIRED) gentoo-dev 2014-11-01 11:46:39 UTC
Please remove the "selinux? ( sec-policy/selinux-* )" dependency in the DEPEND variable (not RDEPEND). Take this into account with your next package bump - if after 6 months there have been no need for other package upgrades, we will be bumping the package(s) ourselves with just this change.

For more information, see our tracker Bug #527698 [1]. The requested change will be posted as a separate comment/patch. Note that if the package also depends on libselinux, libselinux itself should still remain in DEPEND and RDEPEND.

[1] https://bugs.gentoo.org/show_bug.cgi?id=527698


Reproducible: Always
Comment 1 Sven Vermeulen (RETIRED) gentoo-dev 2014-11-01 11:46:48 UTC
Index: tor-0.2.5.10.ebuild
===================================================================
RCS file: /var/cvsroot/gentoo-x86/net-misc/tor/tor-0.2.5.10.ebuild,v
retrieving revision 1.1
diff -u -B -r1.1 tor-0.2.5.10.ebuild
--- tor-0.2.5.10.ebuild 25 Oct 2014 17:37:40 -0000      1.1
+++ tor-0.2.5.10.ebuild 1 Nov 2014 11:46:03 -0000
@@ -24,9 +24,9 @@
        dev-libs/libevent
        bufferevents? ( dev-libs/libevent[ssl] )
        nat-pmp? ( net-libs/libnatpmp )
-       upnp? ( net-libs/miniupnpc )
+       upnp? ( net-libs/miniupnpc )"
+RDEPEND="${DEPEND}
        selinux? ( sec-policy/selinux-tor )"
-RDEPEND="${DEPEND}"
 
 pkg_setup() {
        enewgroup tor
Index: tor-0.2.6.1_alpha.ebuild
===================================================================
RCS file: /var/cvsroot/gentoo-x86/net-misc/tor/tor-0.2.6.1_alpha.ebuild,v
retrieving revision 1.2
diff -u -B -r1.2 tor-0.2.6.1_alpha.ebuild
--- tor-0.2.6.1_alpha.ebuild    31 Oct 2014 15:41:05 -0000      1.2
+++ tor-0.2.6.1_alpha.ebuild    1 Nov 2014 11:46:03 -0000
@@ -26,9 +26,9 @@
        nat-pmp? ( net-libs/libnatpmp )
        scrypt? ( app-crypt/libscrypt )
        seccomp? ( sys-libs/libseccomp )
-       upnp? ( net-libs/miniupnpc )
+       upnp? ( net-libs/miniupnpc )"
+RDEPEND="${DEPEND}
        selinux? ( sec-policy/selinux-tor )"
-RDEPEND="${DEPEND}"
 
 pkg_setup() {
        enewgroup tor
Comment 2 Sven Vermeulen (RETIRED) gentoo-dev 2014-11-02 09:16:51 UTC
After checking with a few colleague developers it seems that this change does not need a revision bump after all. As such, I will make the necessary changes to the packages myself.

My apologies for the noise.