Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 527708 - app-admin/sysstat should only use RDEPEND for SELinux policy package dependency
Summary: app-admin/sysstat should only use RDEPEND for SELinux policy package dependency
Status: RESOLVED OBSOLETE
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Jeroen Roovers (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 527698
  Show dependency tree
 
Reported: 2014-11-01 09:11 UTC by Sven Vermeulen (RETIRED)
Modified: 2014-11-02 07:50 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Sven Vermeulen (RETIRED) gentoo-dev 2014-11-01 09:11:14 UTC
Please remove the "selinux? ( sec-policy/selinux-* )" dependency in the DEPEND variable (not RDEPEND). Take this into account with your next package bump - if after 6 months there have been no need for other package upgrades, we will be bumping the package(s) ourselves with just this change.

For more information, see our tracker Bug #527698 [1]. The requested change will be posted as a separate comment/patch. Note that if the package also depends on libselinux, libselinux itself should still remain in DEPEND and RDEPEND.

[1] https://bugs.gentoo.org/show_bug.cgi?id=527698

Reproducible: Always
Comment 1 Sven Vermeulen (RETIRED) gentoo-dev 2014-11-01 09:12:03 UTC
Index: sysstat-11.0.0.ebuild
===================================================================
RCS file: /var/cvsroot/gentoo-x86/app-admin/sysstat/sysstat-11.0.0.ebuild,v
retrieving revision 1.6
diff -u -B -r1.6 sysstat-11.0.0.ebuild
--- sysstat-11.0.0.ebuild       29 Oct 2014 09:29:00 -0000      1.6
+++ sysstat-11.0.0.ebuild       1 Nov 2014 09:10:19 -0000
@@ -14,7 +14,7 @@
 KEYWORDS="~alpha amd64 ~arm ~arm64 hppa ~m68k ~mips ppc ppc64 ~s390 ~sh sparc ~x86"
 IUSE="cron debug +doc isag nls lm_sensors selinux"
 
-RDEPEND="
+COMMON_DEPS="
        cron? ( sys-process/cronbase )
        isag? (
                dev-lang/tk
@@ -23,12 +23,15 @@
        )
        nls? ( virtual/libintl )
        lm_sensors? ( sys-apps/lm_sensors )
-       selinux? ( sec-policy/selinux-sysstat )
 "
 DEPEND="
-       ${RDEPEND}
+       ${COMMON_DEPS}
        nls? ( sys-devel/gettext )
 "
+RDEPEND="
+       ${COMMON_DEPS}
+       selinux? ( sec-policy/selinux-sysstat )
+"
 
 src_prepare() {
        if use nls; then
Index: sysstat-11.0.1-r1.ebuild
===================================================================
RCS file: /var/cvsroot/gentoo-x86/app-admin/sysstat/sysstat-11.0.1-r1.ebuild,v
retrieving revision 1.1
diff -u -B -r1.1 sysstat-11.0.1-r1.ebuild
--- sysstat-11.0.1-r1.ebuild    26 Sep 2014 09:01:58 -0000      1.1
+++ sysstat-11.0.1-r1.ebuild    1 Nov 2014 09:10:19 -0000
@@ -14,7 +14,7 @@
 KEYWORDS="~alpha ~amd64 ~arm ~arm64 ~hppa ~m68k ~mips ~ppc ~ppc64 ~s390 ~sh ~sparc ~x86"
 IUSE="cron debug +doc isag nls lm_sensors selinux"
 
-RDEPEND="
+COMMON_DEPS="
        cron? ( sys-process/cronbase )
        isag? (
                dev-lang/tk
@@ -23,12 +23,15 @@
        )
        nls? ( virtual/libintl )
        lm_sensors? ( sys-apps/lm_sensors )
-       selinux? ( sec-policy/selinux-sysstat )
 "
 DEPEND="
-       ${RDEPEND}
+       ${COMMON_DEPS}
        nls? ( sys-devel/gettext )
 "
+RDEPEND="
+       ${COMMON_DEPS}
+       selinux? ( sec-policy/selinux-sysstat )
+"
 
 src_prepare() {
        if use nls; then
Index: sysstat-11.0.2.ebuild
===================================================================
RCS file: /var/cvsroot/gentoo-x86/app-admin/sysstat/sysstat-11.0.2.ebuild,v
retrieving revision 1.1
diff -u -B -r1.1 sysstat-11.0.2.ebuild
--- sysstat-11.0.2.ebuild       21 Oct 2014 09:09:59 -0000      1.1
+++ sysstat-11.0.2.ebuild       1 Nov 2014 09:10:19 -0000
@@ -14,7 +14,7 @@
 KEYWORDS="~alpha ~amd64 ~arm ~arm64 ~hppa ~m68k ~mips ~ppc ~ppc64 ~s390 ~sh ~sparc ~x86"
 IUSE="cron debug +doc isag nls lm_sensors selinux"
 
-RDEPEND="
+COMMON_DEPS="
        cron? ( sys-process/cronbase )
        isag? (
                dev-lang/tk
@@ -23,12 +23,15 @@
        )
        nls? ( virtual/libintl )
        lm_sensors? ( sys-apps/lm_sensors )
-       selinux? ( sec-policy/selinux-sysstat )
 "
 DEPEND="
-       ${RDEPEND}
+       ${COMMON_DEPS}
        nls? ( sys-devel/gettext )
 "
+RDEPEND="
+       ${COMMON_DEPS}
+       selinux? ( sec-policy/selinux-sysstat )
+"
 
 src_prepare() {
        if use nls; then
Index: sysstat-11.1.1-r1.ebuild
===================================================================
RCS file: /var/cvsroot/gentoo-x86/app-admin/sysstat/sysstat-11.1.1-r1.ebuild,v
retrieving revision 1.1
diff -u -B -r1.1 sysstat-11.1.1-r1.ebuild
--- sysstat-11.1.1-r1.ebuild    26 Sep 2014 09:01:58 -0000      1.1
+++ sysstat-11.1.1-r1.ebuild    1 Nov 2014 09:10:19 -0000
@@ -14,7 +14,7 @@
 KEYWORDS=""
 IUSE="cron debug +doc isag nls lm_sensors selinux"
 
-RDEPEND="
+COMMON_DEPS="
        cron? ( sys-process/cronbase )
        isag? (
                dev-lang/tk
@@ -23,12 +23,15 @@
        )
        nls? ( virtual/libintl )
        lm_sensors? ( sys-apps/lm_sensors )
-       selinux? ( sec-policy/selinux-sysstat )
 "
 DEPEND="
-       ${RDEPEND}
+       ${COMMON_DEPS}
        nls? ( sys-devel/gettext )
 "
+RDEPEND="
+       ${COMMON_DEPS}
+       selinux? ( sec-policy/selinux-sysstat )
+"
 
 src_prepare() {
        if use nls; then
Index: sysstat-11.1.2.ebuild
===================================================================
RCS file: /var/cvsroot/gentoo-x86/app-admin/sysstat/sysstat-11.1.2.ebuild,v
retrieving revision 1.1
diff -u -B -r1.1 sysstat-11.1.2.ebuild
--- sysstat-11.1.2.ebuild       21 Oct 2014 09:09:59 -0000      1.1
+++ sysstat-11.1.2.ebuild       1 Nov 2014 09:10:19 -0000
@@ -14,7 +14,7 @@
 KEYWORDS=""
 IUSE="cron debug +doc isag nls lm_sensors selinux"
 
-RDEPEND="
+COMMON_DEPS="
        cron? ( sys-process/cronbase )
        isag? (
                dev-lang/tk
@@ -23,12 +23,15 @@
        )
        nls? ( virtual/libintl )
        lm_sensors? ( sys-apps/lm_sensors )
-       selinux? ( sec-policy/selinux-sysstat )
 "
 DEPEND="
-       ${RDEPEND}
+       ${COMMON_DEPS}
        nls? ( sys-devel/gettext )
 "
+RDEPEND="
+       ${COMMON_DEPS}
+       selinux? ( sec-policy/selinux-sysstat )
+"
 
 src_prepare() {
        if use nls; then
Comment 2 Sven Vermeulen (RETIRED) gentoo-dev 2014-11-02 07:50:36 UTC
After checking with a few colleague developers it seems that this change does not need a revision bump after all. As such, I will make the necessary changes to the packages myself.

My apologies for the noise.