Bug 527450 – app-shells/bash-completion-2.1-r2 with net-ftp/lftp-4.5.5 fails to complete bookmarks because they are stored in .local/share/lftp/bookmarks instead of .lftp/bookmarks

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Andrew Petelin 2014-10-30 12:44:34 UTC]

lftp and its completion script expect different locations of lftp's local settings, e.g.:

/usr/share/bash-completion/lftp uses ~/.lftp directory:
    COMPREPLY=( $( compgen -W \
        '$( cut -f 1 -s ~/.lftp/bookmarks 2>/dev/null )' -- "$cur" ) )

But the file created by the `bookmark` command from lftp's command line is ~/.local/share/lftp/bookmarks.

Reproducible: Always

Steps to Reproduce:
1. Run `bookmark add tmp_bm` from the lftp console.
2. Quit lftp.
3. Try to complete the 'tmp_bm' name from command line.
Actual Results:  
Completion doesn't work.

Expected Results:  
Completion works.

# emerge --info
Portage 2.2.8-r2 (default/linux/amd64/13.0/desktop, gcc-4.7.3, glibc-2.19-r1, 3.14.14-gentoo x86_64)
=================================================================
System uname: Linux-3.14.14-gentoo-x86_64-Intel-R-_Core-TM-_i7-2600_CPU_@_3.40GHz-with-gentoo-2.2
KiB Mem:    16122104 total,   5614404 free
KiB Swap:    4194300 total,   4194300 free
Timestamp of tree: Thu, 30 Oct 2014 10:45:01 +0000
ld GNU ld (Gentoo 2.23.2 p1.0) 2.23.2
app-shells/bash:          4.2_p53
dev-java/java-config:     2.2.0
dev-lang/perl:            5.18.2-r2
dev-lang/python:          2.7.7, 3.3.5-r1, 3.4.1
dev-util/cmake:           2.8.12.2-r1
dev-util/pkgconfig:       0.28-r1
sys-apps/baselayout:      2.2
sys-apps/openrc:          0.12.4
sys-apps/sandbox:         2.6-r1
sys-devel/autoconf:       2.13, 2.69
sys-devel/automake:       1.11.6, 1.13.4
sys-devel/binutils:       2.23.2
sys-devel/gcc:            4.7.3-r1, 4.8.3
sys-devel/gcc-config:     1.7.3
sys-devel/libtool:        2.4.2-r1
sys-devel/make:           4.0-r1
sys-kernel/linux-headers: 3.13 (virtual/os-headers)
sys-libs/glibc:           2.19-r1
Repositories: gentoo adrianopol sunrise
ACCEPT_KEYWORDS="amd64"
ACCEPT_LICENSE="* -@EULA"
CBUILD="x86_64-pc-linux-gnu"
CFLAGS="-O2 -pipe -march=native -fomit-frame-pointer"
CHOST="x86_64-pc-linux-gnu"
CONFIG_PROTECT="/etc /usr/share/gnupg/qualified.txt"
CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/env.d /etc/fonts/fonts.conf /etc/gconf /etc/gentoo-release /etc/revdep-rebuild /etc/sandbox.d /etc/terminfo /etc/texmf/language.dat.d /etc/texmf/language.def.d /etc/texmf/updmap.d /etc/texmf/web2c"
CXXFLAGS="-O2 -pipe -march=native -fomit-frame-pointer"
DISTDIR="/usr/portage/distfiles"
FCFLAGS="-O2 -pipe"
FEATURES="assume-digests binpkg-logs config-protect-if-modified distlocks ebuild-locks fixlafiles merge-sync news parallel-fetch preserve-libs protect-owned sandbox sfperms strict unknown-features-warn unmerge-logs unmerge-orphans userfetch userpriv usersandbox usersync"
FFLAGS="-O2 -pipe"
GENTOO_MIRRORS="http://mirror.yandex.ru/gentoo-distfiles/   ftp://mirror.yandex.ru/gentoo-distfiles/   ftp://gentoo.bloodhost.ru/   http://gentoo.bloodhost.ru/   ftp://mirror2.corbina.ru/gentoo-distfiles/   http://mirror2.corbina.ru/gentoo-distfiles/"
LANG="en_US.UTF-8"
LDFLAGS="-Wl,-O1 -Wl,--as-needed"
MAKEOPTS="-j8"
PKGDIR="/usr/portage/packages"
PORTAGE_CONFIGROOT="/"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --omit-dir-times --compress --force --whole-file --delete --stats --human-readable --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages"
PORTAGE_TMPDIR="/var/tmp"
PORTDIR="/usr/portage"
PORTDIR_OVERLAY="/usr/local/portage /var/lib/layman/sunrise"
SYNC="rsync://mirror.yandex.ru/gentoo-portage"
USE="X a52 aac acl acpi alsa amd64 bash-completion berkdb bluetooth branding bzip2 cairo cdda cdr cli consolekit cracklib crypt cups cxx dbus dri dts dvd dvdr emboss encode exif fam ffmpeg fftw firefox flac fontconfig fortran fuse gd gdbm gif glamor gnutls gpm gstreamer gtk i18n iconv icu ipv6 jabber jpeg lame latex lcms ldap libcaca libnotify mad matroska mmap mmx mng modules mp3 mp4 mpeg mplayer multilib musepack ncurses network nls nptl nsplugin ogg openal opengl openmp otr pam pango pcre pdf perl png policykit ppds pulseaudio python qt3support qt4 readline ruby sdl session sharedmem speex spell sqlite sqlite3 sse sse2 ssl ssse3 startup-notification svg syslog tcpd theora threads tiff timidity truetype udev udisks unicode upower usb v4l vaapi video vim-syntax vorbis vpx wavpack webkit wxwidgets x264 xcb xft xml xscreensaver xv xvid zlib zsh-completion" ABI_X86="64" ALSA_CARDS="ali5451 als4000 atiixp atiixp-modem bt87x ca0106 cmipci emu10k1x ens1370 ens1371 es1938 es1968 fm801 hda-intel intel8x0 intel8x0m maestro3 trident usb-audio via82xx via82xx-modem ymfpci" APACHE2_MODULES="authn_core authz_core socache_shmcb unixd actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache cgi cgid dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" CALLIGRA_FEATURES="kexi words flow plan sheets stage tables krita karbon braindump author" CAMERAS="ptp2" COLLECTD_PLUGINS="df interface irq load memory rrdtool swap syslog" ELIBC="glibc" GPSD_PROTOCOLS="ashtech aivdm earthmate evermore fv18 garmin garmintxt gpsclock itrax mtk3301 nmea ntrip navcom oceanserver oldstyle oncore rtcm104v2 rtcm104v3 sirf superstar2 timing tsip tripmate tnt ublox ubx" INPUT_DEVICES="evdev" KERNEL="linux" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LIBREOFFICE_EXTENSIONS="presenter-console presenter-minimizer" LINGUAS="en en_US" OFFICE_IMPLEMENTATION="libreoffice" PHP_TARGETS="php5-5" PYTHON_SINGLE_TARGET="python2_7" PYTHON_TARGETS="python2_7 python3_3" QEMU_SOFTMMU_TARGETS="x86_64 i386" QEMU_USER_TARGETS="x86_64 i386" RUBY_TARGETS="ruby19 ruby20" USERLAND="GNU" VIDEO_CARDS="intel" XTABLES_ADDONS="quota2 psd pknock lscan length2 ipv4options ipset ipp2p iface geoip fuzzy condition tee tarpit sysrq steal rawnat logmark ipmark dhcpmac delude chaos account"
Unset:  CPPFLAGS, CTARGET, EMERGE_DEFAULT_OPTS, INSTALL_MASK, LC_ALL, PORTAGE_BUNZIP2_COMMAND, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS, USE_PYTHON


# eix '-I*' 'lftp|bash-completion'
[I] app-shells/bash-completion
     Available versions:  1.3-r2 ~2.1 2.1-r2 ~2.1-r91
     Installed versions:  2.1-r2(01:30:42 PM 10/13/2014)
     Homepage:            http://bash-completion.alioth.debian.org/
     Description:         Programmable Completion for bash

[I] net-ftp/lftp
     Available versions:  4.4.15 4.5.5 ~4.6.0 **9999 {convert-mozilla-cookies +gnutls idn nls openssl socks5 +ssl verify-file LINGUAS="cs de es fr it ja ko pl pt_BR ru uk zh_CN zh_HK zh_TW"}
     Installed versions:  4.5.5(01:46:20 PM 10/14/2014)(gnutls nls ssl -convert-mozilla-cookies -idn -openssl -socks5 -verify-file LINGUAS="-cs -de -es -fr -it -ja -ko -pl -pt_BR -ru -uk -zh_CN -zh_HK -zh_TW")
     Homepage:            http://lftp.yar.ru/
     Description:         A sophisticated ftp/sftp/http/https/torrent client and file transfer program

[Comment 1 Andrew Petelin 2014-10-30 13:01:20 UTC]

Created attachment 387802 [details, diff]
Possible solution: read bookmarks from both possible locations.

A patch for bash-completion package.

[Comment 2 Michał Górny 2014-10-30 15:51:54 UTC]

This is really something that belongs upstream. By the way, maybe we could try to hand the completion over to lftp upstream? :)

[Comment 3 Andrew Petelin 2014-10-30 16:09:25 UTC]

I can't find any completion scripts in lftp's upstream; this file is taken from somewhere else, possibly

https://github.com/brechtm/bash-completion/blob/master/completions/lftp

If you know the exact source, please tell me.

[Comment 4 Michał Górny 2014-10-30 17:19:58 UTC]

It's http://anonscm.debian.org/cgit/bash-completion/bash-completion.git.

[Comment 5 Andrew Petelin 2014-10-30 17:35:24 UTC]

Done: https://alioth.debian.org/tracker/index.php?func=detail&aid=314865&group_id=100114&atid=413095.

[Comment 6 Andrew Petelin 2014-10-31 10:55:25 UTC]

Hmmm: there are lots of open bugs since (!) 2009, that have almost, but not quite, no activity. It is suspected that this one won't be fixed in a short time :)

Maybe it is reasonable to add a patch to gentoo's bash-completion in the meanwhile?

[Comment 7 Michał Górny 2014-10-31 11:30:45 UTC]

Maybe we should have a Gentoo patchset to bash-completion. But I'm currently busy with other stuff, so don't expect it very soon :).

The alternative is to move the file to Gentoo lftp package and fix it there. Even better, send it to lftp upstream and ask to be included. Note that this requires a license check.

[Comment 8 Andrew Petelin 2014-11-08 20:35:20 UTC]

OK, I will try to find some time to prepare the correct (temporary) solution for moving completion-script to the lftp package, and write here about results.

Thank you!

[Comment 9 Jeroen Roovers (RETIRED) 2014-11-08 20:38:09 UTC]

(In reply to Andrew Petelin from comment #8)
> OK, I will try to find some time to prepare the correct (temporary) solution
> for moving completion-script to the lftp package, and write here about
> results.

Who's moving what now?

[Comment 10 Andrew Petelin 2014-11-08 21:13:31 UTC]

>> Who's moving what now?

> The alternative is to move the file to Gentoo lftp package and fix it there. Even better, send it to lftp upstream and ask to be included. Note that this requires a license check.

[Comment 11 Jeroen Roovers (RETIRED) 2014-11-09 09:29:32 UTC]

(In reply to Andrew Petelin from comment #10)
> >> Who's moving what now?
> 
> > The alternative is to move the file to Gentoo lftp package and fix it there. Even better, send it to lftp upstream and ask to be included. Note that this requires a license check.

The current completion script has a bug that should be fixed, preferably upstream. How would moving it to another package or a different upstream help?

[Comment 12 Andrew Petelin 2014-11-09 11:26:09 UTC]

(In reply to Jeroen Roovers from comment #11)
> The current completion script has a bug that should be fixed, preferably
> upstream. How would moving it to another package or a different upstream
> help?

Read the full discussion, Luke :)

I have already posted the patch to the upstream, but there is *no* activity.

[Comment 13 Jeroen Roovers (RETIRED) 2014-11-09 11:39:56 UTC]

(In reply to Andrew Petelin from comment #12)
> I have already posted the patch to the upstream, but there is *no* activity.

That's fine then, because now you can safely apply it here.

[Comment 14 Andrew Petelin 2015-12-01 18:26:53 UTC]

Created attachment 418304 [details, diff]
bash completion file for lftp

OK, here is a patch to fix this bug.

I've analyzed the sources of lftp and it turned out, that both locations for the `bookmarks` file are possible (depending on the existance of the ~/.lftp directory).

[Comment 15 Andrew Petelin 2015-12-01 18:30:23 UTC]

(The patch has been tested on app-shells/bash-completion-2.1_p20141224.)

[Comment 16 Andrew Petelin 2015-12-01 18:38:18 UTC]

Oh, I have already posted the same patch before, sorry. Can we apply this fix to the bash-completion package, or should I nevertheless contact the developer to add the completion script to his lftp repository (https://github.com/lavv17/lftp)?

[Comment 17 Jeroen Roovers (RETIRED) 2016-12-28 15:00:28 UTC]

(In reply to Michał Górny from comment #4)
> It's http://anonscm.debian.org/cgit/bash-completion/bash-completion.git.

No updates since 2011.

[Comment 18 Jeroen Roovers (RETIRED) 2016-12-28 15:09:46 UTC]

(In reply to Jeroen Roovers from comment #17)
> No updates since 2011.

I.e. https://anonscm.debian.org/cgit/bash-completion/bash-completion.git/log/completions/lftpget and https://anonscm.debian.org/cgit/bash-completion/bash-completion.git/log/completions/lftp

[Comment 19 Michał Górny 2017-07-02 22:04:05 UTC]

bash-completion has active upstream now, so submitted your patch in a pull request [1]. I think it's going to be merged soon.

[1]:https://github.com/scop/bash-completion/pull/144

[Comment 20 Michał Górny 2017-07-04 17:43:36 UTC]

Upstream has merged the PR, so the fix should be in the next release.

[Comment 21 kfm 2021-01-07 15:42:33 UTC]

Closing because no affected versions remain in the gentoo repo. Note that the completion function now runs lftp -c "bookmark list".