Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 527164 - app-shells/bash-completion-2.1-r91 /etc/profile.d/ rename breaks existing .bashrc use
Summary: app-shells/bash-completion-2.1-r91 /etc/profile.d/ rename breaks existing .ba...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Shell Tools project
URL:
Whiteboard:
Keywords:
Depends on: 338335
Blocks:
  Show dependency tree
 
Reported: 2014-10-27 23:08 UTC by Sebastian Pipping
Modified: 2017-07-02 22:05 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Sebastian Pipping gentoo-dev 2014-10-27 23:08:23 UTC
After updating to bash-completion-2.1-r91 I get an error

  bash: /etc/profile.d/bash-completion.sh: No such file or directory

during login.  It seems that bash-completion.sh has been renamed to bash_completion.sh, with no transition symlink or a portage news entry.

It doesn't block my log-in but I'm still rather surprise that this hits me in the face.  Maybe we can make it a bit smoother.  What do you think?
Comment 1 Jerome Venturi 2014-11-04 11:09:39 UTC
Agree with this comment.
I spent almost one hour to figure out why my completion isn't working any more ...

And i didn't get the error because my bashrc is write like that :

[[ -f /etc/profile.d/bash-completion.sh ]] && . /etc/profile.d/bash-completion.sh

A warning during the update could be a good thing ...
Comment 2 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2014-11-06 09:06:38 UTC
We'll probably be fixing this with another move, for bug #338335.
Comment 3 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2014-11-09 20:44:44 UTC
The initialization files have been moved to bashrc.d now, and therefore it shouldn't be necessary to source them anymore. Do you think we should add some more information about that?
Comment 4 Sebastian Pipping gentoo-dev 2014-11-17 22:39:23 UTC
(In reply to Michał Górny from comment #3)
> The initialization files have been moved to bashrc.d now, and therefore it
> shouldn't be necessary to source them anymore.

I noticed the second move but updated the source line to say

  source /etc/bash/bashrc.d/bash_completion.sh

So at least I did fail at understanding that that location resolves need for sourcing.


> Do you think we should add
> some more information about that?

I tend to say yes but I guess I'm biased here.
Comment 5 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2014-11-18 11:18:23 UTC
(In reply to Sebastian Pipping from comment #4)
> (In reply to Michał Górny from comment #3)
> > The initialization files have been moved to bashrc.d now, and therefore it
> > shouldn't be necessary to source them anymore.
> 
> I noticed the second move but updated the source line to say
> 
>   source /etc/bash/bashrc.d/bash_completion.sh
> 
> So at least I did fail at understanding that that location resolves need for
> sourcing.
> 
> 
> > Do you think we should add
> > some more information about that?
> 
> I tend to say yes but I guess I'm biased here.

It's mentioned in the bash-completion news item RFC:

| Lastly, we have solved the issue causing bash-completion support to be
| enabled by default on login shells only. If you needed to explicitly
| source 'bash_completion' script in bashrc, you can safely remove that
| code now since system-wide bashrc takes care of loading it.

I'll probably commit it soon and request stabilization of new bashcomp.
Comment 6 Sebastian Pipping gentoo-dev 2014-11-18 14:09:14 UTC
Alright, cool, I didn't know there was a news item in preparation.  I'm all happy if there's a news item soon.
Comment 7 Leho Kraav (:macmaN @lkraav) 2015-02-07 23:18:56 UTC
How's this coming along?
Comment 8 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2017-07-02 22:05:55 UTC
The news item was committed a long time ago, so closing.