Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 524806 - app-mobilephone/dfu-util-0.9 version bump
Summary: app-mobilephone/dfu-util-0.9 version bump
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Michael 'veremitz' Everitt
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-10-09 08:11 UTC by Priit Laes (IRC: plaes)
Modified: 2016-08-25 19:04 UTC (History)
5 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
dfu-util-0.8.ebuild, dfu-util-9999.ebuild (dev-embedded-dfu-util.tar.gz,1.16 KB, application/x-gzip)
2015-06-10 15:20 UTC, Christopher Friedt
Details
dfu-util-0.8.ebuild, dfu-util-9999.ebuild (dev-embedded-dfu-util.tar.gz,1.17 KB, application/x-gzip)
2015-06-10 15:25 UTC, Christopher Friedt
Details
dfu-util-0.7.ebuild, dfu-util-0.8.ebuild, dfu-util-9999.ebuild (dev-embedded-dfu-util.tar.gz,1.57 KB, application/x-gzip)
2015-06-11 14:33 UTC, Christopher Friedt
Details
dfu-util-0.7.ebuild, dfu-util-0.8.ebuild, dfu-util-9999.ebuild (dev-embedded-dfu-util.tar.gz,2.15 KB, application/x-gzip)
2015-06-11 17:52 UTC, Christopher Friedt
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Priit Laes (IRC: plaes) 2014-10-09 08:11:08 UTC
dfu-util-0.8 has been released.

Also, would it make sense to move this application to dev-embedded instead?
Comment 1 Christopher Friedt 2015-06-10 15:19:16 UTC
Has this still not moved anywhere??

Since then, it would appear that upstream development has been moved to gitorious[1].

That is where the sf.net page[2] links, and there is activity as recent as March 10, 2015. as the most recent commit is 

[1] https://gitorious.org/dfu-util
[2] http://dfu-util.sourceforge.net/

Please see the attached tarball of ebuilds

ALSO PLEASE SOMEBODY ASK DFU-UTIL TO RELEASE TARBALLS UNDER "FILES" IN SF.NET, SO THAT GENTOO'S MIRRORING SYSTEM WORKS PROPERLY!
Comment 2 Christopher Friedt 2015-06-10 15:20:35 UTC
Created attachment 404896 [details]
dfu-util-0.8.ebuild, dfu-util-9999.ebuild
Comment 3 Christopher Friedt 2015-06-10 15:25:49 UTC
Created attachment 404898 [details]
dfu-util-0.8.ebuild, dfu-util-9999.ebuild

Repaired git EGIT_REPO_SRC_URI
Comment 4 Christopher Friedt 2015-06-10 15:32:59 UTC
(In reply to Christopher Friedt from comment #1)
> ALSO PLEASE SOMEBODY ASK DFU-UTIL TO RELEASE TARBALLS UNDER "FILES" IN
> SF.NET, SO THAT GENTOO'S MIRRORING SYSTEM WORKS PROPERLY!

I emailed Stefan Schmidt who is partly in charge of the project to ask him to populate some tarballs in the "Files" section.

Once that is done, the ebuilds can be updated accordingly.
Comment 5 Pacho Ramos gentoo-dev 2015-06-10 21:09:13 UTC
Are you willing to proxy maintain this?
https://wiki.gentoo.org/wiki/Project:Proxy_Maintainers

(the package currently has no maintainer downstream and that is the reason no action was taken yet)

Thanks
Comment 6 Christopher Friedt 2015-06-11 14:33:54 UTC
Created attachment 404970 [details]
dfu-util-0.7.ebuild, dfu-util-0.8.ebuild, dfu-util-9999.ebuild

using mirror://sourceforge now
Comment 7 Christopher Friedt 2015-06-11 14:39:59 UTC
Thank you to Tormod Volden for copying tarballs into the "Files" section!
Comment 8 Christopher Friedt 2015-06-11 17:52:38 UTC
Created attachment 404982 [details]
dfu-util-0.7.ebuild, dfu-util-0.8.ebuild, dfu-util-9999.ebuild

Tormod says that gitorious is currently read-only (as they were recently purchased and repos shut-down), and SF.net is the active git.
Comment 9 Ian Delaney (RETIRED) gentoo-dev 2015-11-10 00:47:26 UTC
June is 5 months ago now. Christopher Friedt ? Inclined towards proxy maintaining the package? The poject of proxy-maintainers offers solid support to proxied users.
Comment 10 Michael 'veremitz' Everitt 2016-01-13 21:31:53 UTC
I am in the process of updating this package, and taking on proxy maintenance for it. Any queries, contact Ian in the first instance.
Comment 11 Ian Delaney (RETIRED) gentoo-dev 2016-02-01 07:29:19 UTC
Actually for the sake of consistency and notation, the re-assignment of a bug need be held off until the new or repaired state if the package is added to portage. Do to no forseeable trouble here, let this go for now.
Comment 12 Christopher Head 2016-03-12 23:33:10 UTC
Version 0.9 is out now.
Comment 13 Christopher Head 2016-03-12 23:38:14 UTC
As with 0.8, a copy and paste appears to work.
Comment 14 Ian Delaney (RETIRED) gentoo-dev 2016-03-19 09:09:58 UTC
(In reply to Christopher Head from comment #13)
> As with 0.8, a copy and paste appears to work.

C. Head would you care to be a co-maintainer under proxy-maintainers project?

https://wiki.gentoo.org/wiki/Project:Proxy_Maintainers
Comment 15 Ian Delaney (RETIRED) gentoo-dev 2016-03-19 10:35:13 UTC
(In reply to Michael Everitt (veremit) from comment #10)
> I am in the process of updating this package, and taking on proxy
> maintenance for it. Any queries, contact Ian in the first instance.

Are you intending to persist with this package?
Comment 16 Michael 'veremitz' Everitt 2016-03-19 10:52:14 UTC
[ 4:34am] michael@ds-miche2 .../repos/gentoo/app-mobilephone/dfu-util $ nano dfu-util-0.9.ebuild 
[ 4:34am] michael@ds-miche2 .../repos/gentoo/app-mobilephone/dfu-util $ repoman full -x

RepoMan scours the neighborhood...
[INFO] checking package app-mobilephone/dfu-util

Note: use --include-dev (-d) to check dependencies for 'dev' profiles

RepoMan sez: "If everyone were like you, I'd be out of business!"


Looking good to me. Awaiting confirmation from sci-electronics for adding to metadata.xml.
Comment 17 Christopher Head 2016-03-19 20:49:24 UTC
(In reply to Ian Delaney from comment #14)
> (In reply to Christopher Head from comment #13)
> > As with 0.8, a copy and paste appears to work.
> 
> C. Head would you care to be a co-maintainer under proxy-maintainers project?
> 
> https://wiki.gentoo.org/wiki/Project:Proxy_Maintainers

I can be if you think that would be helpful; is it usual for packages to have two proxy maintainers? It seems like Michael is getting on board already.
Comment 18 Michael 'veremitz' Everitt 2016-03-20 03:13:09 UTC
Hi Chris,

I'm sure Ian can/will confirm, but there's nothing to stop more than one person 'proxying' a package .. it provides an additional pathway for bugs/updates to get handled if one pathway is temporarily unavailable. If you would like to join the P-M project, I'm quite happy for you to co-maintain this - there isn't a lot to do currently, just need to jump through a few gentoo hoops! :]

Michael.
Comment 19 Ian Delaney (RETIRED) gentoo-dev 2016-03-20 12:40:52 UTC
This is the next step to receive notification is done and then I can commit this. C. Head, your call. Considering Michael's welcoming tone, you can be added if you like, then you both have opportunity to submit bumps / fixes, which we will review and add accordingly.

Thx both.
Comment 20 Christopher Head 2016-03-20 18:27:51 UTC
Sure, I can be added as a proxy maintainer then. I’m already a proxy maintainer for one package (app-misc/pwsafe), if that makes anything easier.
Comment 21 Ian Delaney (RETIRED) gentoo-dev 2016-03-21 09:25:09 UTC
So I will add C. Head as co-maintainer, and perfinion seems to be away for a few days.  For now I will hold off for him to review, then commit with decided adjustments.
Comment 22 Jason Zaman gentoo-dev 2016-03-21 14:54:24 UTC
I made a few updates to the ebuild. it builds for -9999 for me but I dont use the package so cant runtest it.

Mainly update to EAPI6 and use the DOCS variable so the default install phase can be used.

diff --git a/app-mobilephone/dfu-util/dfu-util-9999.ebuild b/app-mobilephone/dfu-util/dfu-util-9999.ebuild
index 50df59c..18e4175 100644
--- a/app-mobilephone/dfu-util/dfu-util-9999.ebuild
+++ b/app-mobilephone/dfu-util/dfu-util-9999.ebuild
@@ -2,20 +2,19 @@
 # Distributed under the terms of the GNU General Public License v2
 # $Id$
 
-EAPI=5
+EAPI=6
 
 if [[ ${PV} == "9999" ]] ; then
-       EGIT_REPO_URI="git://git.openezx.org/dfu-util.git"
-       inherit autotools git-2
+       EGIT_REPO_URI="http://git.code.sf.net/p/dfu-util/dfu-util"
        SRC_URI=""
-       #KEYWORDS=""
+       inherit autotools git-r3
 else
-       SRC_URI="http://dfu-util.gnumonks.org/releases/${P}.tar.gz"
+       SRC_URI="mirror://sourceforge/${PN}/${P}.tar.gz"
        KEYWORDS="~amd64 ~x86"
 fi
 
 DESCRIPTION="implements the Host (PC) side of the USB DFU (Device Firmware Upgrade) protocol"
-HOMEPAGE="http://wiki.openmoko.org/wiki/Dfu-util"
+HOMEPAGE="http://dfu-util.sourceforge.net/"
 
 LICENSE="GPL-2"
 SLOT="0"
@@ -25,14 +24,13 @@ RDEPEND="virtual/libusb:1"
 DEPEND="${RDEPEND}
        virtual/pkgconfig"
 
+DOCS=( ChangeLog README TODO )
+
 src_prepare() {
        if [[ ${PV} == "9999" ]] ; then
                eautoreconf
        fi
        sed -i '/^bin_PROGRAMS/s:dfu-util_static[^ ]*::' src/Makefile.in
-}
 
-src_install() {
-       emake DESTDIR="${D}" install || die
-       dodoc ChangeLog README TODO
+       eapply_user
 }
Comment 23 Michael 'veremitz' Everitt 2016-03-22 15:51:24 UTC
Thanks Jason .. with the exception of the EAPI6 stuff, I think that will patch my versions quite easily :)
Comment 24 Michael 'veremitz' Everitt 2016-03-22 15:53:11 UTC
(In reply to Michael Everitt (veremit) from comment #23)
> Thanks Jason .. with the exception of the EAPI6 stuff, I think that will
> patch my versions quite easily :)

That was gibberish, sorry forks for spam...I meant:

With the excpetion of the bump to EAPI6 I think I had those changes bagged, but the switch to EAPI6 makes sense, and will apply easily to my versions!
Comment 25 Michael 'veremitz' Everitt 2016-04-02 14:55:10 UTC
CC'ing embedded@ to see if they mind a category change, and/or joining the maintainer projects list.
Comment 26 David Turner 2016-04-02 17:51:33 UTC
Just a quick note. A new python tool, dfuse-pack.py was added to the dfu-util package with 0.8 onwards. This is required to pack several binaries with different memory load addresses into a single DFU file as per ST Micro's DfuSe standard. However, this is not installed by the "make install" target so this is currently not being installed by the Gentoo ebuilds.

The following patch should be applied to dfu-util-0.8 and dfu-util-0.9 ebuild as well as the live-9999 ebuild to do this. Since the tool is Python 2 code and will not run under Python 3, a sed line modifies this to explicitly use the Python2 interpreter:

a/platform/gentoo/usr/local/portage-overlay/app-mobilephone/dfu-util/dfu-util-0.8.ebuild
+++
b/platform/gentoo/usr/local/portage-overlay/app-mobilephone/dfu-util/dfu-util-0.8.ebuild
@@ -31,9 +31,11 @@ src_prepare() {
 		eautoreconf
 	fi
 	sed -i '/^bin_PROGRAMS/s:dfu-util_static[^ ]*::' src/Makefile.in
+	sed -i 's:/usr/bin/python:/usr/bin/python2:' dfuse-pack.py
 }

 src_install() {
 	emake DESTDIR="${D}" install || die
+	dobin dfuse-pack.py
 	dodoc ChangeLog README TODO
 }
Comment 27 Christopher Head 2016-04-02 18:09:10 UTC
(In reply to David Turner from comment #26)
> Just a quick note. A new python tool, dfuse-pack.py was added to the
> dfu-util package with 0.8 onwards. This is required to pack several binaries
> with different memory load addresses into a single DFU file as per ST
> Micro's DfuSe standard. However, this is not installed by the "make install"
> target so this is currently not being installed by the Gentoo ebuilds.
> 
> The following patch should be applied to dfu-util-0.8 and dfu-util-0.9
> ebuild as well as the live-9999 ebuild to do this. Since the tool is Python
> 2 code and will not run under Python 3, a sed line modifies this to
> explicitly use the Python2 interpreter:

Shouldn’t we be using python_doscript from python-utils-r1.eclass here, instead?
Comment 28 Michael 'veremitz' Everitt 2016-04-02 19:05:49 UTC
(In reply to Christopher Head from comment #27)
> 
> Shouldn’t we be using python_doscript from python-utils-r1.eclass here,
> instead?

I think then you might want to add the 'python' USE flag (or similar) and then go through the python eclass hoops.

Seeking further wisdom from the gentoo-python team...
Comment 29 Michael 'veremitz' Everitt 2016-04-02 19:10:21 UTC
(In reply to Christopher Head from comment #27)
> 
> Shouldn’t we be using python_doscript from python-utils-r1.eclass here,
> instead?

I think then you might want to add the 'python' USE flag (or similar) and then go through the python eclass hoops.

Seeking further wisdom from the gentoo-python team...
Comment 30 Christopher Head 2016-04-02 19:53:44 UTC
(In reply to Michael Everitt (veremit) from comment #29)
> I think then you might want to add the 'python' USE flag (or similar) and
> then go through the python eclass hoops.

I found the hoops not so bad; I’ve used the python-*-r1 eclasses in one or two of my personal ebuilds and it worked out quite smoothly. I’d be happy to work up an ebuild using the eclasses if that’s the direction we decide on going.
Comment 31 Mike Gilbert gentoo-dev 2016-04-02 22:21:00 UTC
Is it just a simple script with no third-party module requirements? If so, that sed is fine.

If you need to depend on additional python packages, use python-single-r1 eclass. Docs are on the wiki.
Comment 32 David Turner 2016-04-03 01:40:34 UTC
One other point, both v0.8 and v0.9 have fairly major bug if dfu-suffix are added to binary files, resulting in the suffix data being programmed to the flash region... This is not a blocker on v0.8 and v0.9 as all versions are affected, but just a note for anyone using this and have reported this to upstream:
https://sourceforge.net/p/dfu-util/tickets/18/
Comment 33 Ian Delaney (RETIRED) gentoo-dev 2016-04-13 08:15:21 UTC
getting there
Comment 34 Michael 'veremitz' Everitt 2016-04-24 17:12:52 UTC
Have submitted a bug to upstream, to tidy up the Python issues, then hopefully we can get a good, slick, compatible ebuild into tree.

https://sourceforge.net/p/dfu-util/tickets/19/
Comment 36 Tim Harder gentoo-dev 2016-08-25 19:04:45 UTC
Added to the tree.