Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 524580 - app-emulation/vmware-modules-279.2 with kernel 3.17 - .../work/vmnet-only/netif.c:152:64: error: macro "alloc_netdev" requires 4 arguments, but only 3 given
Summary: app-emulation/vmware-modules-279.2 with kernel 3.17 - .../work/vmnet-only/net...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Library (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo VMWare Bug Squashers [disabled]
URL: https://lkml.org/lkml/2014/2/27/339
Whiteboard:
Keywords: PATCH
Depends on:
Blocks:
 
Reported: 2014-10-06 02:30 UTC by Sergey Ilinykh
Modified: 2015-09-19 00:00 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
279-kernel-3.17.patch (279-kernel-3.17.patch,538 bytes, patch)
2014-10-06 06:32 UTC, rainbow
Details | Diff
vmware-modules-279.2-3.17.patch (279-3.17.0.patch,552 bytes, patch)
2014-10-06 10:47 UTC, Mike Auty (RETIRED)
Details | Diff
build.log (build.log,40.92 KB, text/plain)
2014-10-06 17:49 UTC, Sergey Ilinykh
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Sergey Ilinykh 2014-10-06 02:30:53 UTC
vmware-modules-279.2 fails to build with new kernel due to changes in alloc_netdev macro definition (name_assign_type param added).
google says NET_NAME_USER should be used for name_assign_type.

can someone make a patch?

Reproducible: Always
Comment 1 rainbow 2014-10-06 06:32:18 UTC
Created attachment 386122 [details, diff]
279-kernel-3.17.patch
Comment 2 Jeroen Roovers (RETIRED) gentoo-dev 2014-10-06 07:50:47 UTC
1) Please post your `emerge --info' output in a comment.
2) Please attach the entire build log to this bug report.
Comment 3 Sergey Ilinykh 2014-10-06 07:58:20 UTC
@rainbow, I believe it should check kernel version

@Jeroen, from interesting: gentoo-sources. all other doesn't matter.
why have you changed the topic? I usually prefer search by error message.
Comment 4 Jeroen Roovers (RETIRED) gentoo-dev 2014-10-06 09:08:25 UTC
(In reply to Rion from comment #3)
> @Jeroen, from interesting: gentoo-sources. all other doesn't matter.
> why have you changed the topic? I usually prefer search by error message.

Because it was an incomplete error message. Please post the entire build log and your `emerge --info' output.
Comment 5 Mike Auty (RETIRED) gentoo-dev 2014-10-06 10:47:45 UTC
Created attachment 386130 [details, diff]
vmware-modules-279.2-3.17.patch

Attached is a patch which can be dropped into /etc/portage/patches/vmware-modules-279.2/ that makes the change listed in the bug, and does so conditionally based on the kernel in use...
Comment 6 Mike Auty (RETIRED) gentoo-dev 2014-10-06 10:49:54 UTC
I've used NET_NAME_USER rather than NET_NAME_UNKNOWN because the vmware driver always provides a name (I assume "vmnet0" or "vmnet8", etc) and these will probably need to be in-sync for vmware to attach to them appropriately.  As such, it seems like NET_NAME_USER is a better fit, but it should be easy to change in the patch if necessary.
Comment 7 Sergey Ilinykh 2014-10-06 17:46:42 UTC
thanks Mike =)


@Jeroen,

here is your useless info

Portage 2.2.14_rc1 (python 2.7.8-final-0, default/linux/amd64/13.0/developer, gcc-4.8.3, glibc-2.19-r1, 3.15.10-gentoo x86_64)
=================================================================
                         System Settings
=================================================================
System uname: Linux-3.15.10-gentoo-x86_64-Intel-R-_Core-TM-_i7-3610QM_CPU_@_2.30GHz-with-gentoo-2.2
KiB Mem:    16309472 total,   4241260 free
KiB Swap:          0 total,         0 free
Timestamp of tree: Mon, 06 Oct 2014 01:00:01 +0000
ld GNU ld (Gentoo 2.24 p1.4) 2.24
distcc 3.1 x86_64-pc-linux-gnu [disabled]
ccache version 3.1.9 [disabled]
app-shells/bash:          4.2_p52
dev-java/java-config:     2.2.0
dev-lang/perl:            5.20.1
dev-lang/python:          2.7.8, 3.3.5-r1, 3.4.1
dev-util/ccache:          3.1.9-r3
dev-util/cmake:           3.0.2
dev-util/pkgconfig:       0.28-r2
sys-apps/baselayout:      2.2
sys-apps/openrc:          0.13.1
sys-apps/sandbox:         2.6-r1
sys-devel/autoconf:       2.13, 2.69
sys-devel/automake:       1.11.6, 1.12.6, 1.14.1
sys-devel/binutils:       2.24-r3
sys-devel/gcc:            4.7.4, 4.8.3
sys-devel/gcc-config:     1.8
sys-devel/libtool:        2.4.2-r1
sys-devel/make:           4.0-r1
sys-kernel/linux-headers: 3.16 (virtual/os-headers)
sys-libs/glibc:           2.19-r1
Repositories: gentoo rion sunrise Armageddon mate-overlay x11 test
Installed sets: @system
ACCEPT_KEYWORDS="amd64 ~amd64"
ACCEPT_LICENSE="*"
CBUILD="x86_64-pc-linux-gnu"
CFLAGS="-march=native -O2 -pipe -maes"
CHOST="x86_64-pc-linux-gnu"
CONFIG_PROTECT="/etc /opt/openfire/resources/security/ /usr/share/config /usr/share/gnupg/qualified.txt"
CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/env.d /etc/fonts/fonts.conf /etc/gconf /etc/gentoo-release /etc/php/apache2-php5.5/ext-active/ /etc/php/apache2-php5.6/ext-active/ /etc/php/cgi-php5.5/ext-active/ /etc/php/cgi-php5.6/ext-active/ /etc/php/cli-php5.5/ext-active/ /etc/php/cli-php5.6/ext-active/ /etc/revdep-rebuild /etc/sandbox.d /etc/terminfo /etc/texmf/language.dat.d /etc/texmf/language.def.d /etc/texmf/updmap.d /etc/texmf/web2c"
CXXFLAGS="-march=native -O2 -pipe -maes"
DISTDIR="/home/portage/distfiles"
FCFLAGS="-O2 -pipe"
FEATURES="assume-digests binpkg-logs config-protect-if-modified digest distlocks ebuild-locks fixlafiles merge-sync news parallel-fetch preserve-libs protect-owned sandbox sfperms sign splitdebug strict test-fail-continue unknown-features-warn unmerge-logs unmerge-orphans userfetch userpriv usersandbox usersync"
FFLAGS="-O2 -pipe"
GENTOO_MIRRORS="http://distfiles.gentoo.org"
LANG="ru_RU.UTF-8"
LDFLAGS="-Wl,--hash-style=gnu -Wl,-O1 -Wl,--as-needed"
MAKEOPTS="-j9"
PKGDIR="/home/portage/packages"
PORTAGE_CONFIGROOT="/"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --omit-dir-times --compress --force --whole-file --delete --stats --human-readable --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages"
PORTAGE_TMPDIR="/home/portage/build"
PORTDIR="/home/portage/portage"
PORTDIR_OVERLAY="/var/lib/layman/rion /var/lib/layman/sunrise /var/lib/layman/Armageddon /var/lib/layman/mate /var/lib/layman/x11 /home/rion/projects/test-overlay"
USE="X a52 aac acl acpi alsa amd64 avahi avx bash-completion berkdb bluetooth branding bzip2 cairo cdda cddb cdio cdr cli consolekit cracklib crypt cups custom-optimization cxx dbus dri dts dv dvb dvd dvdnav dvdr emboss encode exif faac faad fam ffmpeg firefox flac fuse gallium gif glamor glitz gnome-keyring gphoto2 gpm gsm gstreamer gtk gtk3 h323 iconv idn ipv6 jabber java6 jingle jpeg jpeg2k kde lcms libcanberra libnotify libsecret mad mate mmx mng modemmanager modplug modules mp3 mp4 mpeg mtp multilib ncurses networkmanager nls nptl ogg opengl openmp pam pango pch pcmcia pcre pdf pm-utils png policykit ppds pulseaudio qalculate qml qt3support qt4 readline rtmp samba schroedinger sdl semantic-desktop session sip smp snmp speex spell sse sse2 sse3 sse4 sse4_2 ssl ssse3 startup-notification subversion svg symlink tcpd theora threads thunar tiff tokenizer truetype udev udisks unicode upnp upower usb v4l v4l2 vaapi vdpau vhosts vnc vorbis vpx webkit webp wifi x264 xcb xcomposite xinerama xml xv xvid xvmc zlib" ABI_X86="64" ALSA_CARDS="ali5451 als4000 atiixp atiixp-modem bt87x ca0106 cmipci emu10k1x ens1370 ens1371 es1938 es1968 fm801 hda-intel intel8x0 intel8x0m maestro3 trident usb-audio via82xx via82xx-modem ymfpci" APACHE2_MODULES="dav dav_fs authn_file auth_basic auth_digest authz_groupfile authz_host dir mime log_config" CALLIGRA_FEATURES="kexi words flow plan sheets stage tables krita karbon braindump author" CAMERAS="ptp2 canon" COLLECTD_PLUGINS="df interface irq load memory rrdtool swap syslog" DRACUT_MODULES="plymouth" ELIBC="glibc" GPSD_PROTOCOLS="ashtech aivdm earthmate evermore fv18 garmin garmintxt gpsclock itrax mtk3301 nmea ntrip navcom oceanserver oldstyle oncore rtcm104v2 rtcm104v3 sirf superstar2 timing tsip tripmate tnt ublox ubx" GRUB_PLATFORMS="pc" INPUT_DEVICES="evdev synaptics" KERNEL="linux" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LIBREOFFICE_EXTENSIONS="presenter-console presenter-minimizer" LINGUAS="ru ru_RU en" NETBEANS_MODULES="apisupport harness ide nb websvccommon php profiler webcommon cnd ergonomics dlight" NGINX_MODULES_HTTP="dav fastcgi flv access auth_basic autoindex charset browser empty_gif gzip map memcached rewrite userid" OFFICE_IMPLEMENTATION="libreoffice" PHP_TARGETS="php5-5" PYTHON_SINGLE_TARGET="python2_7" PYTHON_TARGETS="python2_7 python3_3" QEMU_SOFTMMU_TARGETS="i386 x86_64" QEMU_USER_TARGETS="i386 x86_64" RUBY_TARGETS="ruby19 ruby20 ruby21" USERLAND="GNU" VIDEO_CARDS="vesa intel i965 fglrx" XTABLES_ADDONS="quota2 psd pknock lscan length2 ipv4options ipset ipp2p iface geoip fuzzy condition tee tarpit sysrq steal rawnat logmark ipmark dhcpmac delude chaos account"
Unset:  CPPFLAGS, CTARGET, EMERGE_DEFAULT_OPTS, INSTALL_MASK, LC_ALL, PORTAGE_BUNZIP2_COMMAND, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS, SYNC, USE_PYTHON

=================================================================
                        Package Settings
=================================================================

app-emulation/vmware-modules-279.2 was built with the following:
USE="-pax_kernel -vmci -vsock" ABI_X86="64"
CFLAGS="-march=core-avx-i -O2 -pipe"
Comment 8 Sergey Ilinykh 2014-10-06 17:49:13 UTC
Created attachment 386144 [details]
build.log

and build log.
Comment 9 Adam Carter 2014-10-10 00:25:32 UTC
FYI, Mike's patch fixed the build issue and vmware now works on 3.17 for me. I use the kernel supplied modules where available, ie
CONFIG_VMXNET3=m
CONFIG_VMWARE_VMCI_VSOCKETS=m
CONFIG_VMWARE_VMCI=m
CONFIG_VMWARE_PVSCSI=m

$ ls /etc/portage/patches/app-emulation/vmware-modules/
279-3.17.0.patch  279-getname.patch  279-kernel-3.15.patch  inode_patch.patch
Comment 10 rumcho 2014-12-27 03:26:52 UTC
(In reply to Adam Carter from comment #9)
> FYI, Mike's patch fixed the build issue and vmware now works on 3.17 for me.
> I use the kernel supplied modules where available, ie
> CONFIG_VMXNET3=m
> CONFIG_VMWARE_VMCI_VSOCKETS=m
> CONFIG_VMWARE_VMCI=m
> CONFIG_VMWARE_PVSCSI=m
> 
> $ ls /etc/portage/patches/app-emulation/vmware-modules/
> 279-3.17.0.patch  279-getname.patch  279-kernel-3.15.patch  inode_patch.patch

For kernel 3.17.7 I also needed to add patches:
vsock.patch
https://bugs.gentoo.org/attachment.cgi?id=380802
and 
vmci.patch
https://bugs.gentoo.org/attachment.cgi?id=380800
to directory /etc/portage/patches/app-emulation/vmware-modules-279.2/
Comment 11 Evan Teran 2015-07-11 04:54:16 UTC
The latest official vmware overlay has had the version bumped.

I have built the sources for vmware-modules-{271,279,304} on stock kernels 3.10 - 4.0, and associated vmware-workstation-{9,10,11} ebuilds.

Please give those a try and let me know if you have any issues.

Thanks
Comment 12 Mike Auty (RETIRED) gentoo-dev 2015-07-11 11:22:20 UTC
Please don't mark bugs as fixed if they're not fixed in the main tree, otherwise we lose track of them, the main tree stays broken and no one knows where to look for the working ebuild...
Comment 13 Andreas K. Hüttel archtester gentoo-dev 2015-09-19 00:00:03 UTC
(In reply to Mike Auty from comment #12)
> Please don't mark bugs as fixed if they're not fixed in the main tree,
> otherwise we lose track of them, the main tree stays broken and no one knows
> where to look for the working ebuild...

Also fixed in the main tree now