Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 524266 - kde-base/systemsettings might be using old Display module
Summary: kde-base/systemsettings might be using old Display module
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] KDE (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo KDE team
URL:
Whiteboard:
Keywords:
Depends on: 525558
Blocks:
  Show dependency tree
 
Reported: 2014-10-02 10:36 UTC by DrSlony
Modified: 2014-10-26 16:03 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description DrSlony 2014-10-02 10:36:38 UTC
Hi

Today I learned of KScreen which handles multiple displays and not messing with the calibration curves in the GPU better than the old Display module.

This is what KScreen looks like:
http://i.imgur.com/lQcrBdz.png

This is what the old Display module looks like:
http://i.imgur.com/GXPWcwk.png

I am writing this report to ask and suggest something:
1- How do I remove the old Display module? I can't find any corresponding ebuild or filename. Someone on IRC suggested "Might be the krandr stuff from kde-base/systemsettings ebuild. Dunno if you can get rid of it without use of INSTALL_MASK (which is dangerous and thus not recommended)".
2- If so, the ebuild should be updated to allow removal of the old stuff in favor of the new KScreen.
3- There is the possibility that the old Display is supposed to remain along with KScreen, though I think this is unlikely. The appropriate devs should comment. The reason I have this doubt is that KScreen does not support all of the things Display used to, e.g. cloning, so either they are designed to work side by side, or the missing feature(s) simply hasn't been implemented yet.
Comment 1 Michael Palimaka (kensington) gentoo-dev 2014-10-02 18:29:35 UTC
Unfortunately our support of KScreen is quite lacking, but this is a good opportunity to improve it. We can add a new USE flag to systemsettings to disable the old module and pull in kscreen instead.

The reason the old module remains upstream is because it's part of kde-workspace which is in bugfix-only mode. It's removed completely in Plasma 5.
Comment 2 Michael Palimaka (kensington) gentoo-dev 2014-10-02 18:51:37 UTC
I've pushed a commit to the overlay which addresses this.

https://github.com/gentoo/kde/commit/f7f5d84c85b6c7f946b94808849648b4cb6ea667
Comment 3 DrSlony 2014-10-02 19:39:52 UTC
Thank you!
Comment 4 Duncan 2014-10-03 09:34:55 UTC
(In reply to Michael Palimaka (kensington) from comment #2)
> I've pushed a commit to the overlay which addresses this.
> 
> https://github.com/gentoo/kde/commit/f7f5d84c85b6c7f946b94808849648b4cb6ea667

This commit, and associated USE=kscreen, breaks (kdebase-)startkde, returning me to the CLI when I try to startx.

I found the culprit in the ~/.xsession-errors log: startkde:108 unconditionally sources krandrstartup and errors out if it isn't there:

. krandrstartup

Commenting that line allowed me to startkde and thus startx just fine. =:^)

I'd suggest patching the file in kdebase-startkde to make it a conditional source.  Matching the conditional sourcing of (user's) startupconfig a few lines up (line 88), the call would look like this:

[ -r /usr/bin/startkde ] && . /usr/bin/startkde

That avoids having to add IUSE=kscreen to kdebase-startkde, as well.
Comment 5 Michael Palimaka (kensington) gentoo-dev 2014-10-03 18:04:08 UTC
Thanks for testing!

This regression should now be fixed in git. I borrowed a slightly different approach from Fedora to avoid breaking Prefix installations.

https://github.com/gentoo/kde/commit/f43a9f34e3d0223a96a60ac9a7506608b665ce26
Comment 6 Michael Palimaka (kensington) gentoo-dev 2014-10-26 16:03:29 UTC
Thanks, this is in the tree as of 4.11.13.