Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 51008 - app-misc/gallery moved to webapp.eclass
Summary: app-misc/gallery moved to webapp.eclass
Status: RESOLVED TEST-REQUEST
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Server (show other bugs)
Hardware: All Linux
: High enhancement (vote)
Assignee: Gentoo Web Application Packages Maintainers
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-05-13 23:27 UTC by Chris Kelly
Modified: 2004-08-18 23:38 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
gallery-1.4.3-pl1 ebuild (gallery-1.4.3-pl1.ebuild,1.66 KB, text/plain)
2004-05-13 23:29 UTC, Chris Kelly
Details
gallery-1.4.3_p2.ebuild (gallery-1.4.3_p2.ebuild,1.64 KB, text/plain)
2004-07-06 10:44 UTC, Chris Kelly
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Kelly 2004-05-13 23:27:23 UTC
This is my first shot at writing an ebuild.  Its broken and doesn't work but I think it is in the right direction. I'm looking for feedback and perhaps a way to make this work. :P

Reproducible: Always
Steps to Reproduce:
Comment 1 Chris Kelly 2004-05-13 23:29:04 UTC
Created attachment 31394 [details]
gallery-1.4.3-pl1 ebuild
Comment 2 Martin Holzer (RETIRED) gentoo-dev 2004-05-14 08:31:12 UTC
app-misc/gallery works

your ebuild already has webapp.eclass, which the old one has to be converted to
Comment 3 Chris Kelly 2004-05-14 12:55:14 UTC
app-misc/gallery only goes up to 1.4.3 and uses ${HTTPD_ROOT} which I thought needed to be replaced using ${MY_HTROOTDIR} and ${MY_HTDOCSDIR} to be fully compatabile with webapp-config.  I also couldnt see a reason for gallery to inherit webapp-apache instead of just webapp, but I don't really know what I am doing yet.
Comment 4 Martin Holzer (RETIRED) gentoo-dev 2004-06-02 12:34:57 UTC
i get a big sandbox error, access violation

did you try it with sandbox enabled ?
Comment 5 Chris Kelly 2004-06-02 13:02:01 UTC
I don't think this ebuild works at all.  I couldn't get it to run on my machine and I don't know what is wrong with it.
Comment 6 David Grant 2004-06-15 15:26:47 UTC
Should this be assinged to webapps-request@gentoo.org?

Currently gallery ebuild is useless to me as it installs to /var/www/localhost and I use a vhost somewhere else.
Comment 7 Stuart Herbert (RETIRED) gentoo-dev 2004-06-28 06:10:59 UTC
Hiya,

Here's some review comments on your ebuild to get you started.

a) There's no real need for the pkg_setup() function.  It doesn't break anything, just superfluous.
b) If your ebuild doesn't compile anything, better to add a src_compile() function which does nothing.  That way, you're not relying on any default behaviour of portage (which may or may not change in the future).
c) You're trying to call a number of functions which don't exist.

The easiest thing to do is to take an ebuild that works (such as phpmyadmin, as a good example) and read that to see how it works.

Best regards,
Stu
Comment 8 Chris Kelly 2004-07-06 10:44:10 UTC
Created attachment 34873 [details]
gallery-1.4.3_p2.ebuild
Comment 9 Chris Kelly 2004-07-06 10:48:13 UTC
Sorry for the delay, I was at Apple's WWDC and had a lot to catch up on when I got back.

So here's my second go at it. It seems a lot like phpmyadmin except unpack for phpmyadmin results in /phpmyadmin-$PV/ whereas unpacking gallery results in /gallery/ so i set S to $WORKDIR/$PN instead of $MY_P. 

When trying the ebuild I get: 

/usr/sbin/ebuild.sh: line 46: /usr/share/webapps/gallery/1.4.3_p2/htdocs/.htaccess: No such file or directory
 * ebuild fault: file '/usr/share/webapps/gallery/1.4.3_p2/htdocs/.htaccess' not found

Should I be touching and marking the config files that aren't included in the tar in pkg_postinst perhaps?
Comment 10 rob holland (RETIRED) gentoo-dev 2004-07-16 07:46:43 UTC
If the file doesn't exist, why are you wanting portage to fake it? This is so it will be cleaned up if the app is unmerged? If thats the case, I'd suggest you don't bother. As you say, its a config file, and those would normally be left behind if they've been touched anyway.

So, forget about the .htaccess file imho.
Comment 11 Chris Kelly 2004-07-16 11:47:30 UTC
Problem is, its part of the install process for Gallery. http://gallery.menalto.com/modules.php?op=modload&name=GalleryDocs&file=index&page=gallery1-install.unix-shell.php

"2.  Create two blank files, .htaccess and config.php. The easiest way is to use the configure.sh  script.

     sh configure.sh"

In Gallery 1.4.4 (due out next week or so)  we no longer use the configure.sh and secure.sh but the files still need to be created before the Configuration Wizard will do its thing.

This is so the files can be created in a directory that the webserver doesn't have write access to if i remember right. (just to those specific files).
Comment 12 Julien Allanos (RETIRED) gentoo-dev 2004-07-19 11:52:20 UTC
gallery 2.0 alpha1 is out. it would be interesting to have an ebuild for it.
Comment 13 Chris Kelly 2004-07-19 15:40:36 UTC
Gallery 2 is a completly re-written product. I'll see about writing an ebuild for it once this one is working, though if you really want it filing another bug report is probably the way to go.
Comment 14 Renat Lumpau (RETIRED) gentoo-dev 2004-08-18 23:38:27 UTC
Ebuild from bug #58375 is in CVS.