Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 508922 - app-editors/nvi - Ctl-G (file status) shows incorrect percentage on some 64-bit systems
Summary: app-editors/nvi - Ctl-G (file status) shows incorrect percentage on some 64-b...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: AMD64 Linux
: Normal normal (vote)
Assignee: Felix Janda
URL:
Whiteboard:
Keywords: InVCS, PATCH
Depends on: 609482
Blocks:
  Show dependency tree
 
Reported: 2014-04-27 22:57 UTC by Gil Kloepfer
Modified: 2017-10-15 13:40 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
patch to cast variables to proper types in message creation (msg.c.patch,439 bytes, patch)
2014-04-27 22:57 UTC, Gil Kloepfer
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Gil Kloepfer 2014-04-27 22:57:14 UTC
Created attachment 375912 [details, diff]
patch to cast variables to proper types in message creation

When using the ^G (file status) command when editing a file on some 64-bit platforms, the "percent through" the file comes out as a nonsense value.  This is due to an assumption made that a type db_recno_t is the same as a long.  Attached patch that casts these variables to the proper types so that the computation of the percentage is correct (also provided casts for the two other args as well, although they were not currently experiencing any issues).

This bug does not happen on all 64-bit platforms (apparently), nor does it happen every time (the best kind of bugs).  I see it fairly consistently on systems compiled for Intel Core i7 processors (-march=core-avx-i).
Comment 1 Gil Kloepfer 2014-04-27 22:58:21 UTC
(emerge --info below)

Portage 2.2.8-r1 (default/linux/amd64/13.0, gcc-4.7.3, glibc-2.17, 3.10.25-gentoo x86_64)
=================================================================
System uname: Linux-3.10.25-gentoo-x86_64-Intel-R-_Core-TM-_i7-3540M_CPU_@_3.00GHz-with-gentoo-2.2
KiB Mem:     8133136 total,   7420260 free
KiB Swap:    1048572 total,   1048572 free
Timestamp of tree: Sun, 20 Apr 2014 14:45:01 +0000
ld GNU ld (GNU Binutils) 2.23.2
app-shells/bash:          4.2_p45
dev-java/java-config:     2.2.0
dev-lang/python:          2.7.5-r3, 3.3.3
dev-util/cmake:           2.8.12.2
dev-util/pkgconfig:       0.28
sys-apps/baselayout:      2.2
sys-apps/openrc:          0.12.4
sys-apps/sandbox:         2.6-r1
sys-devel/autoconf:       2.13, 2.69
sys-devel/automake:       1.11.6, 1.12.6, 1.13.4
sys-devel/binutils:       2.23.2
sys-devel/gcc:            4.7.3-r1
sys-devel/gcc-config:     1.7.3
sys-devel/libtool:        2.4.2
sys-devel/make:           3.82-r4
sys-kernel/linux-headers: 3.9 (virtual/os-headers)
sys-libs/glibc:           2.17
Repositories: gentoo kloepfer
ACCEPT_KEYWORDS="amd64"
ACCEPT_LICENSE="*"
CBUILD="x86_64-pc-linux-gnu"
CFLAGS="-O2 -march=core-avx-i -pipe -fomit-frame-pointer -fno-ident"
CHOST="x86_64-pc-linux-gnu"
CONFIG_PROTECT="/etc /usr/share/easy-rsa /usr/share/gnupg/qualified.txt"
CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/env.d /etc/fonts/fonts.conf /etc/gconf /etc/gentoo-release /etc/init.d /etc/revdep-rebuild /etc/sandbox.d /etc/terminfo"
CXXFLAGS="-O2 -march=core-avx-i -pipe -fomit-frame-pointer -fno-ident"
DISTDIR="/sysbuild/distfiles"
FCFLAGS="-O2 -pipe"
FEATURES="assume-digests binpkg-logs config-protect-if-modified distlocks ebuild-locks fixlafiles merge-sync news parallel-fetch preserve-libs protect-owned sandbox sfperms strict unknown-features-warn unmerge-logs unmerge-orphans userfetch userpriv usersandbox usersync"
FFLAGS="-O2 -pipe"
GENTOO_MIRRORS="http://distfiles.gentoo.org"
LANG="C"
LC_ALL="C"
LDFLAGS="-Wl,-O1 -Wl,--as-needed"
MAKEOPTS="-j5"
PKGDIR="/sysbuild/packages"
PORTAGE_CONFIGROOT="/"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --omit-dir-times --compress --force --whole-file --delete --stats --human-readable --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages"
PORTAGE_TMPDIR="/var/tmp"
PORTDIR="/usr/portage"
PORTDIR_OVERLAY="/sysbuild/overlay"
SYNC="rsync://limbic.kloepfer.org/gentoo-portage"
USE="X acl amd64 berkdb bzip2 cli cracklib crypt cxx dri gdbm iconv ipv6 mmx modules multilib ncurses nls nptl openmp pam pcre readline session sse sse2 ssl tcpd unicode zlib" ABI_X86="64" ALSA_CARDS="ali5451 als4000 atiixp atiixp-modem bt87x ca0106 cmipci emu10k1x ens1370 ens1371 es1938 es1968 fm801 hda-intel intel8x0 intel8x0m maestro3 trident usb-audio via82xx via82xx-modem ymfpci" APACHE2_MODULES="authn_core authz_core socache_shmcb unixd actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache cgi cgid dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" CALLIGRA_FEATURES="kexi words flow plan sheets stage tables krita karbon braindump author" CAMERAS="ptp2" COLLECTD_PLUGINS="df interface irq load memory rrdtool swap syslog" ELIBC="glibc" GPSD_PROTOCOLS="ashtech aivdm earthmate evermore fv18 garmin garmintxt gpsclock itrax mtk3301 nmea ntrip navcom oceanserver oldstyle oncore rtcm104v2 rtcm104v3 sirf superstar2 timing tsip tripmate tnt ublox ubx" INPUT_DEVICES="keyboard mouse evdev" KERNEL="linux" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LIBREOFFICE_EXTENSIONS="presenter-console presenter-minimizer" LINGUAS="en_US" LIRC_DEVICES="udp" OFFICE_IMPLEMENTATION="libreoffice" PHP_TARGETS="php5-5" PYTHON_SINGLE_TARGET="python2_7" PYTHON_TARGETS="python2_7 python3_3" RUBY_TARGETS="ruby19 ruby20" SANE_BACKENDS="genesys net" USERLAND="GNU" VIDEO_CARDS="intel vesa vga fbdev" XTABLES_ADDONS="quota2 psd pknock lscan length2 ipv4options ipset ipp2p iface geoip fuzzy condition tee tarpit sysrq steal rawnat logmark ipmark dhcpmac delude chaos account"
Unset:  CPPFLAGS, CTARGET, EMERGE_DEFAULT_OPTS, INSTALL_MASK, PORTAGE_BUNZIP2_COMMAND, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS, USE_PYTHON
Comment 2 Gil Kloepfer 2014-04-27 23:08:45 UTC
version of nvi installed:  app-editors/nvi-1.81.6-r4

On this system, I see the following using:

vi /etc/portage/make.conf

(go down a few lines, and use ^G for status)

/etc/portage/make.conf: unmodified: line 9 of 24 [140733193388069%]

(after patch)

/etc/portage/make.conf: unmodified: line 9 of 24 [37%]
Comment 3 Felix Janda 2016-08-06 20:28:28 UTC
Patch looks good. Thanks!

Included in pull request https://github.com/gentoo/gentoo/pull/2031 .
Comment 4 Felix Janda 2016-08-10 18:59:35 UTC
The patch is now included in app-editors/nvi-1.81.6-r6.
This bug will be closed after its stabilization.
Comment 5 Felix Janda 2017-10-15 13:40:46 UTC
app-editors/nvi-1.81.6-r7 has a fix and is now stable.