505996 – dev-util/nsis-2.46-r1 - build/release/stub_bzip2/Ui.o:Ui.c:(.text+0x1bf7): undefined reference to `TreeView_GetItemHeight'

Bug 505996 - dev-util/nsis-2.46-r1 - build/release/stub_bzip2/Ui.o:Ui.c:(.text+0x1bf7): undefined reference to `TreeView_GetItemHeight'

Summary: dev-util/nsis-2.46-r1 - build/release/stub_bzip2/Ui.o:Ui.c:(.text+0x1bf7): un...

Status:	RESOLVED FIXED

Alias:	None

Product:	Gentoo Linux
Classification:	Unclassified
Component:	[OLD] Development (show other bugs)
Hardware:	All Linux

Importance:	Normal normal (vote)
Assignee:	No maintainer - Look at https://wiki.gentoo.org/wiki/Project:Proxy_Maintainers if you want to take care of it

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:

Reported:	2014-03-27 19:31 UTC by Luke-Jr
Modified:	2014-09-26 12:55 UTC (History)
CC List:	0 users

See Also:
Package list:
Runtime testing required:	---

Attachments
build log (build.log,112.09 KB, text/plain) 2014-03-28 04:19 UTC, Luke-Jr	Details
emerge --info (emerge--info,21.14 KB, text/plain) 2014-03-28 04:23 UTC, Luke-Jr	Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Luke-Jr 2014-03-27 19:31:12 UTC

While 2.46 (-r0) built fine, -r1 fails:

build/release/stub_bzip2/Ui.o:Ui.c:(.text+0x1bf7): undefined reference to `TreeView_GetItemHeight'
build/release/stub_bzip2/Ui.o:Ui.c:(.text+0x1c0c): undefined reference to `TreeView_SetItemHeight'
build/release/stub_bzip2/Ui.o:Ui.c:(.text+0x2677): undefined reference to `ListView_SetExtendedListViewStyleEx'
/usr/libexec/gcc/i686-pc-mingw32/ld: build/release/stub_bzip2/Ui.o: bad reloc address 0x98 in section `.rdata'
/usr/libexec/gcc/i686-pc-mingw32/ld: final link failed: Invalid operation

Comment 1 Jeroen Roovers (RETIRED) gentoo-dev

2014-03-28 04:07:45 UTC

1) Please post your `emerge --info' output in a comment.
2) Please attach the entire build log to this bug report.

Comment 2 Luke-Jr 2014-03-28 04:19:11 UTC

Created attachment 373702 [details]
build log

Comment 3 Luke-Jr 2014-03-28 04:23:08 UTC

Created attachment 373704 [details]
emerge --info

emerge --info stopped fitting in Bugzilla comments a long time ago.. :p

Comment 4 Luke-Jr 2014-05-28 12:26:07 UTC

If there's no maintainer, how did this get bumped/broken or stabilised? :|

Comment 5 Michael Palimaka (kensington) gentoo-dev

2014-05-28 12:36:06 UTC

(In reply to Luke-Jr from comment #4)
> If there's no maintainer, how did this get bumped/broken or stabilised? :|

While a package may not have a dedicated maintainer, other developers sometimes work on them from time to time. I think the only change between -r0 and -r1 is the 64 bit patch, so you could try without that.
Given that it obviously built when stabilised, but there's some change in the build environment that nsis needs updating for.

Comment 6 Luke-Jr 2014-07-23 01:33:45 UTC

nsis_w64-mingw.patch breaks the build, specifically:

 env.Append(CPPDEFINES = ['EXEHEAD'])
 env.Append(CPPDEFINES = ['WIN32_LEAN_AND_MEAN'])
-env.Append(CPPDEFINES = ['_WIN32_IE=0x0500'])
+env.SetDefault(CPPDEFINES = ['_WIN32_IE=0x0501'])

Changing this back to Append fixes it. This change doesn't make any sense: CPPDEFINES *must* be defined by the time SetDefault is called here, since it is Append'd for the other 2+ defines immediately prior. This means SetDefault is a no-op. In any case, without it defined, headers only have the bare minimum defined, which doesn't include the three macros that were then misinterpreted as functions and later found to not resolve.

I don't think this needs an ebuild revbump, since anyone with the problem couldn't have installed -r1 anyway.

Simply adding a single line after the epatch'ing is sufficient:
    sed -i 's/SetDefault/Append/' "${S}/Source/exehead/SConscript"

Comment 7 Pacho Ramos gentoo-dev

2014-09-26 12:55:08 UTC

+  26 Sep 2014; Pacho Ramos <pacho@gentoo.org> nsis-2.46-r1.ebuild:
+  Fix building (#505996 by Luke-Jr)
+