Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 504046 - xfce-extra/xfce4-power-manager: add systemd/login1 hibernate/suspend support
Summary: xfce-extra/xfce4-power-manager: add systemd/login1 hibernate/suspend support
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: XFCE Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-03-10 07:25 UTC by pelopor
Modified: 2014-05-11 17:04 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
diff -buw xfce4-power-manager-1.2.0-r2.ebuild xfce4-power-manager-1.2.0-r3.ebuild (xfce4-power-manager.ebuild.diff,805 bytes, patch)
2014-03-10 07:26 UTC, pelopor
Details | Diff
patch to the xfce4-power-manager sources (xfce4-power-manager-1.2.0-logind-support-for-suspend-hibernate.patch,4.50 KB, patch)
2014-03-10 07:27 UTC, pelopor
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description pelopor 2014-03-10 07:25:31 UTC
Add a patch to add hibernate and suspend support, from ArchLinux's PKGBUILD.
https://www.archlinux.org/packages/extra/x86_64/xfce4-power-manager/

Reproducible: Always



Expected Results:  
Hibernate/suspend can executed through xfce4-session's menu.
Comment 1 pelopor 2014-03-10 07:26:10 UTC
Created attachment 372256 [details, diff]
diff -buw xfce4-power-manager-1.2.0-r2.ebuild xfce4-power-manager-1.2.0-r3.ebuild
Comment 2 pelopor 2014-03-10 07:27:26 UTC
Created attachment 372258 [details, diff]
patch to the xfce4-power-manager sources

Taken from ArchLinux.
Comment 3 Samuli Suominen (RETIRED) gentoo-dev 2014-03-10 09:08:43 UTC
Comment on attachment 372258 [details, diff]
patch to the xfce4-power-manager sources

The patch is missing the configure.ac.in bits to control setting of the macro WITH_SLEEP_MANAGER_UPOWER and so forth
Comment 4 Samuli Suominen (RETIRED) gentoo-dev 2014-03-10 09:09:53 UTC
Comment on attachment 372256 [details, diff]
diff -buw xfce4-power-manager-1.2.0-r2.ebuild xfce4-power-manager-1.2.0-r3.ebuild

Should not patch based in 'if use systemd', but rather fix the patch to include configure.ac (or .ac.in?) bits and run with EAUTORECONF=1 set that
triggers xfconf.eclass to run eautoreconf for the package
Comment 5 Samuli Suominen (RETIRED) gentoo-dev 2014-03-10 09:13:22 UTC
And there should be a link to upstream bug where the patch has been submitted for review as prerequisite before this can enter Portage

Is this it? https://bugzilla.xfce.org/show_bug.cgi?id=10167
If not, then bug needs to be opened
Comment 6 pelopor 2014-03-11 13:21:19 UTC
(In reply to Samuli Suominen from comment #5)
> And there should be a link to upstream bug where the patch has been
> submitted for review as prerequisite before this can enter Portage
> 
> Is this it? https://bugzilla.xfce.org/show_bug.cgi?id=10167
> If not, then bug needs to be opened

Thank you for your review and comment.

The patch which I took from the Archlinux and uploaded is from https://bugzilla.xfce.org/show_bug.cgi?id=9963 .
And the xfce bugzilla has another one: https://bugzilla.xfce.org/show_bug.cgi?id=9335.
As mentioned in https://bugzilla.xfce.org/show_bug.cgi?id=10167, the development of xfce4-power-manager seems to be confused or almost unmaintained.
I think I should withdraw this bug post of mine for now, letting the ebuild and patch be a private one.
Comment 7 Samuli Suominen (RETIRED) gentoo-dev 2014-03-11 13:33:20 UTC
The author of xfce4-power-manager is an Xubuntu developer, so I'd expect Xubuntu will release systemd version once they have migrated to systemd, like they are planning to
I don't think it's a high priority bug (feature request) for them before that

For non-systemd use of xfce4-power-manager, the current code is fine

I'll look at those bugs you linked, lets keep this open
Comment 8 Samuli Suominen (RETIRED) gentoo-dev 2014-05-11 17:04:10 UTC
this is finally fixed by xfce4-power-manager-1.2.0_p20140511, upstream git snapshot, has runtime logind detection