Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 500378 - net-fs/openafs{-kernel,}-1.6.9 version bump
Summary: net-fs/openafs{-kernel,}-1.6.9 version bump
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Core system (show other bugs)
Hardware: All Linux
: Normal normal with 4 votes (vote)
Assignee: Andrej Filipcic
URL:
Whiteboard:
Keywords: EBUILD
: 496002 514876 (view as bug list)
Depends on:
Blocks:
 
Reported: 2014-02-05 14:18 UTC by Andrej Filipcic
Modified: 2015-03-22 21:37 UTC (History)
13 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
openafs-kernel-1.6.6.ebuild (openafs-kernel-1.6.6.ebuild,2.61 KB, text/plain)
2014-02-05 14:19 UTC, Andrej Filipcic
Details
openafs-1.6.6.ebuild (openafs-1.6.6.ebuild,4.66 KB, text/plain)
2014-02-05 14:19 UTC, Andrej Filipcic
Details
files/openafs-client.conf (openafs-client.conf,2.90 KB, text/plain)
2014-02-05 14:20 UTC, Andrej Filipcic
Details
files/openafs-client.service (openafs-client.service,426 bytes, text/plain)
2014-02-05 14:20 UTC, Andrej Filipcic
Details
files/openafs-server.service (openafs-server.service,283 bytes, text/plain)
2014-02-05 14:20 UTC, Andrej Filipcic
Details
files/tmpfiles.d/openafs-client.conf (openafs-client.conf,22 bytes, text/plain)
2014-02-05 14:20 UTC, Andrej Filipcic
Details
openafs-1.6.6.ebuild (openafs-1.6.6.ebuild,4.69 KB, text/plain)
2014-02-08 15:27 UTC, Andrej Filipcic
Details
files/openafs-server.service (openafs-server.service,291 bytes, text/plain)
2014-02-08 15:29 UTC, Andrej Filipcic
Details
openafs-kernel-3.16.patch (openafs-kernel-3.16.patch,7.07 KB, patch)
2014-10-14 23:38 UTC, Andrew Savchenko
Details | Diff
openafs-kernel-3.17.patch (openafs-kernel-3.17.patch,4.13 KB, patch)
2014-11-02 10:01 UTC, Andrew Savchenko
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andrej Filipcic 2014-02-05 14:18:36 UTC
openafs-kernel, openafs ebuilds for release 1.6.6.

Changes:
- added systemd unit files (openafs-client and openafs-server)
- added tmpfiles.d/openafs-client.conf to create /afs
- conf.d/openafs-client set to memcache by default, AUTOMATIC disk cache modes does not work with systemd

Files in attachments to be put in portage
- openafs-kernel-1.6.6.ebuild
- openafs-1.6.6.ebuild
- net-fs/openafs/files/openafs-client.conf
- net-fs/openafs/files/openafs-client.service
- net-fs/openafs/files/openafs-server.service
- net-fs/openafs/files/tmpfiles.d/openafs-client.conf

The patchset openafs-1.6.6-patches-1.tar.bz2 is identical to openafs-1.6.5-patches-1.tar.bz2.
Comment 1 Andrej Filipcic 2014-02-05 14:19:11 UTC
Created attachment 369600 [details]
openafs-kernel-1.6.6.ebuild
Comment 2 Andrej Filipcic 2014-02-05 14:19:30 UTC
Created attachment 369602 [details]
openafs-1.6.6.ebuild
Comment 3 Andrej Filipcic 2014-02-05 14:20:02 UTC
Created attachment 369604 [details]
files/openafs-client.conf
Comment 4 Andrej Filipcic 2014-02-05 14:20:20 UTC
Created attachment 369606 [details]
files/openafs-client.service
Comment 5 Andrej Filipcic 2014-02-05 14:20:33 UTC
Created attachment 369608 [details]
files/openafs-server.service
Comment 6 Andrej Filipcic 2014-02-05 14:20:48 UTC
Created attachment 369610 [details]
files/tmpfiles.d/openafs-client.conf
Comment 7 Andrej Filipcic 2014-02-08 15:27:22 UTC
Created attachment 369880 [details]
openafs-1.6.6.ebuild
Comment 8 Andrej Filipcic 2014-02-08 15:29:07 UTC
Created attachment 369882 [details]
files/openafs-server.service
Comment 9 Andrej Filipcic 2014-02-09 15:45:52 UTC
Actually, there is a mess right now with the patch tarball, and files. All the attached files/* should better go to the patch tarball.
Comment 10 Sergey Popov gentoo-dev 2014-02-16 12:43:48 UTC
*** Bug 496002 has been marked as a duplicate of this bug. ***
Comment 11 Renato Alves 2014-03-03 19:15:49 UTC
Is this patch ready for use?

I'm having problems compiling the latest stable openafs-kernel-1.6.5-r2 on gentoo-sources-3.10.25 after enabling user namespace support.
Comment 12 Andrej Filipcic 2014-03-03 19:21:14 UTC
(In reply to Renato Alves from comment #11)
> Is this patch ready for use?

Please, try, and report if it works. I have not tested it with the user namespace.
Comment 13 Renato Alves 2014-03-04 11:37:20 UTC
All seems to be working as expected. With one small detail where I don't really know what happened.

After compiling both client and kernel module portage finished saying /etc/conf.d/openafs-client needed updating. I ran dispatch-conf as usual, but I didn't get any prompt for any file and /etc/conf.d/openafs-client was exactly the way it was before.
It seemed like the new openafs-client.conf file was completely ignored.

On a side note, may I suggest that systemd config files are only installed if the systemd flag is set? And probably also the changes on openafs-client.conf.
Comment 14 Renato Alves 2014-04-10 10:39:16 UTC
Any progress on this?

I've been using it for over a month without issues.
Comment 15 Volkmar Glauche 2014-04-10 11:14:19 UTC
As of today, 1.6.7 is the new upstream release. There is a security announcement at

http://openafs.org/security/OPENAFS-SA-2014-001.txt

that describes a potential DoS attack against pre-1.6.7 fileservers.
Comment 16 Andrej Filipcic 2014-04-10 11:16:26 UTC
I will prepare the new ebuild later today.
Comment 17 Dirk Heinrichs 2014-04-21 09:35:36 UTC
+1 for 1.6.7 as 1.6.5 doesn't build against vanilla sources 3.14.1. BTW: Why is this still unconfirmed?
Comment 18 Renato Alves 2014-05-22 20:35:21 UTC
Is there any progress on this?

1.6.8 just came out yesterday but the portage tree still only has 1.6.5.
Comment 19 Dirk Heinrichs 2014-06-15 11:15:27 UTC
Meanwhile, 1.6.9 was released.
Comment 20 Sergey Popov gentoo-dev 2014-06-24 12:43:51 UTC
*** Bug 514876 has been marked as a duplicate of this bug. ***
Comment 21 Renato Alves 2014-06-25 11:03:44 UTC
Just to add that the provided ebuilds for 1.6.6 also work as-is for 1.6.9.

Any chance we can get this tested and in the tree?
Comment 22 Steffen 2014-08-22 08:23:44 UTC
The provided ebuilded stopped working with linux-3.16.1-gentoo kernel (3.15.5 worked):

/var/tmp/portage/net-fs/openafs-kernel-1.6.9/work/openafs-1.6.9/src/libafs/MODLOAD-3.16.1-gentoo-MP/osi_vnodeops.c:815:19: error: ‘generic_file_splice_write’ undeclared here (not in a function)
   .splice_write = generic_file_splice_write,
Comment 23 Christoph Koke 2014-08-26 12:32:21 UTC
I could build the ebuilds for version 1.6.9 with the (currently stable) 3.14.14 kernel. But the systemd service file for the client to not work at all.
Comment 24 Jani Kotakoski 2014-09-26 16:33:09 UTC
I just installed openafs from these ebuilds since 1.6.5 doesn't compile with the current stable kernel. Please already confirm this.
Comment 25 Andrey Golovizin 2014-09-27 11:53:30 UTC
The updated ebuilds work fine for me with version 1.6.9. Would be nice to finally see them in the tree.
Comment 26 Andrew Savchenko gentoo-dev 2014-10-14 22:22:15 UTC
Hello, all!

With what kernel versions you were able to build openafs-1.6.9?

In my case openafs-kernel-1.6.9 fails to build with vanilla-sources-3.16.5:

/var/tmp/portage/net-fs/openafs-kernel-1.6.9/work/openafs-1.6.9/src/libafs/MODLOAD-3.16.5-yoruichi-SP/osi_vnodeops.c:815:19: error: ‘generic_file_splice_write’ undeclared here (not in a function)
   .splice_write = generic_file_splice_write,
                   ^
scripts/Makefile.build:257: recipe for target '/var/tmp/portage/net-fs/openafs-kernel-1.6.9/work/openafs-1.6.9/src/libafs/MODLOAD-3.16.5-yoruichi-SP/osi_vnodeops.o' failed
Comment 27 Andrew Savchenko gentoo-dev 2014-10-14 22:39:12 UTC
Looks like there are upstream patches for 3.16 kernel:

http://gerrit.openafs.org/#change,11308
http://gerrit.openafs.org/#change,11309

Debian already use them. I'll try them out and report later.
Comment 28 Andrew Savchenko gentoo-dev 2014-10-14 23:38:53 UTC
Created attachment 386698 [details, diff]
openafs-kernel-3.16.patch

I confirm patches above allows openafs to build at work fine (at least for openafs-client). For your convenience here is a united patch.
Comment 29 Adrian 2014-10-16 22:20:05 UTC
Please put it in the tree! Having to downgrade the kernel or download all the files from bugzilla is annoying as fuck...
Comment 30 Yixun Lan archtester gentoo-dev 2014-10-17 01:32:49 UTC
(In reply to Andrej Filipcic from comment #16)
> I will prepare the new ebuild later today.

any progress? we can help if you need to push it into tree, just let us know

(In reply to Adrian from comment #29)
> Please put it in the tree! Having to downgrade the kernel or download all
> the files from bugzilla is annoying as fuck...

be patient, we are all volunteer here.
a friendly ping would be enough, and follow the "code of coduct"[1]


[1] http://wiki.gentoo.org/wiki/Project:Council/Code_of_conduct
Comment 31 Jani Kotakoski 2014-10-27 23:49:04 UTC
I confirm that the openafs-kernel-3.16.patch works with gentoo-sources-3.16.5.
Comment 32 Andrew Savchenko gentoo-dev 2014-11-02 09:10:28 UTC
1.6.9 doesn't compile with 3.17 kernel:

/var/tmp/portage/net-fs/openafs-kernel-1.6.9/work/openafs-1.6.9/src/libafs/MODLOAD-3.17.2-subaru-MP/osi_sysctl.c:37:1: error: unknown type name ‘ctl_table’
 static ctl_table afs_sysctl_table[] = {
 ^
/var/tmp/portage/net-fs/openafs-kernel-1.6.9/work/openafs-1.6.9/src/libafs/MODLOAD-3.17.2-subaru-MP/osi_sysctl.c:38:5: warning: braces around scalar initializer [enabled by default]
     {
     ^
/var/tmp/portage/net-fs/openafs-kernel-1.6.9/work/openafs-1.6.9/src/libafs/MODLOAD-3.17.2-subaru-MP/osi_sysctl.c:38:5: warning: (near initialization for ‘afs_sysctl_table[0]’) [enabled by default]
/var/tmp/portage/net-fs/openafs-kernel-1.6.9/work/openafs-1.6.9/src/libafs/MODLOAD-3.17.2-subaru-MP/osi_sysctl.c:46:2: error: field name not in record or union initializer
  .procname  = "hm_retry_RO",
  ^
/var/tmp/portage/net-fs/openafs-kernel-1.6.9/work/openafs-1.6.9/src/libafs/MODLOAD-3.17.2-subaru-MP/osi_sysctl.c:46:2: error: (near initialization for ‘afs_sysctl_table[0]’)

Will try 1.6.10 soon.
Comment 33 Andrew Savchenko gentoo-dev 2014-11-02 10:01:01 UTC
Created attachment 388322 [details, diff]
openafs-kernel-3.17.patch

1.6.10 doesn't compile with 3.17 too, but upstream have two patches:
http://gerrit.openafs.org/#change,11549
http://gerrit.openafs.org/#change,11550

They are joined into openafs-kernel-3.17.patch.
Ebuild for 1.6.9 works fine: just rename it and patch name inside.

Another note: some parts of the code ignore CFLAGS and LDFLAGS, though this is a minor issue.
Comment 34 Adam Feldman gentoo-dev 2014-11-04 06:43:44 UTC
My experiences were as follows, openafs 1.6.9 with the patches for kernel 3.16 segfaulted frequently for the client.   I did find that copying the ebuild for openafs 1.6.9 and saving as openafs 1.6.10, using the patch tarball from 1.6.9 worked perfectly.
Comment 35 Nick Wiltshire 2014-11-26 18:52:17 UTC
Reported: 	2014-02-05 14:18 UTC 

How on earth are these ebuilds not in Portage? That's the better part of a year now.
Comment 36 Andrew Savchenko gentoo-dev 2015-03-22 21:37:13 UTC
1.6.11 is in tree.