Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 499644 - x11-themes/fvwm-crystal-3.4.1 version bump
Summary: x11-themes/fvwm-crystal-3.4.1 version bump
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Library (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Dominique Michel
URL:
Whiteboard:
Keywords: EBUILD, PATCH
Depends on:
Blocks:
 
Reported: 2014-01-29 01:26 UTC by Dominique Michel
Modified: 2016-01-11 10:43 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
patch for 3.3.0 with xdg-user-dirs depend (fvwm-crystal-3.3.0.patch,575 bytes, patch)
2014-01-29 01:47 UTC, Dominique Michel
Details | Diff
patch for 3.2.5-r1 with xdg-user-dirs depend (fvwm-crystal-3.2.5-r1.patch,578 bytes, patch)
2014-01-29 01:54 UTC, Dominique Michel
Details | Diff
and 3.2.3 too. (fvwm-crystal-3.2.3-r1.patch,573 bytes, patch)
2014-01-29 01:54 UTC, Dominique Michel
Details | Diff
patch for 3.3.0 with optional xdg-user-dirs depend (fvwm-crystal-3.3.0.patch,732 bytes, patch)
2014-01-29 16:15 UTC, Dominique Michel
Details | Diff
patch for 3.2.5-r1 with optional xdg-user-dirs depend (fvwm-crystal-3.2.5-r1.patch,735 bytes, patch)
2014-01-29 16:16 UTC, Dominique Michel
Details | Diff
patch for 3.2.3-r1 with optional xdg-user-dirs depend (fvwm-crystal-3.2.3-r1.patch,728 bytes, patch)
2014-01-29 16:18 UTC, Dominique Michel
Details | Diff
patch for metadata.xml (matadata.xml.patch,365 bytes, patch)
2014-01-29 16:19 UTC, Dominique Michel
Details | Diff
patch for 3.3.1 with xdg-user-dirs depend (fvwm-crystal-3.3.1.patch,575 bytes, patch)
2014-02-06 11:30 UTC, Dominique Michel
Details | Diff
ebuild for fvwm-crystal-3.4.0 (fvwm-crystal-3.4.0.ebuild,2.17 KB, text/plain)
2016-01-03 16:36 UTC, Dominique Michel
Details
new metadata file (metadata.xml,1.20 KB, text/plain)
2016-01-03 16:38 UTC, Dominique Michel
Details
3.4.0 ebuild: EAPI=6, removed subversion depend for the non live version (fvwm-crystal-3.4.0.ebuild,2.08 KB, text/plain)
2016-01-05 15:39 UTC, Dominique Michel
Details
fvwm-crystal-3.4.0: add missing REQUIRED_USE (fvwm-crystal-3.4.0.ebuild,2.12 KB, text/plain)
2016-01-06 14:03 UTC, Dominique Michel
Details
ebuild for fvwm-crystal-3.4.1 (fvwm-crystal-3.4.1.ebuild,2.15 KB, text/plain)
2016-01-06 16:20 UTC, Dominique Michel
Details
metadata file with my current email (metadata.xml,1.20 KB, application/xml)
2016-01-07 14:04 UTC, Dominique Michel
Details
ebuild for fvwm-crystal-3.4.1 without conditional RDEPEND (fvwm-crystal-3.4.1.ebuild,2.41 KB, text/plain)
2016-01-11 09:52 UTC, Dominique Michel
Details
current metadata file (metadata.xml,946 bytes, text/plain)
2016-01-11 09:54 UTC, Dominique Michel
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Dominique Michel 2014-01-29 01:26:23 UTC
FVWM-Crystal was updated to 3.3.0. It contain some new features and bugfixes.

It is a missing dependendy to x11-misc/xdg-user-dirs. I will commit a patch later for that.

Reproducible: Always
Comment 1 Dominique Michel 2014-01-29 01:29:53 UTC
You should assign the bug to me and
Comment 2 Dominique Michel 2014-01-29 01:37:16 UTC
Funny, I see that repoman didn't warm me when we are in 2014, and the copyright line have 1999-2013.
Comment 3 Dominique Michel 2014-01-29 01:47:01 UTC
Created attachment 369022 [details, diff]
patch for 3.3.0 with xdg-user-dirs depend
Comment 4 Alex Xu (Hello71) 2014-01-29 01:52:27 UTC
That's out of repoman's purview.
Comment 5 Dominique Michel 2014-01-29 01:54:07 UTC
Created attachment 369024 [details, diff]
patch for 3.2.5-r1 with xdg-user-dirs depend

3.2.5 is also missing the xdg-user-dirs depend
Comment 6 Dominique Michel 2014-01-29 01:54:49 UTC
Created attachment 369026 [details, diff]
and 3.2.3 too.
Comment 7 Dominique Michel 2014-01-29 02:43:23 UTC
That fix for the xdg-user-dirs depend is important, because if it is missing, the FVWM-Crystal desktop icon manager will fail with the xdg user directories.
Comment 8 Dominique Michel 2014-01-29 15:17:06 UTC
According to feedback I get, the FVWM-Crystal dekstop icon manager work fine without xdg-user-dirs and the xdg user directories, and some users doesn't care about them. I will modify these patches to make xdg-user-dirs a conditional depend with an USE flag.
Comment 9 Dominique Michel 2014-01-29 16:15:25 UTC
Created attachment 369076 [details, diff]
patch for 3.3.0 with optional xdg-user-dirs depend
Comment 10 Dominique Michel 2014-01-29 16:16:55 UTC
Created attachment 369078 [details, diff]
patch for 3.2.5-r1 with optional xdg-user-dirs depend
Comment 11 Dominique Michel 2014-01-29 16:18:11 UTC
Created attachment 369082 [details, diff]
patch for 3.2.3-r1 with optional xdg-user-dirs depend
Comment 12 Dominique Michel 2014-01-29 16:19:05 UTC
Created attachment 369084 [details, diff]
patch for metadata.xml
Comment 13 Dominique Michel 2014-01-29 23:59:08 UTC
Well, portage policy is different from what I was thinking at first.

The installed code is not modified, so it must be no use flag. In consequence, I think it is just to keep that depend without use flag, like in the first patches I made. An alternative would be to not add that depend and add a post installation message instead. I prefer to have it like a depend, because it will make the life easier for new users that have other desktops using these xdg directories.
Comment 14 Dominique Michel 2014-02-06 11:30:27 UTC
Created attachment 369700 [details, diff]
patch for 3.3.1 with xdg-user-dirs depend

3,3,1 contain a new and complete Dutch locale, typo fixes for the English locale, some minor fixes and 1 new minor feature.
Comment 15 Dominique Michel 2014-03-09 17:56:29 UTC
I am in the way to change the ebuilds a little bit and will update them later.

First, I want to move the einfo to the new readme.gentoo eclass.

Last, during emake install, the Makefile is changing a few internal paths before installing. That is equivalent to a configure --prefix ..., and according to http://www.gentoo.org/proj/en/gentoo-alt/prefix/techdocs.xml
in Gentoo Prefix configure is run with --prefix=${EPREFIX}/usr, 

If I understand right, as it is no configure script in fvwm-crystal, it would be best to use

	emake \
		DESTDIR="${ED}" \
		docdir="${EPREFIX}/usr/share/doc/${PF}" \
		prefix="${EPREFIX}/usr" \
		install

into the ebuild. It will not harm when EPREFIX is not defined in a given system, and it will work when it is defined.
Comment 16 Dominique Michel 2016-01-03 16:36:56 UTC
Created attachment 421794 [details]
ebuild for fvwm-crystal-3.4.0
Comment 17 Dominique Michel 2016-01-03 16:38:01 UTC
Created attachment 421796 [details]
new metadata file
Comment 18 Dominique Michel 2016-01-05 15:39:18 UTC
Created attachment 422016 [details]
3.4.0 ebuild: EAPI=6, removed subversion depend for the non live version

The mv overlay have done these updates.
Comment 19 Dominique Michel 2016-01-06 14:03:59 UTC
Created attachment 422136 [details]
fvwm-crystal-3.4.0: add missing REQUIRED_USE
Comment 20 Dominique Michel 2016-01-06 16:20:24 UTC
Created attachment 422142 [details]
ebuild for fvwm-crystal-3.4.1

This release fix a missing clock with the Dock recipe, and make the automatic hibernation to also work like a preference setting.

The ebuild also address an issue I get with the src_prepare phase when it is called as a live ebuild (-9999).
Comment 21 Dominique Michel 2016-01-07 14:04:54 UTC
Created attachment 422186 [details]
metadata file with my current email
Comment 22 Ian Delaney (RETIRED) gentoo-dev 2016-01-08 00:52:06 UTC
awaiting edits to deal with the use flags in RDEPEND
Comment 23 Dominique Michel 2016-01-11 09:52:21 UTC
Created attachment 422542 [details]
ebuild for fvwm-crystal-3.4.1 without conditional RDEPEND
Comment 24 Dominique Michel 2016-01-11 09:54:00 UTC
Created attachment 422544 [details]
current metadata file

I removed the use flags section, as it is no more IUSE
Comment 25 Ian Delaney (RETIRED) gentoo-dev 2016-01-11 10:43:35 UTC
commit 346605d413f680dc3f16e781590e19fa2c289327
Author: Ian Delaney <idella4@gentoo.org>
Date:   Mon Jan 11 18:42:35 2016 +0800

    x11-themes/fvwm-crystal: bump to vn. 3.4.1
    
    ebuild submitted by maintainer via the gentoo bug, closes bug
    
    Gentoo bug: #499644