Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 496986 - dev-java/jdom-2.0.6 initial version bump ebuild
Summary: dev-java/jdom-2.0.6 initial version bump ebuild
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Java (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Java team
URL:
Whiteboard:
Keywords:
: 517826 (view as bug list)
Depends on: 544076
Blocks:
  Show dependency tree
 
Reported: 2014-01-04 18:49 UTC by William L. Thomson Jr.
Modified: 2015-04-04 20:23 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
jdom-2.0.5.ebuild (jdom-2.0.5.ebuild,1.91 KB, text/plain)
2014-01-04 18:49 UTC, William L. Thomson Jr.
Details
jdom-2.0.6.ebuild (jdom-2.0.6.ebuild,1.69 KB, text/plain)
2015-03-20 19:41 UTC, William L. Thomson Jr.
Details
jdom-2.0.6.ebuild (jdom-2.0.6.ebuild,1.68 KB, text/plain)
2015-03-22 01:19 UTC, William L. Thomson Jr.
Details

Note You need to log in before you can comment on or make changes to this bug.
Description William L. Thomson Jr. 2014-01-04 18:49:48 UTC
Created attachment 366982 [details]
jdom-2.0.5.ebuild

Here is an initial version bump ebuild for jdom 2.0.5. Its a but crude could be cleaned up and still a few things to be done. Also I believe jdom-jaxen also needs to be updated based on the same sources, but its its own ebuild/package. Not sure if this one still depends on that or not. Again its very initial and crude, but does compile and install. Just needs to be dialed in, cleaned up, etc. Like I had to do 3 lines of sed, because I could not get sed or grep to match/ingore patterns at same time. Remove all test classes when test use flag is not set, but need to keep PerfTest.java class for Performance test. Though that class and the other classes in the perf folder are not necessary to jdom function, but performance tests. I guess that could be built under test but its added complexity.
Comment 1 William L. Thomson Jr. 2015-03-20 15:55:39 UTC
*** Bug 517826 has been marked as a duplicate of this bug. ***
Comment 2 William L. Thomson Jr. 2015-03-20 19:41:31 UTC
Created attachment 399324 [details]
jdom-2.0.6.ebuild
Comment 3 William L. Thomson Jr. 2015-03-20 19:42:27 UTC
Updated ebuild for 2.0.6. This is slotted to 2, for jdom v2. It does not need minor/revision slots. That is left over stuff from before. Nothing uses this at the moment. It should be safe to add as is. This ebuild should be good to go for the most part. But review for any errors, etc before commit to tree.
Comment 4 Patrice Clement gentoo-dev 2015-03-21 16:37:23 UTC
Hi William

If I comment out parts that call on javadoc documentation, the ebuild works fine. Lines that cause problems:

- in src_compile():
55:     use doc && \
56:             javadoc -d "${S}"/docs -cp ${cp} "@${T}"/src.list \
57:                     -Xdoclint:none -quiet || die "javadoc failed"

- in src_install():
67:     use doc && java-pkg_dojavadoc docs

Otherwise, the rest looks good and works as expected. Thanks.
Comment 5 William L. Thomson Jr. 2015-03-21 17:34:48 UTC
Looks to be that -cp for javadoc is non-standard, or not implemented in all jdks. That needs to be changed to -classpath for javadoc only. 

However it also looks like icedtea does not support -Xdoclint:none, which seems to be required for jdk >=1.8. I think due to increased strictness on javadocs.

I will have to revise the ebuild to do some things differently for jdk 1.8. I will submit a revised ebuild.
Comment 6 William L. Thomson Jr. 2015-03-21 18:31:26 UTC
Rather than fixing this ebuild. I think something needs to be done in an eclass to detect if the jdk is >= 1.8, and if so set the -Xdoclint:none parameter for javadoc. Otherwise I bet many packages will have issues with that. At the same time if the jdk is <1.8, it will not recognize that option as its new. That would be the best approach, rather than doing this within each ebuild.
Comment 7 William L. Thomson Jr. 2015-03-22 01:19:14 UTC
Created attachment 399436 [details]
jdom-2.0.6.ebuild
Comment 8 William L. Thomson Jr. 2015-03-22 01:20:12 UTC
Updated ebuild that uses ejavadoc which has a check for the version and sets appropriate flag if the compiler is >=1.8. Requires ejavadoc to be added to java-utils-2.eclass.
Comment 9 Patrice Clement gentoo-dev 2015-04-04 19:29:38 UTC
+*jdom-2.0.6 (04 Apr 2015)
+
+  04 Apr 2015; Patrice Clement <monsieurp@gentoo.org> +jdom-2.0.6.ebuild:
+  Version bump courtesy of William L. Thomson Jr. <wlt@obsidian-studios.com>.
+  Fix bug 496986.
+

I have commented out the doc USE flag as well as ejavadoc. We need to get this new function in if we want to use it in ebuilds.
Comment 10 James Le Cuirot gentoo-dev 2015-04-04 20:23:03 UTC
I was going to get ejavadoc committed today anyway but was busy with family. Will do it now.