Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 496654 - games-emulation/sdlmame-0.159 version bump
Summary: games-emulation/sdlmame-0.159 version bump
Status: RESOLVED DUPLICATE of bug 556642
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Games (show other bugs)
Hardware: All Linux
: Normal enhancement with 1 vote (vote)
Assignee: Gentoo Games
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-01-01 08:21 UTC by Ryan Koudys
Modified: 2015-11-20 06:46 UTC (History)
4 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
0.152 ebuild proposal (sdlmame-0.152.ebuild,4.20 KB, text/plain)
2014-01-26 07:28 UTC, Ryo
Details
QA patch rewritten (sdlmame-0.152-QA.patch,4.80 KB, patch)
2014-01-26 07:30 UTC, Ryo
Details | Diff
ebuild for 0.159 (sdlmame-0.159.ebuild,4.04 KB, text/plain)
2015-03-12 19:13 UTC, Paul B. Henson
Details
Fix sdl_ttf include path (sdlmame-0.159-sdl_ttf.patch,1009 bytes, patch)
2015-03-12 19:14 UTC, Paul B. Henson
Details | Diff
Updated QA patch for 0.159 (sdlmame-0.159-QA.patch,3.24 KB, patch)
2015-03-12 19:14 UTC, Paul B. Henson
Details | Diff
Updated debugger-linking patch for 0.159 (sdlmame-0.159-debugger-linking.patch,592 bytes, patch)
2015-03-12 19:15 UTC, Paul B. Henson
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ryan Koudys 2014-01-01 08:21:22 UTC
SDLMAME 0.152 has been released

Reproducible: Always
Comment 1 Ryo 2014-01-26 07:28:26 UTC
Created attachment 368752 [details]
0.152 ebuild proposal

double check it , i'm not accurate with ebuild writing.
Compiled fine on my machine.

No diff yet available on mamedev.org.

I'm attaching the QA patch because i had to rewrite it.
Comment 2 Ryo 2014-01-26 07:30:13 UTC
Created attachment 368754 [details, diff]
QA patch rewritten

all others patchs are the same and applied fine, i've just renamed all.
Comment 3 Mr. Bones. (RETIRED) gentoo-dev 2014-01-26 07:45:04 UTC
leave the patch support in so the ebuild doesn't have to change to support them.
Comment 4 James L. Hammons 2014-09-25 00:20:26 UTC
I had to make some changes to the ebuild to get it compile here (~amd64), detailed below. I also had to unmask >=dev-lang/lua-5.2.3-r1, app-admin/eselect-lua, and games-emulation/sdlmame. The changes to the ebuild were:

 - Change the flag in the RDEPEND for libsdl from 'audio' to 'sound'
 - Had to add 'edos2unix src/emu/cpu/m68000/m68k_in.c' to src_prepare() (real fix, which obviously never got into upstream, is described in bug #489118)

I also had to use the QA patch attached here, and had to bump the revisions of the 'no-opengl', 'system-lua', and 'debugger-linking' patches to 0.152. Also, on the third time through compiling this beast, I also discovered that I had to bump 'mame-0.139.ini.in' to 0.152. Shouldn't the ebuild detect that all its files are in the tree before getting all the way to the end and failing miserably when it can't find it? :-P

Also, once you unmask and reinstall lua 5.2, you have to do an 'eselect lua set 1', otherwise sdlmame will complain throughout the compile about a missing PKGSPEC something or other; it will fail to link at the very end.

Ultimately, though, if you perservere and do all these things, it will build and the resulting binary will work. :-)
Comment 5 Julian Ospald 2014-09-25 01:07:40 UTC
(In reply to James L. Hammons from comment #4)
> I had to make some changes to the ebuild to get it compile here (~amd64),
> detailed below. I also had to unmask >=dev-lang/lua-5.2.3-r1,
> app-admin/eselect-lua, and games-emulation/sdlmame. The changes to the
> ebuild were:
> 
>  - Change the flag in the RDEPEND for libsdl from 'audio' to 'sound'
>  - Had to add 'edos2unix src/emu/cpu/m68000/m68k_in.c' to src_prepare()
> (real fix, which obviously never got into upstream, is described in bug
> #489118)
> 
> I also had to use the QA patch attached here, and had to bump the revisions
> of the 'no-opengl', 'system-lua', and 'debugger-linking' patches to 0.152.
> Also, on the third time through compiling this beast, I also discovered that
> I had to bump 'mame-0.139.ini.in' to 0.152. Shouldn't the ebuild detect that
> all its files are in the tree before getting all the way to the end and
> failing miserably when it can't find it? :-P
> 
> Also, once you unmask and reinstall lua 5.2, you have to do an 'eselect lua
> set 1', otherwise sdlmame will complain throughout the compile about a
> missing PKGSPEC something or other; it will fail to link at the very end.
> 
> Ultimately, though, if you perservere and do all these things, it will build
> and the resulting binary will work. :-)

eselect lua is crap. I personally will never support such broken approaches. I'd rather add a new package lua-vanilla to the tree, because I am quite sick of the hackery the current lua ebuild maintainers are doing.

So I'd vote for dropping the system-lua patch here completely. Looks way saner than relying on that broken stuff some people are shipping in gentoo without QA stepping in.
Comment 6 Mr. Bones. (RETIRED) gentoo-dev 2014-09-25 01:43:11 UTC
yep.  the lua situation is holding up stablizing too so I agree with using the embedded version for now and going back to the system version in the future if possible.
Comment 7 James L. Hammons 2014-09-25 21:52:31 UTC
OK, so I went and removed the lua patch and removed the 'without lua' configuration option, and it built and runs just fine.

I have no dog in the lua fight; I just want to see this hit the tree sooner than later. :-)
Comment 8 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2015-03-12 15:55:02 UTC
(In reply to James L. Hammons from comment #7)
> OK, so I went and removed the lua patch and removed the 'without lua'
> configuration option, and it built and runs just fine.

Are you sure you attached the correct ebuild? I still see the system lua patch and disabling code there...
Comment 9 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2015-03-12 15:56:07 UTC
Oh, sorry, you didn't attach any new ebuild at all.
Comment 10 Paul B. Henson 2015-03-12 19:13:12 UTC
I updated the prototype ebuild for 0.159, with a couple changes:

* Updated QA patch and debugger-linking patch to apply cleanly
* 0.159 wants libsdl2, not libsdl
* The no-opengl patch is in upstream now
* It looks for sdl_ttf in include/SDL2, not SDL, so added sdl_ttf.patch

It compiles cleanly and seems to work ok. The ebuild definitely isn't tree ready, but hopefully a dev can tune it up and get it in at some point, and users can try it out in an overlay.
Comment 11 Paul B. Henson 2015-03-12 19:13:47 UTC
Created attachment 398756 [details]
ebuild for 0.159
Comment 12 Paul B. Henson 2015-03-12 19:14:41 UTC
Created attachment 398758 [details, diff]
Fix sdl_ttf include path
Comment 13 Paul B. Henson 2015-03-12 19:14:59 UTC
Created attachment 398760 [details, diff]
Updated QA patch for 0.159
Comment 14 Paul B. Henson 2015-03-12 19:15:32 UTC
Created attachment 398762 [details, diff]
Updated debugger-linking patch for 0.159
Comment 15 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2015-03-12 19:43:15 UTC
(In reply to Paul B. Henson from comment #12)
> Created attachment 398758 [details, diff] [details, diff]
> Fix sdl_ttf include path

This is wrong. You should use sdl2-ttf since you switched to libsdl2.
Comment 16 Paul B. Henson 2015-03-23 02:30:43 UTC
(In reply to Michał Górny from comment #15)
> 
> This is wrong. You should use sdl2-ttf since you switched to libsdl2.

Ooops. Remember I said "hopefully a dev can tune it up" ;)? Thanks, I didn't notice there was a separate ttf package for sdl2 and it seemed to work fine with the kludge I made. I'll try to compile it again with the right dep and ditch the header location patch.

Another thing I noticed is that it doesn't seem to be using the /etc/games location to look for ini files. The current ebuild sets INI_PATH in OPT_FLAGS, which seems to be referenced in src/osd/sdl/sdl.mak:

CCOMFLAGS += $(OPT_FLAGS)

However, it doesn't show up during the actual compile:

ebuild /usr/local/portage/games-emulation/sdlmame/sdlmame-0.159.ebuild compile > /tmp/mame.out 2>&1

grep INI /tmp/mame.out

I ended up putting it in CFLAGS instead, and it works. Not sure what's going on there.
Comment 17 Julian Ospald 2015-03-23 10:25:24 UTC
the updated QA patch is incomplete, e.g. the upstream Makefile still hardcodes 'pkg-config' instead of using '$(PKG_CONFIG)'
Comment 18 Mr. Bones. (RETIRED) gentoo-dev 2015-11-20 06:46:44 UTC

*** This bug has been marked as a duplicate of bug 556642 ***