@@ -17,10 +16,10 @@ DESCRIPTION="KDE window manager" HOMEPAGE+=" http://userbase.kde.org/KWin" KEYWORDS=" ~amd64 ~arm ~ppc ~ppc64 ~x86 ~amd64-linux ~x86-linux" -IUSE="debug gles opengl wayland" +IUSE="+activities debug gles opengl +opengl1 +oxygen +xrender +scripting wayland" COMMONDEPEND=" - $(add_kdebase_dep kactivities) + activities? ( $(add_kdebase_dep kactivities) ) $(add_kdebase_dep kdelibs opengl) $(add_kdebase_dep kephal) $(add_kdebase_dep libkworkspace) @@ -37,7 +36,7 @@ x11-libs/libXext x11-libs/libXfixes >=x11-libs/libXrandr-1.2.1 - x11-libs/libXrender + xrender? ( x11-libs/libXrender ) x11-libs/libXxf86vm opengl? ( >=media-libs/mesa-7.10 ) gles? ( >=media-libs/mesa-7.12[egl(+),gles2] ) @@ -62,16 +61,24 @@ " # you need one of these -REQUIRED_USE="!opengl? ( gles ) !gles? ( opengl ) wayland? ( gles )" +REQUIRED_USE="!opengl? ( gles ) + !gles? ( opengl ) + wayland? ( gles ) + opengl1? ( opengl !gles )" src_configure() { # FIXME Remove when activity API moved away from libkworkspace append-cppflags "-I${EPREFIX}/usr/include/kworkspace" mycmakeargs=( + $(cmake-utils_use activities KWIN_BUILD_ACTIVITIES) $(cmake-utils_use_with gles OpenGLES) $(cmake-utils_use gles KWIN_BUILD_WITH_OPENGLES) + $(cmake-utils_use oxygen KWIN_BUILD_OXYGEN) $(cmake-utils_use_with opengl OpenGL) + $(cmake-utils_use opengl1 KWIN_BUILD_OPENGL_1_COMPOSITING) + $(cmake-utils_use scripting KWIN_BUILD_SCRIPTING) + $(cmake-utils_use xrender KWIN_BUILD_XRENDER_COMPOSITING) $(cmake-utils_use_with wayland Wayland) -DWITH_X11_Xcomposite=ON ) Reproducible: Always Disabling unused things can save about 400K from runtime /usr/lib/libkdeinit4_kwin.so
Thanks for reporting. But this patch has several QA issues: * opengl1 useflag makes no sense when there is already a opengl use flag * alphabetic sorting is not honored * optional deps have to be sorted after non-optional * whitespace And in the end i am not sure how usefull this is...
* opengl1 is for OpenGL 1 which is not often used and is considered as deprecated. * I'll fix whitespaces and sort it by alphabethical order
(In reply to David Heidelberger (okias) from comment #2) > * opengl1 is for OpenGL 1 which is not often used and is considered as > deprecated. > * I'll fix whitespaces and sort it by alphabethical order Opengl is not deprecated.
"OpenGL comes in two different flavors: fixed functionality and programmable pipeline. There are several versions of OpenGL. OpenGL 1.x only supports fixed functionality, OpenGL ES 2.0 and OpenGL 3/4 (forward compatible profile) only supports programmable pipeline. OpenGL 2.x supports both way of programming." Quote from http://community.kde.org/KWin/Hacking . opengl1 USE just remove OpenGL _1_ code from kwin. These days is no real reason to use opengl1 except some old radeon 9200 cards and older.
I hope all issues are fixed, can you review it? :) --- @@ -17,10 +16,9 @@ DESCRIPTION="KDE window manager" HOMEPAGE+=" http://userbase.kde.org/KWin" KEYWORDS=" ~amd64 ~arm ~ppc ~ppc64 ~x86 ~amd64-linux ~x86-linux" -IUSE="debug gles opengl wayland" +IUSE="+activities debug gles opengl +opengl1 +oldthemes +oxygen +xrender +scripting wayland" COMMONDEPEND=" - $(add_kdebase_dep kactivities) $(add_kdebase_dep kdelibs opengl) $(add_kdebase_dep kephal) $(add_kdebase_dep libkworkspace) @@ -37,11 +35,12 @@ x11-libs/libXext x11-libs/libXfixes >=x11-libs/libXrandr-1.2.1 - x11-libs/libXrender x11-libs/libXxf86vm - opengl? ( >=media-libs/mesa-7.10 ) + activities? ( $(add_kdebase_dep kactivities) ) gles? ( >=media-libs/mesa-7.12[egl(+),gles2] ) + opengl? ( >=media-libs/mesa-7.10 ) wayland? ( >=media-libs/mesa-9.0[egl(+),wayland] ) + xrender? ( x11-libs/libXrender ) " DEPEND="${COMMONDEPEND} x11-libs/xcb-util-renderutil @@ -62,17 +61,25 @@ " # you need one of these -REQUIRED_USE="!opengl? ( gles ) !gles? ( opengl ) wayland? ( gles )" +REQUIRED_USE="!opengl? ( gles ) + !gles? ( opengl ) + opengl1? ( opengl !gles ) + wayland? ( gles )" src_configure() { # FIXME Remove when activity API moved away from libkworkspace append-cppflags "-I${EPREFIX}/usr/include/kworkspace" mycmakeargs=( + $(cmake-utils_use activities KWIN_BUILD_ACTIVITIES) $(cmake-utils_use_with gles OpenGLES) $(cmake-utils_use gles KWIN_BUILD_WITH_OPENGLES) $(cmake-utils_use_with opengl OpenGL) + $(cmake-utils_use opengl1 KWIN_BUILD_OPENGL_1_COMPOSITING) + $(cmake-utils_use oxygen KWIN_BUILD_OXYGEN) + $(cmake-utils_use scripting KWIN_BUILD_SCRIPTING) $(cmake-utils_use_with wayland Wayland) + $(cmake-utils_use xrender KWIN_BUILD_XRENDER_COMPOSITING) -DWITH_X11_Xcomposite=ON )
I dont see the purpose compared to the new complexity, maybe other herd members have a other opinion. My vote: no.
I'm ambivalent; it's added complexity, but at least they're supported build options.
Gentoo is mostly about choice, so as person who proposed this, I'm for inclusion. Everything work well with kde-base/kwin-4.11.4-r1::ixit overlay, which include these options.
@kde herd Guys, do you care?
Nobody from herd seems interested in increasing the complexity here. In kwin:5 there are not such options, maybe for a good reason.