Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 493712 - app-mobilephone/kannel-sqlbox finally edited to bump request
Summary: app-mobilephone/kannel-sqlbox finally edited to bump request
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Travis Hansen
URL:
Whiteboard:
Keywords: NeedPatch
Depends on:
Blocks:
 
Reported: 2013-12-09 05:57 UTC by Travis Hansen
Modified: 2016-02-11 16:05 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
kannel-sqlbox-1.5.0.ebuild (kannel-sqlbox-1.5.0.ebuild,1.94 KB, text/plain)
2016-02-03 23:10 UTC, Travis Hansen
Details
kannel-sqlbox-1.5.0-r1.ebuild (kannel-sqlbox-1.5.0-r1.ebuild,2.03 KB, text/plain)
2016-02-08 08:46 UTC, Travis Hansen
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Travis Hansen 2013-12-09 05:57:29 UTC
http://www.kannel.org/news.shtml#1.5.0

kannel-sqlbox has been merged into kannel proper in the addons directory.  It appears the old (0.7.2) is not longer functional with kannel 1.5.0.

It may be easiest to keep them as separate packages and just change kannel-sqlbox to use the same source tarball as kannel.

Thanks!

Reproducible: Always
Comment 1 Travis Hansen 2013-12-09 06:13:12 UTC
It looks like the old builds have been removed from the kannel server.  I'd integrate the ebuilds into 1 unified ebuild rather than 2.
Comment 2 Travis Hansen 2013-12-24 01:50:25 UTC
I've updated the ebuild and placed it here:

https://github.com/travisghansen/chaos/tree/master/app-mobilephone/kannel-sqlbox

patches no longer necessary.  I probably have syntax on deps wrong but maybe not :)
Comment 3 Tom Wijsman (TomWij) (RETIRED) gentoo-dev 2014-04-09 07:28:10 UTC
[QA]

The mobile-phone herd has been dissolved to maintainer-needed due to absence.

This package has no maintainer so this bug may go unnoticed for a long time.
Gentoo has a dedicated team[1] for assisting users in maintaining orphaned
packages. If you are interested in maintaining this package, please contact
proxy-maint@gentoo.org. 

[1]: https://wiki.gentoo.org/index.php?title=Project:Proxy_Maintainers
Comment 4 Pacho Ramos gentoo-dev 2014-09-26 20:15:12 UTC
I would drop app-mobilephone/kannel-sqlbox and make app-mobilephone/kannel install that addon then :/
Comment 5 Travis Hansen 2016-01-05 15:30:41 UTC
I'll proxy maintain.
Comment 6 Pacho Ramos gentoo-dev 2016-01-06 13:09:58 UTC
(In reply to Travis Hansen from comment #5)
> I'll proxy maintain.

Are you referring to app-mobilephone/kannel package or this one?
Comment 7 Travis Hansen 2016-01-06 18:02:33 UTC
(In reply to Pacho Ramos from comment #6)
> (In reply to Travis Hansen from comment #5)
> > I'll proxy maintain.
> 
> Are you referring to app-mobilephone/kannel package or this one?

Oops, I missed that.  Is the plan then to combine this into the kannel ebuild or just drop it altogether?
Comment 8 Pacho Ramos gentoo-dev 2016-01-08 14:53:35 UTC
If I don't miremember, all should live in kannel package
Comment 9 Travis Hansen 2016-01-08 19:10:46 UTC
(In reply to Pacho Ramos from comment #8)
> If I don't miremember, all should live in kannel package

Well it's the same src tarball but a totally different build process.

You can review the src uri etc..

https://github.com/travisghansen/chaos/blob/master/app-mobilephone/kannel-sqlbox/kannel-sqlbox-1.5.0.ebuild
Comment 10 Pacho Ramos gentoo-dev 2016-01-09 15:23:07 UTC
Umm, then maybe it will be better to keep it splitted indeed. I will CC proxy-maintainers

For now (regarding the ebuild):
- Please try to use eapi5
http://devmanual.gentoo.org/ebuild-writing/eapi/index.html
- openssl has two slots, but likely it requires one concrete one, please specify the right one in dependencies
- Why do you need "LDFLAGS="""?
- As a suggestion (it's not mandatory ;)), you maybe could rely on readme.gentoo-r1.eclass for replacing that elog messages and prevent people from always getting that messages every time they rebuild the package
Comment 11 Travis Hansen 2016-01-09 23:10:59 UTC
(In reply to Pacho Ramos from comment #10)
> Umm, then maybe it will be better to keep it splitted indeed. I will CC
> proxy-maintainers

I'm actually fine if this goes away (I'd prefer kannel remain in-tree however).  I can just keep it in my overlay.  I'm also happy to put the effort in and make it proxy-worthy if that's desired.

Thanks for the consideration!
Comment 12 Ian Delaney (RETIRED) gentoo-dev 2016-01-11 02:13:43 UTC
(In reply to Travis Hansen from comment #11)
> (In reply to Pacho Ramos from comment #10)
> > Umm, then maybe it will be better to keep it splitted indeed. I will CC
> > proxy-maintainers
> 
> I'm actually fine if this goes away (I'd prefer kannel remain in-tree
> however).  I can just keep it in my overlay.  I'm also happy to put the
> effort in and make it proxy-worthy if that's desired.

I don't really know ifthere's a concrete answer to that. If y're willing to proxy maintain the package we will support you in doing so.
Comment 13 Travis Hansen 2016-01-21 06:06:41 UTC
(In reply to Ian Delaney from comment #12) 
> I don't really know ifthere's a concrete answer to that. If y're willing to
> proxy maintain the package we will support you in doing so.

I'm happy to proxy maintain.  1.5.0 came out in 2010 so I doubt it will be much maintenance ;)
Comment 14 Ian Delaney (RETIRED) gentoo-dev 2016-01-28 15:33:19 UTC
(In reply to Travis Hansen from comment #13)
> (In reply to Ian Delaney from comment #12) 
> > I don't really know ifthere's a concrete answer to that. If y're willing to
> > proxy maintain the package we will support you in doing so.
> 
> I'm happy to proxy maintain.  1.5.0 came out in 2010 so I doubt it will be
> much maintenance ;)

To my understanding, you need submit an ebuild to bump it to 1.5.0 and its yours.
Comment 15 Travis Hansen 2016-02-03 23:10:26 UTC
Created attachment 424582 [details]
kannel-sqlbox-1.5.0.ebuild
Comment 16 Travis Hansen 2016-02-03 23:10:51 UTC
Missing the init, but there's my ebuild from the repo.
Comment 17 Ian Delaney (RETIRED) gentoo-dev 2016-02-06 07:26:08 UTC
commit 72a3b80e11bc56c4597a810cc374a2b4ea876ad3
Author: Ian Delaney <idella4@gentoo.org>
Date:   Sat Feb 6 15:23:05 2016 +0800

    app-mobilephone/kannel-sqlbox: bump to vn. 1.5.0
    
    package pmasked for a while by pacho, then offer by user Travis Hansen
    to proxy maintian the package. Bup to vn. 1.5.0 source from ebuild by him,
    added to metadata.xml accordingly, closes the gentoo bug
    
    Gentoo bug: 493712
Comment 18 Pacho Ramos gentoo-dev 2016-02-06 16:26:38 UTC
(In reply to Pacho Ramos from comment #10)
> Umm, then maybe it will be better to keep it splitted indeed. I will CC
> proxy-maintainers
> 
> For now (regarding the ebuild):
> - Please try to use eapi5
> http://devmanual.gentoo.org/ebuild-writing/eapi/index.html
> - openssl has two slots, but likely it requires one concrete one, please
> specify the right one in dependencies
> - Why do you need "LDFLAGS="""?
> - As a suggestion (it's not mandatory ;)), you maybe could rely on
> readme.gentoo-r1.eclass for replacing that elog messages and prevent people
> from always getting that messages every time they rebuild the package

All this problems are still there in final ebuild :/

readme.gentoo-r1.eclass is optional, but using eapi2 for a newly added ebuild, not specifying openssl slot and that strange overwritten of LDFLAGS need to be addressed :|
Comment 19 Travis Hansen 2016-02-08 08:41:28 UTC
(In reply to Pacho Ramos from comment #18)
> readme.gentoo-r1.eclass is optional, but using eapi2 for a newly added
> ebuild, not specifying openssl slot and that strange overwritten of LDFLAGS
> need to be addressed :|

readme.gentoo-r1: done
eapi: bumped to 5
openssl: fairly certain I've used it with both but I've added :0
LDFLAGS: appears to be something related to --as-needed, filtering just that out now.

NOT TOUCHING LDFLAGS:
checking for Ct-Lib support... checking for FreeTDS Ct-Lib support... checking for gw-config... /usr/bin/gw-config
checking Kannel version... 1.5.0
checking Kannel libs... -L/usr/lib64/kannel -lgw -lwap -lgwlib -lmysqlclient_r -lssl -ldl -lpam -lpcreposix -lrt -lresolv -lnsl -lm  -luuid -lpthread -lxml2 -lz -lm -ldl -L/usr/lib64 -lpcreposix -lpcre -L/usr/lib64 -lcrypto -lssl -L/usr/lib64 -lmysqlclient_r -lpthread -lz -lm -lssl -lcrypto -ldl -L/usr/local/lib -lsqlite3 
checking Kannel includes... -I/usr/include/kannel -O2 -march=native -pipe -fno-strict-aliasing -D_XOPEN_SOURCE=600 -D_BSD_SOURCE -I/usr/include/uuid -D_LARGE_FILES= -I/usr/include/libxml2  -Wall -I/usr/include/openssl -I/usr/include/mysql
checking for cfg_create in -lgwlib... no
configure: error: Kannel gwlib is required!

AS IS:
checking for Ct-Lib support... checking for FreeTDS Ct-Lib support... checking for gw-config... /usr/bin/gw-config
checking Kannel version... 1.5.0
checking Kannel libs... -L/usr/lib64/kannel -lgw -lwap -lgwlib -lmysqlclient_r -lssl -ldl -lpam -lpcreposix -lrt -lresolv -lnsl -lm  -luuid -lpthread -lxml2 -lz -lm -ldl -L/usr/lib64 -lpcreposix -lpcre -L/usr/lib64 -lcrypto -lssl -L/usr/lib64 -lmysqlclient_r -lpthread -lz -lm -lssl -lcrypto -ldl -L/usr/local/lib -lsqlite3 
checking Kannel includes... -I/usr/include/kannel -O2 -march=native -pipe -fno-strict-aliasing -D_XOPEN_SOURCE=600 -D_BSD_SOURCE -I/usr/include/uuid -D_LARGE_FILES= -I/usr/include/libxml2  -Wall -I/usr/include/openssl -I/usr/include/mysql
checking for cfg_create in -lgwlib... yes
checking for Kannel's DB support... configure: creating ./config.status


Also it looks like the LICENSE should be updated for both this and just kannel (appears to be the same license although the sqlbox addon has a copy of it in the source addons/sqlbox/KannelLICENSE).

The Kannel Software License, Version 1.0

What's the proper way to deal with that (I've added the file to dodoc)?
Comment 20 Travis Hansen 2016-02-08 08:46:32 UTC
Created attachment 424878 [details]
kannel-sqlbox-1.5.0-r1.ebuild
Comment 21 Ian Delaney (RETIRED) gentoo-dev 2016-02-08 13:43:29 UTC
(In reply to Pacho Ramos from comment #18)

> 
> All this problems are still there in final ebuild :/
> 
> readme.gentoo-r1.eclass is optional, but using eapi2 for a newly added
> ebuild, not specifying openssl slot and that strange overwritten of LDFLAGS
> need to be addressed :|

k thx for further checking pacho

License team please review the observation by T. Hansen

"Also it looks like the LICENSE should be updated for both this and just kannel (appears to be the same license although the sqlbox addon has a copy of it in the source addons/sqlbox/KannelLICENSE)."

Storing a copy of a license does not is not helpful and I will likely revert this.
Comment 22 Travis Hansen 2016-02-08 17:00:47 UTC
(In reply to Ian Delaney from comment #21)
> Storing a copy of a license does not is not helpful and I will likely revert
> this.

I'll revert that in my repo then when I update the LICENSE to whatever is appropriate then.

I'll hold tight until I know how to move forward on that front.

Thanks!
Comment 23 Ulrich Müller gentoo-dev 2016-02-08 17:07:56 UTC
(In reply to Ian Delaney from comment #21)
> License team please review the observation by T. Hansen
> 
> "Also it looks like the LICENSE should be updated for both this and just
> kannel (appears to be the same license although the sqlbox addon has a copy
> of it in the source addons/sqlbox/KannelLICENSE)."

AFAICS, kannel-1.5.0.ebuild and kannel-sqlbox-1.5.0.ebuild have LICENSE="Apache-1.1" and "Apache-1.1 GPL-2", respectively (GPL-2 for the init file, I suppose).

This looks good to me. Why should it be updated?

> Storing a copy of a license does not is not helpful and I will likely revert
> this.
Comment 24 Travis Hansen 2016-02-08 17:31:13 UTC
(In reply to Ulrich Müller from comment #23)
> This looks good to me. Why should it be updated?

The title of the LICENSE file in the source is:

The Kannel Software License, Version 1.0

The same file is found in addons/sqlbox/KannelLICENSE

I'm not sure where GPL-2 came from or apache for that matter.

Presumably they both should have the same licenses I'd guess.
Comment 25 Ulrich Müller gentoo-dev 2016-02-08 17:42:58 UTC
(In reply to Travis Hansen from comment #24)
> (In reply to Ulrich Müller from comment #23)
> > This looks good to me. Why should it be updated?
> 
> The title of the LICENSE file in the source is:
> 
> The Kannel Software License, Version 1.0

Yes, but its terms are identical (word for word) to Apache-1.1. We avoid having copies of the same license under different names.
Comment 26 Ulrich Müller gentoo-dev 2016-02-08 17:46:38 UTC
I just see that the license issue was handled in bug 444848 previously.
Comment 27 Travis Hansen 2016-02-08 17:55:18 UTC
(In reply to Ulrich Müller from comment #25)
> Yes, but its terms are identical (word for word) to Apache-1.1. We avoid
> having copies of the same license under different names.

Ah!  OK, is it common to put GPL-2 for init script?  Should I leave as is or remove GPL-2 then?
Comment 28 Ulrich Müller gentoo-dev 2016-02-08 18:08:53 UTC
(In reply to Travis Hansen from comment #27)
> Ah!  OK, is it common to put GPL-2 for init script?  Should I leave as is or
> remove GPL-2 then?

Seems we have bugs for everything. :) Bug 425914 should answer your question.
Comment 29 Travis Hansen 2016-02-08 18:27:21 UTC
(In reply to Ulrich Müller from comment #28)
> Seems we have bugs for everything. :) Bug 425914 should answer your question.

OK, I'll simply remove the license from dodoc then.  That appears to be the only required change to what I currently have.

Anything else?

I'll create r2 and upload.
Comment 30 Ian Delaney (RETIRED) gentoo-dev 2016-02-09 06:44:16 UTC
commit b785fa83cc5f909cdb4721096bf7d5126d0b2024
Author: Ian Delaney <idella4@gentoo.org>
Date:   Tue Feb 9 14:40:16 2016 +0800

    app-mobilephone/kannel-sqlbox: revbump to 1.5.0-r1 fixing issues from bump
    
    update EPI, drop unused autotools eclass and inherit readme.gentoo-r1,
    set slot operator to openssl, fixes the gentoo bug, remove defunct 1.5.0
    
    Gentoo bug: #493712
Comment 31 Travis Hansen 2016-02-09 18:39:43 UTC
(In reply to Ian Delaney from comment #30)
>     update EPI, drop unused autotools eclass and inherit readme.gentoo-r1,
>     set slot operator to openssl, fixes the gentoo bug, remove defunct 1.5.0

Thanks!

Did you want to leave KannelLICENSE in dodoc?
Comment 32 Ulrich Müller gentoo-dev 2016-02-09 19:37:43 UTC
(In reply to Travis Hansen from comment #31)
> Did you want to leave KannelLICENSE in dodoc?

Removed.