493306 – dev-vcs/git-2.3.* - build fails "cannot find -liconv", >=sys-freebsd/freebsd-lib-10.1

Bug 493306 - dev-vcs/git-2.3.* - build fails "cannot find -liconv", >=sys-freebsd/freebsd-lib-10.1

Summary: dev-vcs/git-2.3.* - build fails "cannot find -liconv", >=sys-freebsd/freebsd-...

Status:	RESOLVED FIXED

Alias:	None

Product:	Gentoo/Alt
Classification:	Unclassified
Component:	FreeBSD (show other bugs)
Hardware:	All FreeBSD

Importance:	Normal normal (vote)
Assignee:	Gentoo/BSD Team

URL:
Whiteboard:
Keywords:	PATCH

Depends on:
Blocks:	488214
	Show dependency tree

Reported:	2013-12-04 12:21 UTC by Yuta SATOH
Modified:	2015-09-06 23:19 UTC (History)
CC List:	2 users (show)

See Also:
Package list:
Runtime testing required:	---

Attachments
sample patch for config.mak.uname (493306.patch,531 bytes, patch) 2013-12-04 12:23 UTC, Yuta SATOH	Details \| Diff
Patch to not use libiconv if >=FreeBSD 10.x (git-2.3.5-no-libiconv-freebsd10x.patch,568 bytes, patch) 2015-04-12 02:50 UTC, Joshua Kinard	Details \| Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Yuta SATOH 2013-12-04 12:21:25 UTC

Implementation of iconv enabled in libc on FreeBSD 10.0.
libiconv.so is no longer exists...

FYI,
http://svnweb.freebsd.org/ports/head/UPDATING?r1=325786&r2=326307&view=patch


build log)
<snip>
x86_64-gentoo-freebsd10.0-gcc -o xdiff/xhistogram.o -c -MF xdiff/.depend/xhistogram.o.d -MQ xdiff/xhistogram.o -MMD -MP  -O2 -pipe -ggdb -Wall -I. -I/usr/local/include -DUSE_LIBPCRE -DUSE_ST_TIMESPEC  -DHAVE_PATHS_H -DSHA1_HEADER='"block-sha1/sha1.h"'  -DUSE_WILDMATCH -DNO_MEMMEM -DDIR_HAS_BSD_GROUP_SEMANTICS -DSHELL_PATH='"/bin/sh"'  xdiff/xhistogram.c
rm -f xdiff/lib.a && x86_64-gentoo-freebsd10.0-ar rcs xdiff/lib.a xdiff/xdiffi.o xdiff/xprepare.o xdiff/xutils.o xdiff/xemit.o xdiff/xmerge.o xdiff/xpatience.o xdiff/xhistogram.o
x86_64-gentoo-freebsd10.0-gcc  -O2 -pipe -ggdb -Wall -I. -I/usr/local/include -DUSE_LIBPCRE -DUSE_ST_TIMESPEC  -DHAVE_PATHS_H -DSHA1_HEADER='"block-sha1/sha1.h"'  -DUSE_WILDMATCH -DNO_MEMMEM -DDIR_HAS_BSD_GROUP_SEMANTICS -DSHELL_PATH='"/bin/sh"' -o git-credential-store   -L/usr/local/lib credential-store.o libgit.a xdiff/lib.a  -lpcre -lz  -liconv -lintl -lpthread
/usr/lib/gcc/x86_64-gentoo-freebsd10.0/4.8.2/../../../../x86_64-gentoo-freebsd10.0/bin/ld: cannot find -liconv
collect2: error: ld returned 1 exit status
Makefile:2058: recipe for target 'git-credential-store' failed
gmake: *** [git-credential-store] Error 1
 * ERROR: dev-vcs/git-1.8.4.4::gentoo failed (compile phase):
 *   emake failed

Comment 1 Yuta SATOH 2013-12-04 12:23:08 UTC

Created attachment 364588 [details, diff]
sample patch for config.mak.uname

Comment 2 Joshua Kinard gentoo-dev

2015-04-12 02:49:09 UTC

CC'ing git maintainer for consideration.  I'll upload a newer patch against git-2.3.5 that allows it to compile on a Gentoo/FreeBSD 10.x system.

Comment 3 Joshua Kinard gentoo-dev

2015-04-12 02:50:56 UTC

Created attachment 401064 [details, diff]
Patch to not use libiconv if >=FreeBSD 10.x

Updated patch for git-2.3.5.

Comment 4 Joshua Kinard gentoo-dev

2015-09-06 23:19:10 UTC

I updated the attached patch for git-2.5.1 and added it to the tree for that version only, as all freebsd versions are ~ARCH.  Tested on both freebsd-amd64-10.2, and linux-amd64-4.1.6.

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=e7c87c71a93aade54a574d2d11738019654029cd