Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 468298 - dev-libs/redland-1.0.16 - empty LDFLAGS results in mangled redland.pc
Summary: dev-libs/redland-1.0.16 - empty LDFLAGS results in mangled redland.pc
Status: RESOLVED OBSOLETE
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Library (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Sound Team
URL:
Whiteboard:
Keywords: STABLE
Depends on:
Blocks: pc_noupstream
  Show dependency tree
 
Reported: 2013-05-02 13:56 UTC by Ben Kohler
Modified: 2014-05-13 19:48 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
redland-1.0.16-pkgconfig.patch (redland-1.0.16-pkgconfig.patch,768 bytes, patch)
2013-05-02 14:56 UTC, Julian Ospald
Details | Diff
redland-1.0.16.ebuild.patch (redland-1.0.16.ebuild.patch,922 bytes, patch)
2013-05-02 14:57 UTC, Julian Ospald
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ben Kohler gentoo-dev 2013-05-02 13:56:21 UTC
The ebuild has a sed command to remove LDFLAGS from the pkg-config file:

sed -i \
        -e "s:${LDFLAGS}::g" \
        "${ED}"/usr/$(get_libdir)/pkgconfig/redland.pc || die

But if the user has set LDFLAGS="" then this removes all spaces from the entire file, and it's unusable by pkg-config:

prefix=/usr
exec_prefix=${prefix}
libdir=/usr/lib64
includedir=${prefix}/include

plugindir=${libdir}/redland

swig=${prefix}/share/redland/Redland.i

have_raptor2_api=1

Name:RedlandRDFAPILibrary
Description:RedlandRDFAPIandtriplestorelibrary
Requires.private:raptor2>=2.0.7,rasqal>=0.9.25,rasqal<=0.9.99
Version:1.0.16
Libs:-L${libdir}-lrdf
Libs.private:-ldl-ldb-4.8
Cflags:-I${includedir}
Comment 1 Julian Ospald 2013-05-02 14:56:19 UTC
Created attachment 347138 [details, diff]
redland-1.0.16-pkgconfig.patch

This should be done properly not with such sed hacks.
Comment 2 Julian Ospald 2013-05-02 14:57:47 UTC
Created attachment 347140 [details, diff]
redland-1.0.16.ebuild.patch
Comment 3 Julian Ospald 2013-05-02 14:59:05 UTC
unfortunately this is a stable ebuild and I feel uncomfortable about applying this retroactively. We should probably just wrap the sed inside a
[[ -z ${LDFLAGS} ]] || { sed ... ;}
check until the next revbump/version bump
Comment 4 Julian Ospald 2013-05-02 15:12:48 UTC
this bug will be closed when the actual patch can be applied on version bump or is included upstream

+  02 May 2013; Julian Ospald <hasufell@gentoo.org> redland-1.0.16.ebuild:
+  fix sed-hack wrt #468298