Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 461472 - games-action/d1x-rebirth ebuild updates (again)
Summary: games-action/d1x-rebirth ebuild updates (again)
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Games (show other bugs)
Hardware: All Linux
: Normal enhancement (vote)
Assignee: Gentoo Games
URL:
Whiteboard:
Keywords: EBUILD
Depends on:
Blocks:
 
Reported: 2013-03-12 03:48 UTC by Jared B.
Modified: 2017-03-04 17:48 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
games-action/d1x-rebirth-0.57.3-r1.ebuild (d1x-rebirth-0.57.3-r1.ebuild,2.43 KB, text/plain)
2013-03-12 03:48 UTC, Jared B.
Details
games-action/descent1-data-1.0-r1.ebuild (descent1-data-1.0-r1.ebuild,3.34 KB, text/plain)
2013-03-12 04:14 UTC, Jared B.
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Jared B. 2013-03-12 03:48:49 UTC
Created attachment 341772 [details]
games-action/d1x-rebirth-0.57.3-r1.ebuild

Updated ebuild with the enhancements discussed in bug 369419.  Again, the main point is to split out the data portion into a separate ebuild so that it better matches the d2x ebuild and also includes support for installing from more sources than just the CD.

Specific changes from the 0.57.3 in-tree ebuild, for those that may be interested:
* changed d1xrdata.zip to d1xr-hires.zip to match upstream naming
* dropped dxx-rebirth_icons.zip as the icon is already included in the main source package
* added cdinstall dependency on descent1-data
* removed all other cdinstall-related functionality, as it will be handled by descent1-data
* dropped unzip dependency as, best I can tell, it's not actually needed


Updated descent1-data ebuild will be coming shortly.
Comment 1 Jared B. 2013-03-12 04:14:28 UTC
Created attachment 341774 [details]
games-action/descent1-data-1.0-r1.ebuild

Attaching descent1-data ebuild.  As noted in the previous bug:

The biggest change was to accommodate copying the descent 1 data files from an install source rather than just from the CD.  This is necessary to support the version of Descent available from Good Old Games.  Since this required a fair amount of extra code to deal with just copying the data files, I split this bit out into a separate descent1-data ebuild.  This also makes it more consistent with the Descent II ebuilds.

The descent1-data is modeled on the updated descent2-data ebuild I submitted in bug 369397.  It has been since updated to support installation directly from the GOG installer, and, as requested, to more closely match the in-tree d1x-rebirth-0.57.3 ebuild.

Questions and suggestions welcome.
Comment 2 Jared B. 2013-03-12 05:43:40 UTC
FYI, I hadn't realized it, but there's another bug out there about d1x-rebirth as well, and it also does the split data ebuild thing:  bug 345813.  Not sure how I missed it prior to now, but I wish I had seen it sooner.  Would've saved me some time.  :-)

From a cursory glance, though, it appears that James' changes in that thread have been mostly superseded at this point: the demo patch he included has since been incorporated in the main release, and the data ebuild is similar in concept to my own but lacks the bells and whistles.  I think it can probably be closed at this point, but I did want to bring it up to make sure it also gets proper visibility.
Comment 3 Alexander Turenko 2013-08-05 20:27:00 UTC
Thanks for all who take part in writing ebuilds!

I put ebuilds for d{1,2}x-rebirth and descent{{1,2}-data,2-vertigo} ebuilds to gamerlay overlay. This ebuilds based on bugs.gentoo.org attachments (in november 2012). Now, in 2013, ebuilds updated with new main tree ebuilds changes and bugs.gentoo.org new attachments. Also, I add ebuild for new d{1,2}x-rebirth version 0.58.1.

If somewhat forgotten (some regression occured) in these ebuild, please let me know. Many attachments from many bugs (and main tree) is hard to merge to one, then that might occured.

Maybe contribute one, placed in gamerlay repo version of ebuilds will be more simple. Any suggestions are welcome.
Comment 4 James Le Cuirot gentoo-dev 2017-03-04 17:48:38 UTC
0.58.1 went into the tree years ago so closing. I'll take a look at dxx-rebirth now, which I see is in gamerlay.