Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 455798 - java-config-2.1.12: gjl only ensures minimum vm version
Summary: java-config-2.1.12: gjl only ensures minimum vm version
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Java (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Java team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-02-06 07:23 UTC by Ralph Sennhauser (RETIRED)
Modified: 2016-05-18 21:40 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
Suggested fix, vastly simplyfing gjl (java-config-gjl-get-vm.patch,528 bytes, patch)
2013-02-06 17:53 UTC, Ralph Sennhauser (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ralph Sennhauser (RETIRED) gentoo-dev 2013-02-06 07:23:20 UTC
The original assumption was if it works with 6 it will work with 7. This assumption breaks from time to time. ali_bush committed a --get-vm implementation which analyzes the recorded VM dep string instead of classfile version.[1]

For some reason this implementation was never hooked up though.

[1] http://overlays.gentoo.org/proj/java/changeset/5734
Comment 1 Ralph Sennhauser (RETIRED) gentoo-dev 2013-02-06 17:53:06 UTC
Created attachment 338128 [details, diff]
Suggested fix, vastly simplyfing gjl

The new implementation is overdoing it. It verifies the vm deps of all dependencies as well. This isn't needed as it would imply RDEPEND having been wrong in the first place. With that in mind this is no more than a qa check in the wrong place.

The attached patch will vastly simplify gjl by reusing well tested code in the core. This will also allow to halve gjl's code base. The patch assumes that the recorded RDEPEND is correct also for it's dependencies.

If there are no objections I will commit this change.
Comment 2 Ralph Sennhauser (RETIRED) gentoo-dev 2013-02-08 16:17:36 UTC
Fixed in svn.

http://overlays.gentoo.org/proj/java/changeset/9183
Comment 3 James Le Cuirot gentoo-dev 2016-05-18 21:40:26 UTC
This was release in java-config 2.2.0.