This change breaks ebuilds that inherit waf-utils: http://sources.gentoo.org/cgi-bin/viewvc.cgi/gentoo-x86/eclass/waf-utils.eclass?r1=1.7&r2=1.8 For my system w/ MAKEOPTS="-j5" as an example, midori-0.4.5 errors thusly: "/var/tmp/portage/www-client/midori-0.4.4/work/midori-0.4.4/waf" build 5 error: No such command '5' I believe it should be local jobs="-j$(makeopts_jobs)" or similar. Reproducible: Always
*** Bug 412167 has been marked as a duplicate of this bug. ***
Assigning to gnome@ because it's listed as maintainer in the eclass. CCing vapier@ as he committed the change that broke this (just to notify him): http://sources.gentoo.org/cgi-bin/viewvc.cgi/gentoo-x86/eclass/waf-utils.eclass?r1=1.7&r2=1.8
And should be fixed with this (at least www-client/midori works like it did before vapier's change): http://sources.gentoo.org/viewvc.cgi/gentoo-x86/eclass/waf-utils.eclass?r1=1.8&r2=1.9 Changed: local jobs=$(makeopts_jobs) To: local jobs="--jobs=$(makeopts_jobs)" As the old method also passed same: $ export MAKEOPTS="-j9" $ jobs=$(echo -j1 ${MAKEOPTS} | sed -r "s/.*(-j\s*|--jobs=)([0-9]+).*/--jobs=\2/" ) $ echo $jobs --jobs=9 16 Apr 2012; Samuli Suominen <ssuominen@gentoo.org> waf-utils.eclass: Unbreak waf-utils.eclass by restoring --jobs= argument wrt #412159 15 Apr 2012; Mike Frysinger <vapier@gentoo.org> db.eclass perl-module.eclass waf-utils.eclass: Use new makeopts_jobs helper from eutils.eclass.
This has broken pycairo for me. Even if I unset -j in MAKEOPTS it still implies -j1 so it tries to call a '1' function, which doesn't exist, of course.
(In reply to comment #4) > This has broken pycairo for me. Even if I unset -j in MAKEOPTS it still > implies -j1 so it tries to call a '1' function, which doesn't exist, of > course. What is this "This" you are talking about? The problem is already fixed in tree as mentioned in Comment #3. No point in leaving comments from outdated tree.
(In reply to comment #5) > What is this "This" you are talking about? The problem is already fixed in > tree as mentioned in Comment #3. No point in leaving comments from outdated > tree. I synced before I wrote my comment and still didn't work at that point. Don't be so obnoxious. How about "Try syncing and emerging pycairo now"? You might elicit more enthusiasm from users instead of disdain.
(In reply to comment #3) sorry about that ... a bunch of files had different sed's and it was hard to pick out the subtleties of them. i tried a few, but i guess not the waf-utils one.
