Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 402467 - Signals should be blocked on actual merge/unmerge
Summary: Signals should be blocked on actual merge/unmerge
Status: CONFIRMED
Alias: None
Product: Portage Development
Classification: Unclassified
Component: Core (show other bugs)
Hardware: All All
: Normal normal (vote)
Assignee: Portage team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 910332
  Show dependency tree
 
Reported: 2012-02-06 22:37 UTC by Jeff (JD) Horelick (RETIRED)
Modified: 2024-03-03 22:16 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jeff (JD) Horelick (RETIRED) gentoo-dev 2012-02-06 22:37:44 UTC
Signals should be blocked on the actual merge/unmerge as you can have serious undefined behaviour (some files may be merged, but others may be missing) or worse, you could do it on a critical system package such as python or portage or glibc or gcc and have a very broken system.

IMO, this doesn't break ^C working because the user still has all the time src_* takes to stop the merge.

Reproducible: Always
Comment 1 Zac Medico gentoo-dev 2012-02-06 23:14:44 UTC
We should be able use the Scheduler's existing signal handling code to allow running merges to complete:

http://git.overlays.gentoo.org/gitweb/?p=proj/portage.git;a=commit;h=c4451a1e94212025e060cfd8e6a2341527202086