Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 383001 - dev-libs/xapian-1.2.7 version bump
Summary: dev-libs/xapian-1.2.7 version bump
Status: RESOLVED TEST-REQUEST
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Anthony Basile
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 272720 383047
  Show dependency tree
 
Reported: 2011-09-14 22:50 UTC by Johan Bergström
Modified: 2011-09-16 06:40 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
xapian-1.2.7.ebuild (xapian-1.2.7.ebuild,787 bytes, text/plain)
2011-09-14 22:50 UTC, Johan Bergström
Details
xapian-1.2.7.ebuild (xapian-1.2.7.ebuild,784 bytes, text/plain)
2011-09-14 23:56 UTC, Johan Bergström
Details
xapian-1.2.7.ebuild (xapian-1.2.7.ebuild,734 bytes, text/plain)
2011-09-16 06:40 UTC, Johan Bergström
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Johan Bergström 2011-09-14 22:50:00 UTC
Created attachment 286481 [details]
xapian-1.2.7.ebuild

While at it, I did some stuff:
 - by looking at configure.ac I figured out that setting VALGRIND to empty, xapian should avoid using it in testing
 - add static-libs use-flag
Comment 1 Johan Bergström 2011-09-14 23:56:06 UTC
Created attachment 286499 [details]
xapian-1.2.7.ebuild

Minor updates:
 - move avoid-valgrind thing to src_test
 - hide docs behind IUSE="doc". It's a pretty huge chunk of docs
 - don't remove .la since xapian-config needs it (ok this isn't minor)
Comment 2 Anthony Basile gentoo-dev 2011-09-15 00:43:22 UTC
Okay, I'll take a look at this and add it for you if it works.  I'm still not sure I want to maintain this package, but if it solves bug #272720 then its a step in the right direction.
Comment 3 Johan Bergström 2011-09-15 06:19:02 UTC
(In reply to comment #2)
> Okay, I'll take a look at this and add it for you if it works.  I'm still not
> sure I want to maintain this package, but if it solves bug #272720 then its a
> step in the right direction.

I'll do xapian-bindings next. Arfrever has a pretty good ebuild (adds tcl and perl) going on which I will base the new version upon. Feel free to add me as proxy for whatever its worth.
Comment 4 Johan Bergström 2011-09-15 08:15:28 UTC
Hello and welcome, dear proxy team. Will you work with me on this package?
Comment 5 Markos Chandras (RETIRED) gentoo-dev 2011-09-15 10:45:14 UTC
I can help you if nobody else does. I have no personal interest in this package but I would like to help.
Comment 6 Anthony Basile gentoo-dev 2011-09-15 11:32:14 UTC
Okay, I've added this with a couple of changes.  Bumped to EAPI=4 and removed unneeded || dies and uneeded inherit eutils.

I also tested with VALGRIND="/bin/true" and that works.  And I tested hacking out all tests for valgrind from configure.ac and unset HAVE_VALGRIND, and that worked, so we have alternatives here.

Please test once it hits the tree and report back.
Comment 7 Johan Bergström 2011-09-15 11:35:54 UTC
(In reply to comment #6)
> Okay, I've added this with a couple of changes.  Bumped to EAPI=4 and removed
> unneeded || dies and uneeded inherit eutils.
> 
> I also tested with VALGRIND="/bin/true" and that works.  And I tested hacking
> out all tests for valgrind from configure.ac and unset HAVE_VALGRIND, and that
> worked, so we have alternatives here.
> 
> Please test once it hits the tree and report back.

Just a note: I started hacking around with configure.ac as well, but upstream suggested VALGRIND to make check (I started off using it from econf). Looking at tests/runtest.in you will find this:

test -z "${VALGRIND+set}" && VALGRIND="@VALGRIND@"
if test -z "$VALGRIND" ; then
 
…which leads me to believe that VALGRIND= would be the best solution.
Comment 8 Anthony Basile gentoo-dev 2011-09-15 12:18:39 UTC
(In reply to comment #7)
> (In reply to comment #6)
> if test -z "$VALGRIND" ; then
>
> …which leads me to believe that VALGRIND= would be the best solution.

Yeah, I did see that and I agree.
Comment 9 Arfrever Frehtes Taifersar Arahesis 2011-09-15 18:27:01 UTC
Why ~ppc keyword was removed?
Comment 10 Arfrever Frehtes Taifersar Arahesis 2011-09-15 18:29:47 UTC
The ebuild always installs documentation. "doc" USE flag only affects location of installed documentation. I suggest to revert introduction of this USE flag.
Comment 11 Anthony Basile gentoo-dev 2011-09-15 20:32:09 UTC
(In reply to comment #9)
> Why ~ppc keyword was removed?

I was unable to test ppc. If you can confirm that ppc works, I'll add it.
Comment 12 Anthony Basile gentoo-dev 2011-09-15 20:33:22 UTC
(In reply to comment #10)
> The ebuild always installs documentation. "doc" USE flag only affects location
> of installed documentation. I suggest to revert introduction of this USE flag.

Okay, I'll test and if so, I'll either remove it or hack it up so that it doesn't install docs with USE="-doc".  Patches welcome!
Comment 13 Johan Bergström 2011-09-16 06:40:35 UTC
Created attachment 286623 [details]
xapian-1.2.7.ebuild

Updated ebuild with a doc flag that actually (well, if disabled) deletes documentation.