Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 376775 - app-portage/g-cpan-0.16.4 handling of overlays
Summary: app-portage/g-cpan-0.16.4 handling of overlays
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All All
: Normal trivial (vote)
Assignee: Robin Johnson
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-07-28 16:10 UTC by Scott Bertilson
Modified: 2014-12-19 19:44 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Scott Bertilson 2011-07-28 16:10:55 UTC
Seems excessively chatty if multiple overlays that do not have perl-gcpan components:

 * OVERLAY: /var/lib/layman/sabayon/perl-gcpan
 * Couldn't open folder /var/lib/layman/sabayon/perl-gcpan: No such file or directory
 * OVERLAY: /var/lib/layman/sipx/perl-gcpan
 * Couldn't open folder /var/lib/layman/sipx/perl-gcpan: No such file or directory
 * OVERLAY: /var/lib/layman/voip/perl-gcpan
 * Couldn't open folder /var/lib/layman/voip/perl-gcpan: No such file or directory
 * OVERLAY: /var/lib/layman/sunrise/perl-gcpan
 * Couldn't open folder /var/lib/layman/sunrise/perl-gcpan: No such file or directory
 * OVERLAY: /var/lib/layman/barzog-overlay/perl-gcpan
 * Couldn't open folder /var/lib/layman/barzog-overlay/perl-gcpan: No such file or directory
 * OVERLAY: /var/lib/layman/science/perl-gcpan
 * Couldn't open folder /var/lib/layman/science/perl-gcpan: No such file or directory


Suggest:

--- /usr/bin/g-cpan     2011-06-18 09:04:31.218153401 -0500
+++ /tmp/g-cpan 2011-07-28 10:57:47.035373472 -0500
@@ -435,8 +435,9 @@
         my @overlays = split ' ', $overlay;
         foreach my $overlay_dir (@overlays)
         {
-                       next unless (-d $overlay_dir);
+           next unless (-d $overlay_dir);
             my $gcpan_dir = File::Spec->catdir($overlay_dir, $GCPAN_CAT);
+           next unless (-d $gcpan_dir);
 
             #$list and print_info("OVERLAY: $gcpan_dir");
             print_info("OVERLAY: $gcpan_dir");

Reproducible: Always

Steps to Reproduce:
1.Add overlays that do not have a perl-gcpan subdir.
2.Do "g-cpan --upgrade".
3.
Comment 1 Andreas K. Hüttel archtester gentoo-dev 2014-12-13 23:51:45 UTC
Fixed in master, leaving the bug open until release
Comment 2 Andreas K. Hüttel archtester gentoo-dev 2014-12-19 19:44:45 UTC
(In reply to Andreas K. Hüttel from comment #1)
> Fixed in master, leaving the bug open until release

Fix included in 0.16.6