Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 375169 - >=sys-apps/portage-2.1.10.5 in cnf/logrotate.d/elog-save-summary there is an invalid option for <app-admin/logrotate-3.8.0
Summary: >=sys-apps/portage-2.1.10.5 in cnf/logrotate.d/elog-save-summary there is an ...
Status: CONFIRMED
Alias: None
Product: Portage Development
Classification: Unclassified
Component: Core - Ebuild Support (show other bugs)
Hardware: All Linux
: Normal normal with 1 vote (vote)
Assignee: Portage team
URL:
Whiteboard:
Keywords:
: 376477 (view as bug list)
Depends on: 374287
Blocks:
  Show dependency tree
 
Reported: 2011-07-14 10:29 UTC by Ruggero Morsucci
Modified: 2011-08-12 02:08 UTC (History)
6 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ruggero Morsucci 2011-07-14 10:29:39 UTC
in cnf/logrotate.d/elog-save-summary: su portage portage is valid option only for >=app-admin/logrotate-3.8.0 https://fedorahosted.org/logrotate/browser/tags/r3-8-0/CHANGES

possible fix:
--- /usr/portage/sys-apps/portage/portage-2.1.10.6.ebuild.old	2011-07-14 03:59:42.000000000 +0200
+++ /usr/portage/sys-apps/portage/portage-2.1.10.6.ebuild.new	2011-07-14 11:51:54.893258143 +0200
@@ -205,6 +205,9 @@
 
 	dosym ..${portage_share_config}/make.globals /etc/make.globals
 
+	if has_version "<app-admin/logrotate-3.8.0" ; then
+		sed -i '/su portage portage/d' "${S}"/cnf/logrotate.d/elog-save-summary
+	fi
 	insinto /etc/logrotate.d
 	doins "${S}"/cnf/logrotate.d/elog-save-summary || die


Reproducible: Always
Comment 1 Zac Medico gentoo-dev 2011-07-14 15:03:09 UTC
(In reply to comment #0)
> +    if has_version "<app-admin/logrotate-3.8.0" ; then
> +        sed -i '/su portage portage/d'
> "${S}"/cnf/logrotate.d/elog-save-summary
> +    fi

If we do that then it's going to break as soon as you upgrade to logrotate-3.8.0 though. If it only results in a warning for now, then perhaps the warning is acceptable until logrotate-3.8.0 is stabilized?
Comment 2 Daniel Gryniewicz (RETIRED) gentoo-dev 2011-07-14 15:26:05 UTC
That was the decision in https://bugs.gentoo.org/show_bug.cgi?id=374287 was that the warning is acceptable.  3.8.0 is a security bump, and will go stable very quickly.
Comment 3 Roger 2011-07-21 07:54:47 UTC
In ref to Comment #2, you can likely just type Bug #374287, and Bugzilla will embed the link to reference bugs.gentoo.org URL.

See this too and since the portage-2.2.0 are still hard masked, probably best to just sit and wait until logrotate-3.8.0 goes stable.

Users with a mail server installed (ie. postfix) and get their local root mail will see this warning as I do -- so unlikely this bug will get buried!
Comment 4 Zac Medico gentoo-dev 2011-07-26 16:33:14 UTC
*** Bug 376477 has been marked as a duplicate of this bug. ***
Comment 5 Cyprien Nicolas (fulax) 2011-07-30 09:59:27 UTC
(In reply to bug 376477 comment #1)
> Thanks, I've updated the ebuilds in cvs to blocker <logrotate-3.8.0.

This blocks portage-2.2 updates on stable systems.

IMHO, this is less acceptable than the logrotate warning.
Comment 6 Zac Medico gentoo-dev 2011-07-30 20:14:54 UTC
(In reply to comment #5)
> (In reply to bug 376477 comment #1)
> > Thanks, I've updated the ebuilds in cvs to blocker <logrotate-3.8.0.
> 
> This blocks portage-2.2 updates on stable systems.
> 
> IMHO, this is less acceptable than the logrotate warning.

It's not so bad. Just add it to package.accept_keywords:

  echo =app-admin/logrotate-3.8.0 >> /etc/portage/package.accept_keywords
Comment 7 Daniel Gryniewicz (RETIRED) gentoo-dev 2011-08-03 23:56:28 UTC
For the record, it's going stable in bug #372973 right now.