I'm crazy and I thought these VisualHostKey things might be cool. They end up just polluting one's screen and breaking sunrise-commit. When sunrise-commit breaks in this way, it should make it more obvious to the user what is happening. sunrise-commit is seeing 1. output from cvs on stderr instead of stdout 2. something that doesn't look like the output of ``cvs up -nq''. sunrise-commit should say something more like ``I could not parse the output of <command>.''. Also, sunrise-commit might be able to ignore this particular output from cvs, add -o VisualHostKey=no somewhere, or just tell the user to make his ssh quieter. ohnobinki@ohnopublishing ~/gentoo-x86/net-irc/unrealircd $ sunrise-commit "Test commit (newline)." Host key fingerprint is 84:db:48:d1:39:45:a4:c8:f4:fd:6c:0d:fa:18:81:19 +[RSA 2048]-------+ | o.E=+ | | o =+* | | = *.o . | | . = = o | | o S o + . | | = | | . . | | | | | +-----------------+ M ChangeLog M unrealircd-3.2.8.1-r1.ebuild --- ChangeLog 2011-05-05 15:25:02.000000000 -0400 +++ ChangeLog.new 2011-05-05 15:25:09.000000000 -0400 @@ -4,6 +4,10 @@ 05 May 2011; Nathan Phillip Brink <binki@gentoo.org> unrealircd-3.2.8.1-r1.ebuild: + Test commit (newline). + + 05 May 2011; Nathan Phillip Brink <binki@gentoo.org> + unrealircd-3.2.8.1-r1.ebuild: Fix bug 316379 reported by shimi by adding buildtime depend on pkgconfig. 12 Jun 2010; Alex Legler <a3li@gentoo.org> -unrealircd-3.2.8.1.ebuild, [ERROR] !!! Please fix the following issues reported from cvs: (U,P,M,A,R,D are ok) [ERROR] !!! Note: This is a pretend/no-modify pass... [ERROR] | o.E=+ | | o =+* | | = *.o . | | . = = o | | o S o + . | | = | | . . | | | | | M ChangeLog M unrealircd-3.2.8.1-r1.ebuild
I think this particular output comes from repoman, and we really can't control what kind of options repoman passes on to CVS. If ssh doesn't support disabling that via an environment variable, I don't think we can really do anything about it.
Renamed to repo-commit.
I don't think we need to be concerned by CVS anymore.
