Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 36443 - xmms-shell configure.in doesn't recognize libreadline
Summary: xmms-shell configure.in doesn't recognize libreadline
Status: VERIFIED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: x86 Linux
: High normal (vote)
Assignee: Jeremy Huddleston (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2003-12-24 13:34 UTC by Tom Dickson
Modified: 2004-02-04 06:52 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Tom Dickson 2003-12-24 13:34:02 UTC
Trying to emerge xmms-shell with readline in my USE results in the problems described in http://forums.gentoo.org/viewtopic.php?t=117995&highlight= The solution there works, so it looks like configure.in should be modified to check ncurses first.

Reproducible: Always
Steps to Reproduce:
1.add readline to USE
2.emerge xmms-shell
3.configure doesn't see readline

Actual Results:  
xmms-shell had no readline support and so it was pretty useless.

Expected Results:  
Configure.in should be changed to 

if test x$with_readline = xyes
 then
  AC_CHECK_LIB(ncurses, main)
  AC_CHECK_LIB(readline, readline)
 fi

The AC_CHECK_LIB(ncurses, main) is the new line needed for it to work.

Portage 2.0.49-r15 (default-x86-1.4, gcc-3.2.3, glibc-2.3.2-r3, 2.6.0)
=================================================================
System uname: 2.6.0 i686 AMD Athlon(tm) XP 2200+
Gentoo Base System version 1.4.3.10
ACCEPT_KEYWORDS="x86"
AUTOCLEAN="yes"
CFLAGS="-Os -march=athlon-xp -pipe"
CHOST="i686-pc-linux-gnu"
COMPILER="gcc3"
CONFIG_PROTECT="/etc /var/qmail/control /usr/kde/2/share/config
/usr/kde/3/share/config /usr/X11R6/lib/X11/xkb /usr/kde/3.1/share/config
/usr/share/config"
CONFIG_PROTECT_MASK="/etc/gconf /etc/env.d"
CXXFLAGS="-Os -march=athlon-xp -pipe"
DISTDIR="/usr/portage/distfiles"
FEATURES="sandbox ccache autoaddcvs"
GENTOO_MIRRORS="rsync://mirrors.tds.net/gentoo http://gentoo.noved.org/
ftp://ftp.ussg.iu.edu/pub/linux/gentoo http://gentoo.ccccom.com"
MAKEOPTS="-j2"
PKGDIR="/usr/portage/packages"
PORTAGE_TMPDIR="/var/tmp"
PORTDIR="/usr/portage"
PORTDIR_OVERLAY=""
SYNC="rsync://rsync.gentoo.org/gentoo-portage"
USE="x86 oss apm avi crypt cups encode foomaticdb gif gtk2 jpeg libg++ libwww
mad mikmod motif mpeg ncurses nls pdflib png quicktime spell truetype xml2 xmms
xv zlib gdbm berkdb slang arts svga java sdl gpm tcpd pam ssl perl python esd
imlib oggvorbis opengl mozilla ntpl readline X gtk gnome -kde -qt dvd"
Comment 1 Tom Dickson 2003-12-24 13:36:41 UTC
Hmm.. fixing configure.in doesn't let xmms-shell compile:

Making all in include
make[1]: Entering directory `/var/tmp/portage/xmms-shell-0.99.0-r1/work/xmms-shell-0.99.0/include'
make[1]: Leaving directory `/var/tmp/portage/xmms-shell-0.99.0-r1/work/xmms-shell-0.99.0/include'
Making all in src
make[1]: Entering directory `/var/tmp/portage/xmms-shell-0.99.0-r1/work/xmms-shell-0.99.0/src'
g++ -DHAVE_CONFIG_H -I. -I. -I../include     -I/usr/include/xmms -I/usr/include/gtk-1.2 -I/usr/include/glib-1.2 -I/usr/lib/glib/include -I/usr/X11R6/include -c getline.cc
getline.cc: In function `void getline_rl_init()':
getline.cc:246: invalid conversion from `char**(*)()' to `char**(*)(const
   char*, int, int)'
make[1]: *** [getline.o] Error 1
make[1]: Leaving directory `/var/tmp/portage/xmms-shell-0.99.0-r1/work/xmms-shell-0.99.0/src'
make: *** [all-recursive] Error 1
Comment 2 Nick Hadaway 2004-01-23 22:26:09 UTC
please test xmms-shell-0.99.3 which doesn't appear to have the same compile problem.  If I get a good report or 4 I will happily mark 0.99.3 as stable and remove the broken version from portage.
Comment 3 Tom Dickson 2004-01-23 23:25:08 UTC
I still get the same problem. Should I check something else?

>>> Unpacking xmms-shell-0.99.3.tar.gz to /var/tmp/portage/xmms-shell-0.99.3/work
>>> Source unpacked.
creating cache ./config.cache
checking for a BSD compatible install... /bin/install -c
checking whether build environment is sane... yes
checking whether make sets ${MAKE}... yes
checking for working aclocal... found
checking for working autoconf... found
checking for working automake... found
checking for working autoheader... found
checking for working makeinfo... found
checking for xmms-config... yes
checking XMMS version... 1.2.7
checking XMMS libs... yes
checking XMMS cflags... yes
checking for readline in -lreadline... no
checking for c++... g++
Comment 4 Jeremy Huddleston (RETIRED) gentoo-dev 2004-02-04 00:43:21 UTC
I added a patch to fix it in xmms-shell-0.99.3-r1
Comment 5 Tom Dickson 2004-02-04 06:52:52 UTC
Yay! Works! You guys rock!

checking for main in -lncurses... yes
checking for readline in -lreadline... yes
checking for c++... g++