Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 364293 - games-action/trine-bin version bump & ebuild changes
Summary: games-action/trine-bin version bump & ebuild changes
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: Normal enhancement with 1 vote (vote)
Assignee: Gentoo Games
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-04-20 22:18 UTC by Jared B.
Modified: 2018-03-25 16:34 UTC (History)
7 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
games-action/trine-bin-1.08_p1.diff (trine-bin-1.08_p1.diff,583 bytes, patch)
2011-04-20 22:19 UTC, Jared B.
Details | Diff
Patch for the ebuild, see comment. (use-systemlibs.patch,1.87 KB, patch)
2011-04-22 18:15 UTC, Thomas
Details | Diff
fixed version of the previous patch (use-systemlibs.patch,1.96 KB, patch)
2011-04-22 22:00 UTC, Thomas
Details | Diff
Trine ebuild for "Trine-1.64.run" version. (trine-bin-1.08.1.ebuild,3.07 KB, text/plain)
2011-04-26 07:36 UTC, Róbert Čerňanský
Details
trine update v.3 (trine-bin-1.10.ebuild,2.95 KB, text/plain)
2011-05-13 10:25 UTC, Vasiliy Yeremeyev
Details
TrineUpdate3: x86 support (trine-bin-1.10.ebuild,2.37 KB, text/plain)
2011-05-15 15:27 UTC, Vasiliy Yeremeyev
Details
games-action/trine-bin-1.08_p3.ebuild (trine-bin-1.08_p3.ebuild,2.36 KB, text/plain)
2011-07-31 06:29 UTC, Jared B.
Details
games-action/trine-bin-1.08_p3.ebuild (trine-bin-1.08_p3.ebuild,2.36 KB, text/plain)
2011-08-10 01:58 UTC, Jared B.
Details
games-action/trine-bin-1.08_p3.ebuild (trine-bin-1.08_p3.ebuild,2.33 KB, text/plain)
2011-09-27 02:43 UTC, Jared B.
Details
games-action/trine-bin-1.08_p4.ebuild (trine-bin-1.08_p4.ebuild,2.33 KB, text/plain)
2011-10-08 00:23 UTC, Jared B.
Details
games-action/trine-1.08_p4.ebuild (trine-1.08_p4.ebuild,2.70 KB, text/plain)
2012-06-10 19:14 UTC, Jared B.
Details
games-action/trine-1.08_p5.ebuild (trine-1.08_p5.ebuild,2.83 KB, text/plain)
2012-06-25 22:03 UTC, Jared B.
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Jared B. 2011-04-20 22:18:46 UTC
A newer version of Trine was release midway through HIB3.  It can be obtained from the HIB3 download page (the original link was replaced with the new one), and some details about the update can be found here:
http://frozenbyte.com/help_humble/linuxfaq.html

It appears to still be based on version 1.08, at least judging by the (empty) patch info files under data/misc/, even though 1.09 appears to be out now on the Windows side.

A simple ebuild bump seems to work fine on amd64, although I haven't started playing the game yet, so my testing basically consisted of: does it run? Check.

Anyway, I'm attaching a super simplistic diff (against the current tree version) for the new ebuild.  It also adds the dev-libs/libx86 dependency reported in bug 364061.

Reproducible: Always
Comment 1 Jared B. 2011-04-20 22:19:50 UTC
Created attachment 270723 [details, diff]
games-action/trine-bin-1.08_p1.diff
Comment 2 Jared B. 2011-04-20 22:22:19 UTC
Also, thanks for working to get the HIB3 games included in the tree so quickly.  The extra effort is noted and much appreciated.  :-)  It's a big improvement over the past two bundles, several games of which _still_ lack in-tree ebuilds.
Comment 3 Thomas 2011-04-22 18:15:19 UTC
Created attachment 270895 [details, diff]
Patch for the ebuild, see comment.

I also updated the ebuild, but I did something more: I added lines which remove some files of the lib64 directory included in the package and added new dependencies. With this it should use the system librarys instead of the one shipped with the game.

I know this is really dirty and amd64 only (at this time) but I hope somebody could improve it. :)

If you are asking "why did he do that?", the answer is: The game didn't start without this (and I'm not the only one with this issue, see: http://frozenbyte.com/board/viewtopic.php?f=15&t=3312&start=25#p14199 ) - I started with that library but then I removed more and more... And the game feeled more responsible after each one.

P.S. Sorry for my bad english. :)
Comment 4 Thomas 2011-04-22 22:00:15 UTC
Created attachment 270917 [details, diff]
fixed version of the previous patch

Sorry, the last patch had an error with the boost library. This one adds a link which fixes it.
Comment 5 Róbert Čerňanský 2011-04-26 07:36:55 UTC
Created attachment 271189 [details]
Trine ebuild for "Trine-1.64.run" version.

This is an ebuild made out of two previously posted patches plus some fixes.  Additional changes on top of patches are:

1. Added symlinks to other boost libraries as well since trine-launcher is not working without them.
2. Used dosym for symlinks and moved to src_install instead of src_unpack.
3. Bundles libs removal supports x86 arch as well (I did not tested it on x86!).
4. Renamed sfx variable to bits and make it global since it is used in src_unpack as well.

Dosym commands prints a QA notice like this:

Found an absolute symlink in a library directory:
 *            opt/trine-bin/lib64/libboost_regex.so.1.35.0 -> /usr/lib64/libboost_regex-1_35.so.1.35.0
 *            It should be a relative symlink if in the same directory
 *            or a linker script if it crosses the /usr boundary.

I'm not sure how to make a linker script as the notice suggests or whether it is possible with bin-only package.

I've tested the ebuild on amd64 only.
Comment 6 Vasiliy Yeremeyev 2011-05-13 10:25:57 UTC
Created attachment 273045 [details]
trine update v.3

Trine was updated:
DIST TrineUpdate3.64.run 647256292 RMD160 d3a1c128f9ff66759ac6dabda0fa69912486b736 SHA1 5f9449b04be85fb2e847bc80619cd876d8a9c742 SHA256 10e63f40d6dac9b9340eeb67d1c3f478b7ab957e7a43404cd25d291ae8449988
EBUILD trine-bin-1.10.ebuild 3025 RMD160 5ea3dc4a212a7406c565e9c1b6ccfc755ecc6cb8 SHA1 a56aefaa610c0ad9ce8e2abf0c7a1f011ee88382 SHA256 1c99b249c28c374cd2b99fc049c4199079e40b01b600cde19c15427f033d4dd4
Comment 7 Vasiliy Yeremeyev 2011-05-15 15:27:25 UTC
Created attachment 273291 [details]
TrineUpdate3: x86 support

I've added 32-bit support (TrineUpdate3.32.run).
Trine also requires x11-libs/libtxc_dxtn which is present only in x11 overlay by now.

DIST TrineUpdate3.32.run 647243204 RMD160 62836a74570a6a4b5f89564765725b174ad927a8 SHA1 2e9a61c05fb19606b51f26214068004412e873e6 SHA256 6e496f8523d8f102cd2129cc739cd231972080a3c95e43d017e3c3291b1dab25
DIST TrineUpdate3.64.run 647256292 RMD160 d3a1c128f9ff66759ac6dabda0fa69912486b736 SHA1 5f9449b04be85fb2e847bc80619cd876d8a9c742 SHA256 10e63f40d6dac9b9340eeb67d1c3f478b7ab957e7a43404cd25d291ae8449988
EBUILD trine-bin-1.10.ebuild 2423 RMD160 89cccc41cf2d7f66f117595ecbd87d7fae896fad SHA1 704deb94abb5a8ac0673aa121ea3b0e8893b137d SHA256 f68471bb56eb9ca0d4955a6e0c293f8ba3bcd5eeec7d8f72fdd09786ea90f077
MISC metadata.xml 158 RMD160 cbd9984bb6b426c8c9cee5022fe0a26261612fea SHA1 be5251fa1dacef5c41b74761bb1c8c54fb633b9e SHA256 1423a4fdd4a79b1728a2056d9e300f7e1074253095d82726218d9e9b953888a3
Comment 8 Jared B. 2011-07-31 06:29:11 UTC
Created attachment 281643 [details]
games-action/trine-bin-1.08_p3.ebuild

I'm attaching a small revision of the latest update.  It contains two small changes:

1. Changed the media-libs/jpeg:62 dependency to just media-libs/jpeg - it seems to link against newer versions just fine

2. Change the file name / package version to 1.08_p3, as 'trine-bin --version' still reports itself as 1.08.  Since this is just an update to the existing version, giving the ebuild a new version number doesn't make sense.

Thanks to everyone for the updates.
Comment 9 Jared B. 2011-08-10 01:58:06 UTC
Created attachment 282771 [details]
games-action/trine-bin-1.08_p3.ebuild

Changed jpeg dependency (again) to virtual/jpeg.  This removes a hard dependency on media-libs/jpeg for users who prefer to use libjpeg-turbo (which is now the default jpeg library for Gentoo).
Comment 10 Jared B. 2011-09-27 02:43:17 UTC
Created attachment 287857 [details]
games-action/trine-bin-1.08_p3.ebuild

Another dependency/library update:

1. Removed dependency on glew (1.5) to allow system upgrade to glew-1.6, which is now stable.

2. Commented out removal of bundled libGLEW.so.1.5, as this (or at least a symlink to 1.6) is required.  I know bundled libraries are generally frowned upon, but for a binary package like this I think it makes more sense then preventing system library upgrades.  A slotted glew package would be another option, but I think that's far too much work for just trine-bin.  Other options/ideas certainly welcome.

3. Removed dependency on virtual/jpeg, as the bundled libjpeg.so.62 is also left intact, which supersedes the system library.
Comment 11 Jared B. 2011-10-08 00:23:47 UTC
Created attachment 289171 [details]
games-action/trine-bin-1.08_p4.ebuild

This is more of an FYI than anything else: a fourth update has been released, so I've bumped the ebuild correspondingly.  No other changes have been made.

Here's a changelog for the game:
http://www.lgdb.org/node/2544/changelog
Comment 12 Jared B. 2012-06-10 19:14:02 UTC
Created attachment 314885 [details]
games-action/trine-1.08_p4.ebuild

Trine depends on libavcodec.so.52 (and three other libraries), which are provided by an older version of ffmpeg than is currently stable (currently, 0.10.2).  As a result, the game no longer loads.

Rather than adding a hard dependency on the older version, I changed the ebuild to install the relevant bundled libraries.  I removed the ffmpeg dependency altogether as a result.

Additionally, I changed the ebuild name from trine-bin to just trine to better fit in with other package naming conventions.  This seems to be largely a matter of preference, but most *-bin packages I'm familiar with (with a few exceptions) only exist when there is a source-based non-bin package also available:  eg., quake3 vs. quake3-bin, libreoffice vs. libreoffice-bin, etc.  Since the -bin version is the ONLY version of Trine available, I think it makes sense to call it, simply, trine.

I made a few other minor changes to the ebuild for cleanup, but nothing that affects functionality.  Oh, except for the manual - the PDF file is now only installed of USE=doc is enabled.
Comment 13 Jared B. 2012-06-25 22:03:31 UTC
Created attachment 316255 [details]
games-action/trine-1.08_p5.ebuild

An 'update5' was released for Trine, although it hasn't been updated on either of the HIB pages.  Instead, it can be grabbed directly from their forum:
http://frozenbyte.com/board/viewtopic.php?f=22&t=4151

This was actually released a few months ago, although I only just recently (and accidentally) stumbled across it.  This is a patch, and basically just overwrites the main binaries.

The attached ebuild will include the patch in the install, provided you have a copy in ${DISTDIR}.  I haven't been able to figure out how to have portage automatically fetch files for a package if any one other file is marked as nofetch.  Seems to be all-or-nothing, but if anyone has any ideas on how to work around this, I'd love to know.  I've run into this problem a couple other times as well.
Comment 14 Larry the Git Cow gentoo-dev 2018-03-25 16:33:32 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=eb3ca553bf3b86a2d4890837b6f32f24641d41c0

commit eb3ca553bf3b86a2d4890837b6f32f24641d41c0
Author:     James Le Cuirot <chewi@gentoo.org>
AuthorDate: 2018-03-25 13:47:25 +0000
Commit:     James Le Cuirot <chewi@gentoo.org>
CommitDate: 2018-03-25 16:33:05 +0000

    games-action/trine: Fix dependencies, cleanup, launcher USE flag
    
    I did a bad job of unbundling the libraries before.
    
    This adds a compatibility symlink now that the package has been
    renamed from trine-bin.
    
    Adds missing icon cache handling.
    
    Closes: https://bugs.gentoo.org/364293
    Package-Manager: Portage-2.3.24, Repoman-2.3.6

 games-action/trine/metadata.xml         | 11 ++--
 games-action/trine/trine-1.08-r2.ebuild | 77 --------------------------
 games-action/trine/trine-1.08-r3.ebuild | 97 +++++++++++++++++++++++++++++++++
 3 files changed, 104 insertions(+), 81 deletions(-)
Comment 15 James Le Cuirot gentoo-dev 2018-03-25 16:34:27 UTC
I didn't notice this report when I worked on this earlier but hopefully my work addresses all your concerns. Also see the new trine-enchanted-edition package if you're interested.