Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 313957 - media-sound/lilycomp: Verify and potentially improve Python-related code
Summary: media-sound/lilycomp: Verify and potentially improve Python-related code
Status: RESOLVED OBSOLETE
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All All
: High enhancement (vote)
Assignee: No maintainer - Look at https://wiki.gentoo.org/wiki/Project:Proxy_Maintainers if you want to take care of it
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 308257
  Show dependency tree
 
Reported: 2010-04-08 19:52 UTC by Arfrever Frehtes Taifersar Arahesis (RETIRED)
Modified: 2015-10-03 09:28 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
lilycomp-1.0.2-r2.ebuild (lilycomp-1.0.2-r1.ebuild,779 bytes, text/plain)
2010-05-01 01:07 UTC, David Abbott (RETIRED)
Details
lilycomp-1.0.2-r2.ebuild (lilycomp-1.0.2-r2.ebuild,3.14 KB, text/plain)
2010-05-01 23:05 UTC, David Abbott (RETIRED)
Details
lilycomp-1.0.2-r2.ebuild (lilycomp-1.0.2-r2.ebuild,3.19 KB, text/plain)
2010-05-02 00:46 UTC, David Abbott (RETIRED)
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Arfrever Frehtes Taifersar Arahesis (RETIRED) gentoo-dev 2010-04-08 19:52:28 UTC
- If this package can be used as a library and installs Python modules
  (*.so or *.py) into site-packages directories, then consider supporting
  installation for multiple Python versions.
  Please read section "Types of packages" in documentation [1] to decide
  if this package can support installation for multiple Python versions.

- Ensure that the ebuilds do not use deprecated functions or variables.

- Please check if Python 3 is supported by this package. You can temporarily
  set Python 3 as main active version of Python to properly test if this
  package supports Python 3.

- If this package does not support Python 3:
  - Specify dependency on Python 2.
    You can use PYTHON_DEPEND helper variable, which should be set before
    inheriting of python eclass.
    Please read section "Specification of dependency on Python" in
    documentation [1].

  - If this package cannot support installation for multiple versions of
    Python, then set active version of Python using
    python_set_active_version().

  - Ensure that shebangs in installed scripts specify correct version of
    Python. If shebangs are too generic (e.g. '#!/usr/bin/python'), then you
    can use python_convert_shebangs() to convert shebangs.
    (Wrapper scripts generated by python_generate_wrapper_scripts() do not
    require any changes.)
    Please read section "Shebangs in installed scripts" in documentation [1].

  - To ensure that changes applied to the ebuilds are sufficient, please
    temporarily set Python 3 as main active version of Python and test if
    this package can be properly installed and if it works at run time.

Please see documentation [1] for more details.
[1] http://www.gentoo.org/proj/en/Python/developersguide.xml
Comment 1 David Abbott (RETIRED) gentoo-dev 2010-05-01 01:07:52 UTC
Created attachment 229873 [details]
lilycomp-1.0.2-r2.ebuild

latest is from 2004, only works with python 2.
Comment 2 Arfrever Frehtes Taifersar Arahesis (RETIRED) gentoo-dev 2010-05-01 11:48:45 UTC
RESTRICT_PYTHON_ABIS is for packages supporting installation for multiple
Python ABIS.
python_set_active_version() is for packages not supporting installation for
multiple Python ABIs.
Why do you use PYTHON_DEPEND="2::2.6"? Are you sure that this package doesn't support Python 2.7?
PYTHON_USE_WITH="tk" and python_pkg_setup() might be used.
Comment 3 David Abbott (RETIRED) gentoo-dev 2010-05-01 23:05:36 UTC
Created attachment 229951 [details]
lilycomp-1.0.2-r2.ebuild

The only thing installed except the docs is ;
cat /usr/bin/lilycomp 
#!/usr/bin/env python 
[snip]
does the shebang need to be fixed for Python 2 ie
#!/usr/bin/python2
Comment 4 David Abbott (RETIRED) gentoo-dev 2010-05-02 00:46:00 UTC
Created attachment 229961 [details]
lilycomp-1.0.2-r2.ebuild

Fixed the shebang
Comment 5 Ian Delaney (RETIRED) gentoo-dev 2011-11-23 08:56:37 UTC
PYTHON_USE_WITH="tk"
and
DEPEND=">=dev-lang/python-2.4[tk]"
seem to be the only requirements,  python_pkg_setup() seems not to be needed.
I does support both pyth 2 & 3.
Comment 6 Pacho Ramos gentoo-dev 2015-10-03 09:28:46 UTC
This approach was changed by the -r1 python eclasses