Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 31081 - gcc-3.3.1-r5 does not emerge, fails when applying 02_all_gcc33-ice-hack.patch.bz2
Summary: gcc-3.3.1-r5 does not emerge, fails when applying 02_all_gcc33-ice-hack.patch...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Development (show other bugs)
Hardware: x86 Linux
: High critical
Assignee: Martin Schlemmer (RETIRED)
URL:
Whiteboard:
Keywords:
: 31082 31088 31094 31104 31111 31116 31136 31137 31147 31173 32184 (view as bug list)
Depends on:
Blocks:
 
Reported: 2003-10-13 18:54 UTC by Yi Quang (RETIRED)
Modified: 2003-10-28 06:04 UTC (History)
27 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
/tmp/gcc331-pp-fixup.patch (gcc331-pp-fixup.patch,407 bytes, patch)
2003-10-14 12:51 UTC, Martin Schlemmer (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Yi Quang (RETIRED) gentoo-dev 2003-10-13 18:54:03 UTC
emerging gcc-3.3.1-r5 fails when trying to apply the patch mentioned in the topic

here's  02_all_gcc33-ice-hack.patch.bz2-24454.out:


missing header for unified diff at line 292 of patch
can't find file to patch at input line 292
Perhaps you used the wrong -p or --strip option?
The text leading up to this was:
--------------------------
|--- gcc/diagnostic.c.jj        2003-06-03 08:45:21.000000000 -0400
|+++ gcc/diagnostic.c   2003-06-05 12:20:06.000000000 -0400
--------------------------
No file to patch.  Skipping patch.
2 out of 2 hunks ignored
missing header for unified diff at line 292 of
patch_gcc33-ice-hack.patch.bz2-24454.out
can't find file to patch at input line 292
Perhaps you used the wrong -p or --strip option?
The text leading up to this was:
--------------------------
|--- gcc/diagnostic.c.jj        2003-06-03 08:45:21.000000000 -0400
|+++ gcc/diagnostic.c   2003-06-05 12:20:06.000000000 -0400
--------------------------
No file to patch.  Skipping patch.
2 out of 2 hunks ignored


Reproducible: Always
Steps to Reproduce:
1. emerge -u gcc
2.
3.
Comment 1 SpanKY gentoo-dev 2003-10-13 19:03:43 UTC
*** Bug 31082 has been marked as a duplicate of this bug. ***
Comment 2 SpanKY gentoo-dev 2003-10-13 20:40:26 UTC
*** Bug 31088 has been marked as a duplicate of this bug. ***
Comment 3 ferret 2003-10-13 22:12:18 UTC
Well, I can get it to compile by altering the ebuild slightly... however
I'm
new to all this, so I'm not sure if I'm actively breaking something desirable
here :-)

I'll just give ya a diff -u: if anyone is desperate right now to compile
gcc-3.3.1-rc5 and get that beautiful empty emerge -uDp world list, this will
do it, but I'm not responsible for things stuffing up later...

Really lame hack follows.. :)

--- /usr/portage/sys-devel/gcc/gcc-3.3.1-r5.ebuild      2003-10-14 05:03:43.000000000
+0000
+++ /usr/portage/sys-devel/gcc/gcc-3.3.1-r5.ebuild2     2003-10-14 06:08:47.358479608
+0000
@@ -212,9 +212,10 @@
        if [ -n "${PP_VER}" ] && [ "${ARCH}" != "hppa" ]
        then
                # ProPolice Stack Smashing protection
+               mv -f ${WORKDIR}/patch/* ${WORKDIR}/patch/exclude/
                EPATCH_OPTS="${EPATCH_OPTS} ${WORKDIR}/protector.dif" \
                epatch /tmp/gcc331-pp-fixup.patch
-               epatch ${WORKDIR}/protector.dif
+               #epatch ${WORKDIR}/protector.dif
                cp ${WORKDIR}/protector.c ${WORKDIR}/${P}/gcc/ || die "protector.c
not found"
                cp ${WORKDIR}/protector.h ${WORKDIR}/${P}/gcc/ || die "protector.h
not found"
                version_patch ${FILESDIR}/3.3.1/gcc331-gentoo-branding.patch
\
Comment 4 Joshua Kinard gentoo-dev 2003-10-13 23:31:38 UTC
*** Bug 31094 has been marked as a duplicate of this bug. ***
Comment 5 Marc Doughty 2003-10-14 04:14:46 UTC
as I said in a duplicate, this type of failure in the gc ebuilds has been
on-and-off since 3.1 appeared over a year ago.

I'd like to know why this keeps cropping up. Perhaps those of us who have
changed the default locations of their overlay, distfiles, and portage tree
are the only ones who 'hit the wall' on this? Can we drop a comment in the
ebuild that says "try hard not to patch like this... as it causes trouble
downstream..."?
Comment 6 Jean-Francois Romang 2003-10-14 04:50:31 UTC
*** Bug 31111 has been marked as a duplicate of this bug. ***
Comment 7 Pete Plank 2003-10-14 05:21:02 UTC
ebuild fails due to an attempt to apply the patch set twice:

root@misaki neko # emerge -u gcc
Calculating dependencies ...done!
>>> emerge (1 of 1) sys-devel/gcc-3.3.1-r5 to /
>>> md5 src_uri ;-) gcc-3.3.1.tar.bz2
>>> md5 src_uri ;-) gcc-3.3.1-patches-1.5.tar.bz2
>>> md5 src_uri ;-) gcc-3.3.1-branch-update-20030927.patch.bz2
>>> md5 src_uri ;-) protector-3.3-4.tar.gz
>>> md5 src_uri ;-) gcc-3.3.1-manpages.tar.bz2
>>> Unpacking source...
>>> Unpacking gcc-3.3.1.tar.bz2 to /var/tmp/portage/gcc-3.3.1-r5/work
>>> Unpacking gcc-3.3.1-patches-1.5.tar.bz2 to /var/tmp/portage/gcc-3.3.1-r5/work
>>> Unpacking protector-3.3-4.tar.gz to /var/tmp/portage/gcc-3.3.1-r5/work
 * Working directory: /var/tmp/portage/gcc-3.3.1-r5/work/gcc-3.3.1...
 * Applying libtool-test.patch...
 * Applying libtool-tmp.patch...
 * Applying libtool-sed.patch...
 * Applying libtool-portage.patch...

 * Applying gcc-3.3.1-branch-update-20030927.patch.bz2...               
                           [ ok ]
 * Applying various patches (bugfixes/updates)...
 *   02_all_gcc33-ice-hack.patch.bz2...                                 
                           [ ok ]
 *   12_all_gcc331-unsharing_lhs.patch.bz2...                           
                           [ ok ]
 *   15_all_gcc33-multi-os-directory.patch.bz2...                       
                           [ ok ]
 *   16_all_gcc33-c99-double-inline.patch.bz2...                        
                           [ ok ]
 *   17_all_gcc33-c99-numbers.patch.bz2...                              
                           [ ok ]
 *   23_all_gcc33-c++-decl2.patch.bz2...                                
                           [ ok ]
 *   25_all_gcc33-libstdc++-pic.patch.bz2...                            
                           [ ok ]
 *   26_all_gcc33-m68k-const.patch.bz2...                               
                           [ ok ]
 *   27_all_gcc33-m68k-java-build.patch.bz2...                          
                           [ ok ]
 *   28_all_gcc33-m68k-loop.patch.bz2...                                
                           [ ok ]
 *   29_all_gcc33-m68k-subreg.patch.bz2...                              
                           [ ok ]
 *   40_all_gcc331-c++-modify-cond.patch.bz2...                         
                           [ ok ]
 *   41_all_gcc331-sched-ebb-cselib.patch.bz2...                        
                           [ ok ]
 *   50_all_gcc33-coreutils-compat.patch.bz2...                         
                           [ ok ]
 * Done with patching
 * Applying various patches (bugfixes/updates)...
 *   02_all_gcc33-ice-hack.patch.bz2...

 * Failed Patch: 02_all_gcc33-ice-hack.patch.bz2!
 * 
 * Include in your bugreport the contents of:
 * 
 *  
/var/tmp/portage/gcc-3.3.1-r5/temp/02_all_gcc33-ice-hack.patch.bz2-1097.out


!!! ERROR: sys-devel/gcc-3.3.1-r5 failed.
!!! Function epatch, Line 322, Exitcode 0
!!! Failed Patch: 02_all_gcc33-ice-hack.patch.bz2!
Comment 8 Hanno Böck gentoo-dev 2003-10-14 06:04:35 UTC
*** Bug 31104 has been marked as a duplicate of this bug. ***
Comment 9 Markus Nigbur (RETIRED) gentoo-dev 2003-10-14 06:18:32 UTC
*** Bug 31116 has been marked as a duplicate of this bug. ***
Comment 10 Imad R. Faiad 2003-10-14 06:39:33 UTC
On ferret's hack, the following will generate a nasty error:-

mv -f ${WORKDIR}/patch/* ${WORKDIR}/patch/exclude/

mv: cannot move `/var/tmp/portage/gcc-3.3.1-r5/work/patch/exclude' to a subdirectory
of itself, `/var/tmp/p                         ortage/gcc-3.3.1-r5/work/patch/exclude/exclude'

So, here is another lame hack:-
		# ProPolice Stack Smashing protection
		mkdir -p ${WORKDIR}/applied
		mv -f ${WORKDIR}/patch/* ${WORKDIR}/applied/
		EPATCH_OPTS="${EPATCH_OPTS} ${WORKDIR}/protector.dif" \
		epatch /tmp/gcc331-pp-fixup.patch
		#epatch ${WORKDIR}/protector.dif
		cp ${WORKDIR}/protector.c ${WORKDIR}/${P}/gcc/ || die "protector.c not
found"

By the way, at that point, it should be safe to purge the contents
of ${WORKDIR}/patch/ , since all the relavent patches therein have already
been
applied.

Also, I am not sure about commenting "epatch ${WORKDIR}/protector.dif"

Comments anyone?
Comment 11 Fernando Serboncini (RETIRED) gentoo-dev 2003-10-14 07:48:02 UTC
same happened to me.
Comment 12 Joe Sleeper 2003-10-14 08:04:29 UTC
<quote>
Perhaps those of us who have changed the default locations of their overlay,
distfiles, and portage tree are the only ones who 'hit the wall' on this?
</quote>

I have two machines that I've hit the wall on, and all of my locations are
default.  Ones a p3, the other a p4, pretty conservative flags are set. 
Seems it's effecting most everyone.

joe
Comment 13 Mark Duckworth 2003-10-14 08:21:18 UTC
Broken for me as well in the exact same manner.
Comment 14 Patrick Fourniols 2003-10-14 08:59:14 UTC
the mising file /tmp/gcc331-pp-fixup.patch is the cause, perhaps a bug in
extra_functions:
no files found => ${WORKDIR}/patch as default
but if you rem the line epatch /tmp/gcc331-pp-fixup.patch, protector.dif
don't work
an new "#include input.h" in gcc/expr.c broke the patch
Comment 15 Lisa Seelye (RETIRED) gentoo-dev 2003-10-14 11:24:23 UTC
*** Bug 31137 has been marked as a duplicate of this bug. ***
Comment 16 Jon Portnoy (RETIRED) gentoo-dev 2003-10-14 11:32:37 UTC
Why was this assigned to gcc-porting and not Azarah?

Reassigning...
Comment 17 SpanKY gentoo-dev 2003-10-14 11:55:38 UTC
*** Bug 31136 has been marked as a duplicate of this bug. ***
Comment 18 Martin Schlemmer (RETIRED) gentoo-dev 2003-10-14 12:13:37 UTC
What if you changed:

--
		EPATCH_OPTS="${EPATCH_OPTS} ${WORKDIR}/protector.dif" \
		epatch /tmp/gcc331-pp-fixup.patch
--

to:

--
		EPATCH_OPTS="${WORKDIR}/protector.dif" \
		epatch /tmp/gcc331-pp-fixup.patch
--

Note that we do not care about the old EPATCH_OPTS.  It might contain
a stale variable from somewhere .. ?
Comment 19 Imad R. Faiad 2003-10-14 12:39:00 UTC
Martin I just tried what you recommended, same old problem.
It's as Patrick stated "the mising file /tmp/gcc331-pp-fixup.patch"
I monitored the tmp dir while gcc was emerging, no such file.
I was able to emerge, however, by skiping the last patch, ie the pp patch.
Comment 20 Martin Schlemmer (RETIRED) gentoo-dev 2003-10-14 12:51:02 UTC
Ok, I was on crack there or something, sorry guys!  Should be fixed in CVS
now.
For those that are using rsync, I am attaching the patch.
Comment 21 Martin Schlemmer (RETIRED) gentoo-dev 2003-10-14 12:51:43 UTC
Created attachment 19235 [details, diff]
/tmp/gcc331-pp-fixup.patch

Just cp to /tmp/gcc331-pp-fixup.patch =)
Comment 22 Martin Schlemmer (RETIRED) gentoo-dev 2003-10-14 12:54:14 UTC
Feel free to close when rsync catches up.
Comment 23 Markus Nigbur (RETIRED) gentoo-dev 2003-10-14 13:23:11 UTC
*** Bug 31147 has been marked as a duplicate of this bug. ***
Comment 24 Yi Quang (RETIRED) gentoo-dev 2003-10-14 15:39:22 UTC
in portage now
Comment 25 Joshua Kinard gentoo-dev 2003-10-14 20:33:19 UTC
*** Bug 31173 has been marked as a duplicate of this bug. ***
Comment 26 SpanKY gentoo-dev 2003-10-28 06:04:55 UTC
*** Bug 32184 has been marked as a duplicate of this bug. ***