Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 303105 - net-libs/xulrunner and www-client/mozilla-firefox: ebuild patch for OSS support
Summary: net-libs/xulrunner and www-client/mozilla-firefox: ebuild patch for OSS support
Status: RESOLVED LATER
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Mozilla Gentoo Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-02-01 14:44 UTC by Nikos Chantziaras
Modified: 2010-02-02 21:31 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
xulrunner-1.9.2-r1.oss.ebuild.patch (xulrunner-1.9.2-r1.oss.ebuild.patch,1.75 KB, patch)
2010-02-01 14:45 UTC, Nikos Chantziaras
Details | Diff
mozilla-firefox-3.6-r1.oss.ebuild.patch (mozilla-firefox-3.6-r1.oss.ebuild.patch,2.16 KB, patch)
2010-02-01 14:45 UTC, Nikos Chantziaras
Details | Diff
xulrunner-1.9.2-r1.oss.ebuild.patch (xulrunner-1.9.2-r1.oss.ebuild.patch,1.76 KB, patch)
2010-02-01 14:49 UTC, Nikos Chantziaras
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Nikos Chantziaras 2010-02-01 14:44:57 UTC
The ebuilds of xulrunner and mozilla-firefox currently don't honor the "oss" global USE flag. Only "alsa".

I am attaching ebuild patches for xulrunner-1.9.2-r1.ebuild and mozilla-firefox-3.6-r1.ebuild to build them with Open Sound System support instead of ALSA when the "oss" USE flag is set.

Since it's not possible to build xulrunner/firefox with both ALSA and OSS, when both "alsa" and "oss" are both set, a warning is given and ALSA is used.

OSS support needs to be activated in xulrunner's build system by editing files; there's no switch to do it. I used the same method (using sed) that Arch Linux is using to provide OSS support. The sed also inhibits xulrunner to link against libasound.

The reason this patch is important is that OSS users can have HTML5 multimedia support (Theora and Vorbis in <video> and <audio> tags.)

I'm sure I made some mistakes regarding coding standards for ebuilds. My scripting skills aren't that good so please fix stuff where necessary.
Comment 1 Nikos Chantziaras 2010-02-01 14:45:21 UTC
Created attachment 218085 [details, diff]
xulrunner-1.9.2-r1.oss.ebuild.patch
Comment 2 Nikos Chantziaras 2010-02-01 14:45:40 UTC
Created attachment 218087 [details, diff]
mozilla-firefox-3.6-r1.oss.ebuild.patch
Comment 3 Nikos Chantziaras 2010-02-01 14:49:28 UTC
Created attachment 218088 [details, diff]
xulrunner-1.9.2-r1.oss.ebuild.patch

Oops, wrong ebuild patch for xulrunner. Here's the correct one.
Comment 4 Jory A. Pratt gentoo-dev 2010-02-01 23:47:23 UTC
You will need to wait for proper support to be added to the tree, we are not gonna support overlay work in official tree builds. You will also need to have upstream fix their configure script which is rather easy to handle properly switching between alsa/oss.
Comment 5 Nikos Chantziaras 2010-02-02 04:23:04 UTC
(In reply to comment #4)
> You will need to wait for proper support to be added to the tree, we are not
> gonna support overlay work in official tree builds.

I'm not sure what you mean with "overlay work".


> You will also need to have
> upstream fix their configure script which is rather easy to handle properly
> switching between alsa/oss.

Well, it's just a method that's there. Not sure why you need this as an on/off option in Xulrunner's build system. Firefox supports OSS, Gentoo has an "oss" USE flag, it can be enabled by manually editing the Makefile... IMO there's absolutely no reason not to do it. Also, getting upstream to provide a special option for it could take a year or more; more reason to go ahead and do it like that right now. It can be removed later when upstream provides a mozconfig option for it. No need to make the lives of OSS-using folks any more difficult, IMO. Firefox happens to be one the few apps that don't work correctly with an /etc/asound.conf that redirects alsalib-driven sound to OSS.
Comment 6 Nikos Chantziaras 2010-02-02 18:29:54 UTC
I've opened a bug about it upstream:

https://bugzilla.mozilla.org/show_bug.cgi?id=543779
Comment 7 Jory A. Pratt gentoo-dev 2010-02-02 21:31:00 UTC
(In reply to comment #6)
> I've opened a bug about it upstream:
> 
> https://bugzilla.mozilla.org/show_bug.cgi?id=543779
> 

Thank you, we are cc'd on the bug report, I will implement it over the next few days :)