Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 28938 - Add daemontools support to init script for samba
Summary: Add daemontools support to init script for samba
Status: RESOLVED NEEDINFO
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: High enhancement (vote)
Assignee: Gentoo's SAMBA Team
URL:
Whiteboard:
Keywords:
Depends on: 28294
Blocks:
  Show dependency tree
 
Reported: 2003-09-16 23:05 UTC by Mark Francis
Modified: 2004-08-26 02:33 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Patch for init.d script to support daemontools if installed (samba-patch,2.36 KB, patch)
2003-09-16 23:08 UTC, Mark Francis
Details | Diff
daemontools run script for nmbd (run,100 bytes, text/plain)
2003-09-16 23:09 UTC, Mark Francis
Details
daemontools run script for smbd logger (run,113 bytes, text/plain)
2003-09-16 23:11 UTC, Mark Francis
Details
/var/daemontools/mnbd/run (run,100 bytes, text/plain)
2003-09-16 23:13 UTC, Mark Francis
Details
/var/daemontools/nmbd/log/run (run,113 bytes, text/plain)
2003-09-16 23:13 UTC, Mark Francis
Details
samba-2.2.8a.ebuild patch (samba-2.2.8a_dt.ebuild.diff,849 bytes, patch)
2003-09-17 02:13 UTC, Hallgrimur Gunnarsson (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Francis 2003-09-16 23:05:51 UTC
This patch adds daemontools support to the samba init script. daemontools
support also requires 4 additional files:
/var/daemontools/smbd/run
/var/daemontools/smbd/log/run
/var/daemontools/nmbd/run
/var/daemontools/nmbd/log/run

daemontools does not need to be installed and it's use is optional.

Default is to use daemontools if it is installed. This seems reasonable.
Comment 1 Mark Francis 2003-09-16 23:08:29 UTC
Created attachment 17846 [details, diff]
Patch for init.d script to support daemontools if installed
Comment 2 Mark Francis 2003-09-16 23:09:39 UTC
Created attachment 17847 [details]
daemontools run script for nmbd
Comment 3 Mark Francis 2003-09-16 23:11:04 UTC
Created attachment 17848 [details]
daemontools run script for smbd logger

Previous entry is actually the run file for smbd, not nmbd.
Comment 4 Mark Francis 2003-09-16 23:13:17 UTC
Created attachment 17849 [details]
/var/daemontools/mnbd/run
Comment 5 Mark Francis 2003-09-16 23:13:43 UTC
Created attachment 17850 [details]
/var/daemontools/nmbd/log/run
Comment 6 Hallgrimur Gunnarsson (RETIRED) gentoo-dev 2003-09-17 02:13:26 UTC
Created attachment 17871 [details, diff]
samba-2.2.8a.ebuild patch

Ok, nice job. Works fine for me. Here's a
patch for the 2.2.8a ebuild that installs
the necessary files. It's pretty simple
so adding it to the other ebuilds is trivial
as well. I'm leaving it up to woodchip to
decide where he wants this :-).
Comment 7 Hallgrimur Gunnarsson (RETIRED) gentoo-dev 2003-09-17 02:14:30 UTC
Yes, I forgot, take notice of the filesnames
in the 2.2.8a patch, they're the following:

files/smbd-run
files/smbd-log-run
files/nmbd-run
files/nmbd-log-run
Comment 8 Donny Davies (RETIRED) gentoo-dev 2003-09-17 05:20:19 UTC
ok.  incidentally i made the files/config-svc-smbd+nmbd scriptlet for 
this purpose a couple years ago.

i'll need to have another look at this though.
Comment 9 Martin Schlemmer (RETIRED) gentoo-dev 2003-09-17 14:06:05 UTC
Look at my comment in:

  http://bugs.gentoo.org/show_bug.cgi?id=28941

I do not like hacking the same thing in 20 scripts.
Comment 10 Donny Davies (RETIRED) gentoo-dev 2003-09-25 14:28:31 UTC
New toplevel directories are not supposed to be created in /var.  We might
consider moving /var/empty (SSH privsep) as well just to be consistent.

A supervised initscript can live in it's own file, like init.d/samba-svc.

Also, I've already kept supervised init files in the net-fs/samba/files directory
for quite some time now.  See files/samba-svc and files/config-svc-smbd+nmbd.

I might just add these into the ebuild again; I never removed them from CVS
because I figured it might be requested in the future, like now.

Just 'source files/config-svc-smbd+nmbd' in src_intall, and then call the
function config_install.  Two lines, everything is already there.

I notice the stuff in CVS and your stuff are quite different, I dont which
are "better" or what right now.

Comment 11 Michael Glauche (RETIRED) gentoo-dev 2004-07-07 00:58:46 UTC
Is there still interest in this ? Any patches for the current version of samba ? 
Comment 12 Michael Glauche (RETIRED) gentoo-dev 2004-08-26 02:33:49 UTC
closing it now, due to lack of new feedback .. if still interest, feel free to reopen the bug.