Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 287057 - media-libs/xine-lib-1.1.16.3-r1: change dvd USE flag to css
Summary: media-libs/xine-lib-1.1.16.3-r1: change dvd USE flag to css
Status: VERIFIED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Gentoo Media-video project
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-09-30 12:01 UTC by Fabio Erculiani (RETIRED)
Modified: 2009-10-06 18:20 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
xine-lib-1.1.16.3-r1 patch (xine-lib-1.1.16.3-r2.ebuild.patch,959 bytes, patch)
2009-09-30 12:02 UTC, Fabio Erculiani (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Fabio Erculiani (RETIRED) gentoo-dev 2009-09-30 12:01:05 UTC
xine-lib-1.1.16.3-r1 ebuild contains libdvdcss RDEPEND conditioned by the "dvd" USE flag. This is not correct and "css" global use should be used instead (defaulting to -css in IUSE).

Patch attached explains the concept better.

Reproducible: Always
Comment 1 Fabio Erculiani (RETIRED) gentoo-dev 2009-09-30 12:02:00 UTC
Created attachment 205658 [details, diff]
xine-lib-1.1.16.3-r1 patch
Comment 2 Ben de Groot (RETIRED) gentoo-dev 2009-09-30 12:37:11 UTC
I agree that the global css useflag should be used, but it should be enabled by default (or enabled in desktop profile), as most users will want this (unless you live in a backwards country).
Comment 3 Fabio Erculiani (RETIRED) gentoo-dev 2009-10-03 10:23:16 UTC
Ok, stating what Ben said, can I go ahead and fix it his way?
Comment 4 Jesús Guerrero Botella (RETIRED) gentoo-dev 2009-10-05 16:04:54 UTC
I was about to report this same issue. 

the problem is that this use flag falsely gives the user the impression that you need USE=dvd to watch dvds in xine-lib based programs. This just pushes libdvdcss which enables support for decryption, but not all dvds are encrypted.

The other side of the issue is that legality in which regards decryption is different on each country, so giving a false impression to the user can really put them in a delicate legal situation.

Comment 5 Fabio Erculiani (RETIRED) gentoo-dev 2009-10-06 09:52:23 UTC
So can anybody from media-video give ack for the fix? (change "dvd" to "css")
Comment 6 Samuli Suominen (RETIRED) gentoo-dev 2009-10-06 09:56:59 UTC
(In reply to comment #5)
> So can anybody from media-video give ack for the fix? (change "dvd" to "css")
> 

ACK. Feel free to commit.
Comment 7 Samuli Suominen (RETIRED) gentoo-dev 2009-10-06 09:58:15 UTC
Without revision bump of course. Package managers handle it without, and if they don't they're broken.
Comment 8 Fabio Erculiani (RETIRED) gentoo-dev 2009-10-06 10:18:23 UTC
+  06 Oct 2009; Fabio Erculiani <fabio@gentoo.org>
+  xine-lib-1.1.16.3-r1.ebuild:
+  Rename 'dvd' USE flag to better suited 'css', close bug #287057

Thanks, done
Comment 9 Joe Stroller 2009-10-06 18:16:20 UTC
> I agree that the global css useflag should be used, but it should be
> enabled by default (or enabled in desktop profile), as most users
>  will want this (unless you live in a backwards country).

I disagree. This would place American users in the position whereby they're breaking the law using the default settings. I think this is especially relevant if the Gentoo Foundation is still US-based.

If we're going to have the separate global USE flags of both dvd and css, then IMO the dvd USE flags should never enable DVD decryption in any package. I think we should consider the usage of the user who wants to play only region 0 disks without breaching the DCMA. 
Comment 10 Samuli Suominen (RETIRED) gentoo-dev 2009-10-06 18:20:03 UTC
Then you set -css in make.conf if you live in a country with retarded laws.