Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 286543 - >=media-libs/libdvdread-0.9.7: wrong RDEPEND => media-libs/libdvdcss
Summary: >=media-libs/libdvdread-0.9.7: wrong RDEPEND => media-libs/libdvdcss
Status: VERIFIED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Gentoo Media-video project
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-09-26 16:42 UTC by Fabio Erculiani (RETIRED)
Modified: 2009-12-28 09:32 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
media-libs/libdvdcss-0.9.7 ebuild patch (libdvdread-0.9.7-r1.ebuild.patch,390 bytes, patch)
2009-09-26 16:44 UTC, Fabio Erculiani (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Fabio Erculiani (RETIRED) gentoo-dev 2009-09-26 16:42:40 UTC
This is a semi-automated bug report with SOLUTION (for the lazy)

- "media-libs/libdvdcss" is illegal in some countries.

- the pkg in subject contains hardcoded dependency (RDEPEND) on libdvdcss, which is wrong for these reasons:

  - it is only a BUILD dependency (thus only a DEPEND).
    If you look at the source code, libdvdcss headers are used
    but libdvdcss.so is not linked against any of the produced ELF

  - compiling without libdvdcss.so in linker paths works hands down

Please find a patched ebuild.

Reproducible: Always

Steps to Reproduce:
Comment 1 Fabio Erculiani (RETIRED) gentoo-dev 2009-09-26 16:44:14 UTC
Created attachment 205313 [details, diff]
media-libs/libdvdcss-0.9.7 ebuild patch
Comment 2 Diego Elio Pettenò (RETIRED) gentoo-dev 2009-09-27 11:38:01 UTC
  - it is only a BUILD dependency (thus only a DEPEND).
    If you look at the source code, libdvdcss headers are used
    but libdvdcss.so is not linked against any of the produced ELF

WRONG! The library is dlopened at runtime.
Comment 3 Fabio Erculiani (RETIRED) gentoo-dev 2009-09-27 12:56:22 UTC
And dlopen failure handled by the software itself!
Also see #286515. Again, look at the sources.

dvdread/dvd_input.c:  dvdcss_library = dlopen("libdvdcss.so.2", RTLD_LAZY);
dvdread/dvd_input.c:                "libdvdread: Old (pre-0.0.2) version of libdvdcss found.\n"
dvdread/dvd_input.c:        fprintf(stderr,  "libdvdread: Missing symbols in libdvdcss.so.2, "

OTOH:
Where possible, libdvdcss dependency should be handled with "care".
Comment 4 Fabio Erculiani (RETIRED) gentoo-dev 2009-09-27 13:05:50 UTC
If you really want to make libdvdcss pulled in, you could add "css? ( media-libs/libdvdcss )" to RDPEND. But this doesn't change the fact that current (in Portage) ebuild should be fixed.
Comment 5 Fabio Erculiani (RETIRED) gentoo-dev 2009-10-07 18:04:59 UTC
yngwin or ssuominen can you reply here?

Thanks
Comment 6 Fabio Erculiani (RETIRED) gentoo-dev 2009-12-28 09:32:49 UTC
+  28 Dec 2009; Fabio Erculiani <lxnay@gentoo.org> libdvdread-0.9.6.ebuild,
+  libdvdread-0.9.7.ebuild:
+  Fix media-libs/libdvdcss dependency, close bug #286543
+

Closed.