Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 282148 - livecd-stage2 livecd/modblacklist option fails when hotplug is not installed
Summary: livecd-stage2 livecd/modblacklist option fails when hotplug is not installed
Status: IN_PROGRESS
Alias: None
Product: Gentoo Hosted Projects
Classification: Unclassified
Component: Catalyst (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Gentoo Catalyst Developers
URL:
Whiteboard:
Keywords: InVCS
Depends on:
Blocks:
 
Reported: 2009-08-20 20:42 UTC by Michael Zanetta
Modified: 2009-08-23 16:00 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
catalyst-blacklist-fix.patch (catalyst-blacklist-fix.patch,936 bytes, patch)
2009-08-20 20:50 UTC, Michael Zanetta
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Zanetta 2009-08-20 20:42:18 UTC
I think there's a problem in the file modules/livecd_stage2_target.py where it should blacklist listed module in livecd/modblacklist option. If we're not using hotplug, it should blacklist them in the /etc/modprobe.d/blacklist.conf instead.
To my understanding, hotplug is not needed anymore with recent udev versions...
I'm attaching a patch that makes catalyst modify the modprobe.d blacklist.conf file instead.


Reproducible: Always

Steps to Reproduce:
1. Put some in a livecd-stage2 file "livecd/modblacklist: arusb_lnx rt2870sta"

Actual Results:  
--- Running action sequence: setup_environment
--- Running action sequence: run_local

Traceback (most recent call last):
  File "modules/livecd_stage2_target.py", line 62, in run_local
    myf=open(self.settings["chroot_path"]+"/etc/hotplug/blacklist","a")
IOError: [Errno 2] No such file or directory: '/mnt/data/catalyst/tmp/default/livecd-stage2-i686-2009.0//etc/hotplug/blacklist'
None

!!! catalyst: Couldn't open /mnt/data/catalyst/tmp/default/livecd-stage2-i686-2009.0//etc/hotplug/blacklist.

!!! catalyst: Error encountered during run of target livecd-stage2

Catalyst aborting....
lockfile does not exist '/mnt/data/catalyst/tmp/default/livecd-stage2-i686-2009.0/.catalyst_lock'



Expected Results:  
Should patch the /etc/modprobe.d/blacklist.conf file instead.
Comment 1 Michael Zanetta 2009-08-20 20:50:23 UTC
Created attachment 201813 [details, diff]
catalyst-blacklist-fix.patch
Comment 2 Andrew Gaffney (RETIRED) gentoo-dev 2009-08-23 16:00:57 UTC
This is in git. Thanks.