Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 250989 - media-sound/brp-pacu - A dual channel FFT based Acoustic Analysis Tool to help engineers configure professional sound systems in live
Summary: media-sound/brp-pacu - A dual channel FFT based Acoustic Analysis Tool to hel...
Status: RESOLVED OBSOLETE
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: x86 Linux
: High enhancement (vote)
Assignee: Default Assignee for New Packages
URL: http://sourceforge.net/projects/brp-p...
Whiteboard:
Keywords:
Depends on: 99318
Blocks:
  Show dependency tree
 
Reported: 2008-12-15 02:19 UTC by John Stile
Modified: 2023-07-25 02:06 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Ebuild for media-sound/brp-pacu-1.0.7 (brp-pacu-1.0.7.ebuild,2.09 KB, text/plain)
2008-12-15 02:21 UTC, John Stile
Details
Ebuild for media-sound/brp-pacu-1.0.7 (brp-pacu-1.0.7.ebuild,1.81 KB, text/plain)
2008-12-15 04:11 UTC, John Stile
Details
Ebuild for media-sound/brp-pacu-1.0.7 (brp-pacu-1.0.7.ebuild,1.78 KB, text/plain)
2008-12-15 16:57 UTC, John Stile
Details
Ebuild for media-sound/brp-pacu-1.0.7 (brp-pacu-1.0.7.ebuild,1.91 KB, text/plain)
2008-12-15 17:36 UTC, John Stile
Details
Ebuild for media-sound/brp-pacu-1.0.7 (brp-pacu-1.0.7.ebuild,1.87 KB, text/plain)
2008-12-15 22:22 UTC, John Stile
Details
Ebuild for media-sound/brp-pacu-1.0.7 (brp-pacu-1.0.7.ebuild,1.73 KB, text/plain)
2008-12-16 08:30 UTC, John Stile
Details
Ebuild for media-sound/brp-pacu-1.0.7 (brp-pacu-1.0.7.ebuild,1.75 KB, text/plain)
2008-12-16 08:59 UTC, John Stile
Details
Ebuild for media-sound/brp-pacu-1.0.7 (brp-pacu-1.0.7.ebuild,1.70 KB, text/plain)
2008-12-17 06:09 UTC, John Stile
Details
Ebuild for media-sound/brp-pacu-1.0.7 (brp-pacu-1.0.7.ebuild,1.76 KB, text/plain)
2008-12-18 14:33 UTC, John Stile
Details

Note You need to log in before you can comment on or make changes to this bug.
Description John Stile 2008-12-15 02:19:03 UTC
Ebuild for package media-sound/brp-pacu.  I am not sure how to submit an ebuild for portage, but I hope this is a good place to start.

Reproducible: Always

Steps to Reproduce:
1. Add to /etc/make.conf 
    PORTDIR_OVERLAY="/usr/local/portage"
2. Create directory for ebuild
    mkdir -p /usr/local/portage/media-sound/brp-pacu
3. Change into that directory
    cd /usr/local/portage/media-sound/brp-pacu
4. Download the ebuild attached to this bug into current directory
5. Digest
    ebuild digest brp-pacu-1.0.7.ebuild
6. Unmask brp-pacu
    echo 'media-sound/brp-pacu' >> /etc/portage/package.keywords
7. Install ebuild
    emerge brp-pacu



This package does require another package not in portage yet.
gtkdatabox-0.9.0.1.ebuild that is in http://bugs.gentoo.org
Comment 1 John Stile 2008-12-15 02:21:14 UTC
Created attachment 175298 [details]
Ebuild for media-sound/brp-pacu-1.0.7
Comment 2 Jeroen Roovers (RETIRED) gentoo-dev 2008-12-15 02:39:13 UTC
(In reply to comment #0)
> Ebuild for package media-sound/brp-pacu.  I am not sure how to submit an ebuild
> for portage, but I hope this is a good place to start.

You're lucky to have picked the best way to start. :)
Comment 3 Jeroen Roovers (RETIRED) gentoo-dev 2008-12-15 02:51:34 UTC
Comment on attachment 175298 [details]
Ebuild for media-sound/brp-pacu-1.0.7

># Copyright 1999-2008 Gentoo Foundation
># Distributed under the terms of the GNU General Public License v2
># $Header: $

>...<

>DESCRIPTION="A dual channel FFT based Acoustic Analysis Tool to help engineers configure professional sound systems in live. One feature is the ability to take several transfer function sample plots, average them, and flip the average to aid in final equalization."

That's too long. About 100 chars should do.

>...<

>PN="BRP-PACU-${PV}"

Never set PN (or P or PV by the way) - use something like MY_PN instead.

>S="${WORKDIR}/${PN}"

You could have done this and be done in one line:
S="BRP-PACU-${PV}"

>src_compile() {
>    cd ${S} || die "Can't change into source directory"
>	sed -i 's|usr/local/share/BRP_PACU|usr/share/BRP_PACU|' gui.c

That change should go into src_unpack(), which makes the entire src_compile() superfluous. So add src_unpack() and do the sed there (after `unpack ${A}; cd "${S}"', and remove src_compile() entirely. Also, that's probably an improper use of prefixed whitespace.

>...<

>src_install () {
>    cd ${S} || die "Can't change into directory"
>    make INSTALL_ROOT="${D}" DESTDIR="${D}" install || die "Installation Failed"
>	cp gui.glade "${D}usr/share/BRP_PACU/" || die "Can't copy gui.glade to ${D}/usr/share/BRP_PACU/"

The canonical code would be:
 insinto /usr/share/BRP_PACU
 doins gui.glade

>	#make DESTDIR=${D} install || die "Installation Failed"

That's not a helpful comment. :)

>	dodoc AUTHORS ChangeLog INSTALL NEWS README
>
>	#make clean -C examples || die "Cleaning examples failed"
>	#docinto examples
>	#dodoc ${S}/examples/*

Again, it isn't clear what these comments do. They should very likely be removed.
>}
Comment 4 John Stile 2008-12-15 04:11:10 UTC
Created attachment 175304 [details]
Ebuild for media-sound/brp-pacu-1.0.7

Made recommended changes, except:
   S="BRP-PACU-${PV}"
didn't work
However, this does work:
   S="${WORKDIR}/BRP-PACU-${PV}"
Comment 5 Serkan Kaba (RETIRED) gentoo-dev 2008-12-15 07:15:04 UTC
(In reply to comment #4)
> Created an attachment (id=175304) [edit]
> Ebuild for media-sound/brp-pacu-1.0.7

* You still have a "cp" call that can be replaced.
* dodoc doesn't die on it's own.
* You're already located at $S in src_install
Comment 6 Serkan Kaba (RETIRED) gentoo-dev 2008-12-15 08:30:12 UTC
(In reply to comment #4)
> Created an attachment (id=175304) [edit]
> Ebuild for media-sound/brp-pacu-1.0.7
Please use emake instead of make
Comment 7 John Stile 2008-12-15 16:57:37 UTC
Created attachment 175346 [details]
Ebuild for media-sound/brp-pacu-1.0.7

replaced make with emake.  
removed change directory from src_install()
added die to dodoc

I haven't found how to replace the cp line in src_install()
Comment 8 John Stile 2008-12-15 17:18:40 UTC
I really do not see how to remove the cp line after scouering these sites:
http://www.gentoo.org/proj/en/devrel/handbook/handbook.xml?part=2&chap=1
http://devmanual.gentoo.org/quickstart/index.html
Can I have a hint?
Comment 9 John Stile 2008-12-15 17:36:28 UTC
Created attachment 175354 [details]
Ebuild for media-sound/brp-pacu-1.0.7

I think I figured out a way to remove cp by setting the install directory with insinto and then use doins to copy the file there.  I hope this is what you where looking for.
Comment 10 Serkan Kaba (RETIRED) gentoo-dev 2008-12-15 19:19:35 UTC
(In reply to comment #9)
> Created an attachment (id=175354) [edit]
> Ebuild for media-sound/brp-pacu-1.0.7
I think you dont need to check insinto failure. Other than that the ebuild looks fine to me. For further contributions please consider contacting sunrise project on #gentoo-sunrise @ FreeNode (best around evening in Europe) and reading their documentation[1][2]. And please be patient and give them some time to review.

1: http://www.gentoo.org/proj/en/sunrise/
2: http://overlays.gentoo.org/proj/sunrise/wiki
Comment 11 John Stile 2008-12-15 22:22:47 UTC
Created attachment 175370 [details]
Ebuild for media-sound/brp-pacu-1.0.7 

Remove check for insinto failure.
Comment 12 Serkan Kaba (RETIRED) gentoo-dev 2008-12-16 06:59:47 UTC
(In reply to comment #11)
> Created an attachment (id=175370) [edit]
> Ebuild for media-sound/brp-pacu-1.0.7 
> 
> Remove check for insinto failure.
> 

Thanks, good work. So please contact sunrise to add it to overlay, or a find dev to add it to tree.
Comment 13 John Stile 2008-12-16 07:32:12 UTC
(In reply to comment #12)
My pleasure, and thank everyone for helping me.

I have been a long time user of the main tree, so I would prefer to get it added to the main tree.  

However, brp-pacu depends on another package not in the main tree (x11-libs/gtkdatabox), but I found the build for it here on bugs.gentoo.org.

Since I don't have a dev in family or as a room mate, I will pursue the sunset route.

Do I leave the bug open for the sunset group?
Comment 14 John Stile 2008-12-16 08:30:28 UTC
Created attachment 175404 [details]
Ebuild for media-sound/brp-pacu-1.0.7

removed die from cp line.
changed elog to einfo.
Comment 15 John Stile 2008-12-16 08:59:45 UTC
Created attachment 175407 [details]
Ebuild for media-sound/brp-pacu-1.0.7

Added RDEPEND="${DEPEND}"
Comment 16 Serkan Kaba (RETIRED) gentoo-dev 2008-12-16 13:28:35 UTC
(In reply to comment #13)
> (In reply to comment #12)
> My pleasure, and thank everyone for helping me.
> 
> I have been a long time user of the main tree, so I would prefer to get it
> added to the main tree.  
> 
> However, brp-pacu depends on another package not in the main tree
> (x11-libs/gtkdatabox), but I found the build for it here on bugs.gentoo.org.
> 
> Since I don't have a dev in family or as a room mate, I will pursue the sunset
> route.
> 
> Do I leave the bug open for the sunset group?
> 
Keep the bug open until it hits the main tree.
Comment 17 John Stile 2008-12-17 06:09:39 UTC
Created attachment 175575 [details]
Ebuild for media-sound/brp-pacu-1.0.7

Added: 

EAPI="1"

inherit eutils

And tried to change DEPEND to use the EAPI="1" format.  
I'm not sure if I got this right, but it works.
I'll ask the irc sunrise if it's OK.
Comment 18 Serkan Kaba (RETIRED) gentoo-dev 2008-12-17 07:43:21 UTC
(In reply to comment #17)
> Created an attachment (id=175575) [edit]
> Ebuild for media-sound/brp-pacu-1.0.7
I realized that I missed something, why do you depend on gtk/glib:1. They've been deprecated long ago.
Comment 19 John Stile 2008-12-18 14:33:52 UTC
Created attachment 175725 [details]
Ebuild for media-sound/brp-pacu-1.0.7

Reorder DEPEND and KEYWORDS.
Comment 20 Serkan Kaba (RETIRED) gentoo-dev 2008-12-18 19:10:04 UTC
(In reply to comment #19)
> Created an attachment (id=175725) [edit]
> Ebuild for media-sound/brp-pacu-1.0.7
> 
> Reorder DEPEND and KEYWORDS.
> 

I meant killing their 1.x slots completely. And if this package depends on both (it probably doesn't) it's definetely acceptable for main tree and everyday use.
Comment 21 Matthew Marchese Gentoo Infrastructure gentoo-dev 2023-07-25 02:06:13 UTC
Project upstream at SourceForge last had movement on 2013-09-24. We'll close this bug as OBSOLETE since the software is unmaintained; no development in almost 10 years.