Bug 24050 – gettext emerge/compile error, patch included in bug report

• Status: VERIFIED FIXED
• Product: Gentoo Linux

[Description Christopher Taylor (RETIRED) 2003-07-07 08:24:19 UTC]

when emerging gettext with portage for osx, the apple compiler bitches and wines
about a couple of bugs in set_locale.c and test-names.c in regard to const char
*program_name not being defined...i've included an ebuild patch and a patches
for both files.

Reproducible: Always
Steps to Reproduce:
1. emerge rsync
2. emerge --nodeps gettext
3.

Actual Results:  
the build fails, apple's gcc dumps symbol table errors

Expected Results:  
built properly

here's the gettext-11.5-r1.ebuild patch file:

3c3
< # $Header:
/home/cvsroot/gentoo-x86/sys-devel/gettext/gettext-0.11.5-r1.ebuild,v 1.9
2003/07/01 15:11:16 todd Exp $
---
> # $Header: /home/cvsroot/gentoo-x86/sys-devel/gettext/gettext-0.11.5.ebuild,v
1.9 2003/06/22 05:55:23 drobbins Exp $
7c7
< SRC_URI="mirror://gnu/${PN}/${P}.tar.gz"
---
> SRC_URI="ftp://gatekeeper.dec.com/pub/GNU/gettext/${P}.tar.gz"
9d8
< IUSE="nls"
13c12
< KEYWORDS="~x86 ~ppc sparc ~alpha ~hppa arm ~mips"
---
> KEYWORDS="amd64 x86 ppc sparc alpha hppa mips osx"
16c15,16
<       unpack ${A}
---
>
> unpack ${A}
24,31d23
<         # cd to the work dir
<
<         if [ "${ARCH}" == "~ppc" ]; then
<               cd ${S}
<                 patch libuniname/test-names.c
${FILESDIR}/${PV}-osx_setlocale.patch
<                 patch tests/setlocale.c ${FILESDIR}/${PV}-osx_test-names.patch
<         fi
<
57,58c49
<       rm -rf ${D}/usr/include
<       rm -rf ${D}/usr/lib/*.{a,so}
---

here's the patch for set_locale.c

32a33
> const char *program_name;

i named the file for this patch:  gettext-0.11.5-r1-osx_setlocale.patch

the patch for test-names.c is:
25a26,27
> const char *program_name;
>

the file name for this patch is: gettext-0.11.5-r1-osx_test-names.patch

[Comment 1 Christopher Taylor (RETIRED) 2003-07-07 08:28:51 UTC]

if you read the bug report, i've posted a patch to this bug. the patch consists of an addition to the ebuild and 2 patch files for the source of this program.

they need testing. thanks! ;)

[Comment 2 Christopher Taylor (RETIRED) 2003-07-07 08:42:04 UTC]

Oh, my ebuild patch picks up from the KEYWORDS portion of the diff.

[Comment 3 Christopher Taylor (RETIRED) 2003-07-07 08:44:05 UTC]

if this bug craps out ~ppc, then the reference to ~ppc should be changed to ~osx

[Comment 4 Lars Weiler (RETIRED) 2004-04-02 21:41:20 UTC]

Portage on OSX is your baby, Pieter

[Comment 5 osx porters 2004-06-11 10:34:33 UTC]

Adding to our todo list

[Comment 6 Pieter Van den Abeele (RETIRED) 2004-07-12 21:30:18 UTC]

Fixed

[Comment 7 Hasan Khalil (RETIRED) 2005-02-06 13:33:28 UTC]

Closing out bugs that've been resolved for a while now...