Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 217796 - dev-libs/DirectFB mismanages the VIDEO_CARDS and INPUT_DEVICES variables
Summary: dev-libs/DirectFB mismanages the VIDEO_CARDS and INPUT_DEVICES variables
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High enhancement (vote)
Assignee: Gentoo Games
URL:
Whiteboard:
Keywords:
: 215324 258093 (view as bug list)
Depends on:
Blocks:
 
Reported: 2008-04-15 13:22 UTC by Markus Rathgeb
Modified: 2009-12-21 22:32 UTC (History)
14 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
proposed changes to solve problems (DirectFB-1.1.1.ebuild,6.45 KB, text/plain)
2008-05-07 10:17 UTC, jack.q.word
Details
DirectFB-1.2.3.ebuild (DirectFB-1.2.3.ebuild,5.17 KB, text/plain)
2008-08-19 15:02 UTC, Philippe Weibel
Details
DirectFB-1.2.3.ebuild (DirectFB-1.2.3.ebuild,5.17 KB, text/plain)
2008-08-19 15:22 UTC, Philippe Weibel
Details
patch to 1.2.6 ebuild to honor VIDEO_CARDS and INPUT_DEVICES (DirectFB-1.2.6.ebuild.diff,619 bytes, patch)
2008-12-02 21:45 UTC, Lucian Muresan
Details | Diff
DirectFB-1.2.6-r1.patch (DirectFB-1.2.6-r1.patch,1.96 KB, patch)
2009-01-25 18:59 UTC, Daniel Pielmeier
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Markus Rathgeb 2008-04-15 13:22:14 UTC
I cannot the input_devices_... and video_cards_... at the USE flags when I like to emerge DirectFB.
So I thought this was outdated.
I had have a look at the ebuild know and saw that it uses INPUT_DEVICES, but in
a (I believe) unusual / 'not so nice' way.

/usr/portage/dev-libs/DirectFB/DirectFB-1.1.1.ebuild:
IUSE_VIDEO_CARDS="ati128 cle266 cyber5k i810 i830 mach64 matrox neomagic none
nsc nvidia radeon savage sis315 tdfx unichrome"
IUSE_INPUT_DEVICES="dbox2remote elo-input gunze h3600_ts joystick keyboard
dreamboxremote linuxinput lirc mutouch none permount ps2mouse serialmouse
sonypijogdial wm97xx"
IUSE="debug fbcon fusion gif jpeg mmx png sdl sse sysfs truetype v4l v4l2 X
zlib"

/usr/portage/x11-base/xorg-server/xorg-server-1.4.0.90-r3.ebuild:
IUSE_INPUT_DEVICES="..."
IUSE_VIDEO_CARDS="..."
IUSE="${IUSE_VIDEO_CARDS} ${IUSE_INPUT_DEVICES} ${IUSE_SERVERS} 3dfx ..."

So in the second one I will see it as 'USE flags'.

Reproducible: Always

Steps to Reproduce:
emerge -vp dev-libs/DirectFB
Actual Results:  
[ebuild   R   ] dev-libs/DirectFB-1.1.1  USE="X fbcon gif jpeg mmx png sdl sse sysfs truetype v4l v4l2 zlib -debug -fusion" 0 kB

Expected Results:  
[ebuild   R   ] dev-libs/DirectFB-1.1.1  USE="X fbcon gif joystick%* jpeg lirc%* mmx png sdl sse sysfs truetype v4l v4l2 zlib -ati128% -cle266% -cyber5k% -dbox2remote% -debug -dreamboxremote% -elo-input% -fusion -gunze% -h3600_ts% -i810% -i830% -keyboard% -linuxinput% -mach64% -matrox% -mutouch% -neomagic% -none% -nsc% -nvidia% -permount% -ps2mouse% -radeon% -savage% -serialmouse% -sis315% -sonypijogdial% -tdfx% -unichrome% -wm97xx%" 0 kB
Comment 1 jack.q.word 2008-05-07 10:17:28 UTC
Created attachment 152235 [details]
proposed changes to solve problems

previously, it was completely ignoring input devices and video cards, I'm new to ebuilds, but this seems like a pretty obvious mistake...
maybe this should be -r1, I don't know..
this also includes vmware video support... for INPUT_DEVICES, taking linuxinput instead of linux_input, but gets changed to linuxinput before configure, can probably be changed back to just linuxinput...
Comment 2 jack.q.word 2008-05-07 10:20:12 UTC
also, uses sed, erk. don't think I added that to build requirements.
Comment 3 Philippe Weibel 2008-08-19 15:02:15 UTC
Created attachment 163305 [details]
DirectFB-1.2.3.ebuild

I've got the same problem. I patched the ebuild too + upgrade to the latest version of DirectFB.
Comment 4 Philippe Weibel 2008-08-19 15:22:57 UTC
Created attachment 163307 [details]
DirectFB-1.2.3.ebuild

Sorry... Mistakes in the proposed ebuild.
Comment 5 SpanKY gentoo-dev 2008-10-27 04:14:20 UTC
*** Bug 215324 has been marked as a duplicate of this bug. ***
Comment 6 Lucian Muresan 2008-12-02 21:45:26 UTC
Created attachment 174107 [details, diff]
patch to 1.2.6 ebuild to honor VIDEO_CARDS and INPUT_DEVICES

Using portage-2-2_rc16 here, if that matters, my variables ar set in /etc/make.conf like
INPUT_DEVICES="keyboard"
VIDEO_CARDS="nvidia matrox"

Without this patch, "emerge DirectFB -pv" looks like
[ebuild   R   ] dev-libs/DirectFB-1.2.6  USE="X -debug fbcon fusion gif jpeg mmx png sdl sse sysfs truetype v4l v4l2 zlib" INPUT_DEVICES="(-dbox2remote%) (-dreamboxremote%) (-elo-input%) (-gunze%) (-h3600_ts%) (-joystick%) (-keyboard%*) (-linuxinput%) (-lirc%) (-mutouch%) (-none%) (-permount%) (-ps2mouse%) (-serialmouse%) (-sonypijogdial%) (-wm97xx%)" VIDEO_CARDS="(-ati128%) (-cle266%) (-cyber5k%) (-i810%) (-i830%) (-mach64%) (-matrox%*) (-neomagic%) (-none%) (-nsc%) (-nvidia%*) (-radeon%) (-savage%) (-sis315%) (-tdfx%) (-unichrome%)" 0 kB [1=>0]

Total: 1 package (1 reinstall), Size of downloads: 0 kB
Portage tree and overlays:
 [0] /usr/portage
 [1] /usr/portage_overlays/local/my_overlay+patches



With the patch:
[ebuild   R   ] dev-libs/DirectFB-1.2.6  USE="X -debug fbcon fusion gif jpeg mmx png sdl sse sysfs truetype v4l v4l2 zlib" INPUT_DEVICES="-dbox2remote -dreamboxremote -elo-input -gunze -h3600_ts -joystick keyboard -linuxinput -lirc -mutouch -none -permount -ps2mouse -serialmouse -sonypijogdial -wm97xx" VIDEO_CARDS="-ati128 -cle266 -cyber5k -i810 -i830 -mach64 matrox -neomagic -none -nsc nvidia -radeon -savage -sis315 -tdfx -unichrome" 0 kB [1]

Total: 1 package (1 reinstall), Size of downloads: 0 kB
Portage tree and overlays:
 [0] /usr/portage
 [1] /usr/portage_overlays/local/my_overlay+patches
Comment 7 Lucian Muresan 2008-12-02 21:53:34 UTC
This problem with the ebuild shows up over and over again since several versions, I was always able to overcome it with the patch just posted. A bit annoying when I forget to copy the new ebuild to my local overlay in order to fix it every time a new version is released and I upgrade my HTPC and end up with no image on the TV, sometimes I have to remember what it was again... ;-). Would be nice if you guys would adopt the patch or finally fix this ebuild somehow.
Comment 8 f5d8fd51ed1e804c9e8d0357e8614e0493b06e96 2009-01-21 08:18:05 UTC
This bug is still present in the new DirectFB-1.2.7.ebuild...

I added vapier to the CC list as he added the latest ebuild to portage.
(I guess putting this bug report into Gentoo Games maybe wasn't the best idea, too...)
Comment 9 Markus Rathgeb 2009-01-21 16:45:19 UTC
> (I guess putting this bug report into Gentoo Games maybe wasn't the best idea,
> too...)

I do not know who made it... me not

Comment 10 Daniel Pielmeier gentoo-dev 2009-01-25 18:59:13 UTC
Created attachment 179691 [details, diff]
DirectFB-1.2.6-r1.patch

Maybe doing it this way is better as INPUT_DEVICES and VIDEO_CARDS are used as variables in make.conf and not IUSE_*. Also this is the way it is done in other ebuilds too.
Comment 11 Martin Mokrejš 2009-02-01 11:48:34 UTC
So far I had:

[ebuild   R   ] dev-libs/DirectFB-1.2.7  USE="X fbcon gif jpeg mmx png sse sysfs truetype v4l v4l2 zlib -debug -fusion -sdl" 0 kB

# grep VIDEO /etc/make.conf
VIDEO_CARDS="radeon vesa"
# CFLAGS="-O0 -ggdb" CXXFLAGS="-O0 -ggdb" USE="nostrip" emerge DirectFB
>>> Emerging (1 of 1) dev-libs/DirectFB-1.2.7
 * DirectFB-1.2.7.tar.gz RMD160 SHA1 SHA256 size ;-) ...                                                                          [ ok ]
 * checking ebuild checksums ;-) ...                                                                                              [ ok ]
 * checking auxfile checksums ;-) ...                                                                                             [ ok ]
 * checking miscfile checksums ;-) ...                                                                                            [ ok ]
 * All video drivers will be built since you did not specify
 * via the VIDEO_CARDS variable what video card you use.
 * DirectFB supports: ati128 cle266 cyber5k i810 i830 mach64 matrox neomagic none nsc nvidia radeon savage sis315 tdfx unichrome all none

>>> Unpacking source...
>>> Unpacking DirectFB-1.2.7.tar.gz to /var/tmp/portage/dev-libs/DirectFB-1.2.7/work
 * Applying DirectFB-1.2.7-CFLAGS.patch ...                                                                                        [ ok ]
 * Applying DirectFB-1.2.0-headers.patch ...                                                                                       [ ok ]
 * Applying DirectFB-1.1.1-pkgconfig.patch ...                                                                                     [ ok ]
>>> Source unpacked in /var/tmp/portage/dev-libs/DirectFB-1.2.7/work
>>> Compiling source in /var/tmp/portage/dev-libs/DirectFB-1.2.7/work/DirectFB-1.2.7 ...
 * econf: updating DirectFB-1.2.7/config.guess with /usr/share/gnuconfig/config.guess
 * econf: updating DirectFB-1.2.7/config.sub with /usr/share/gnuconfig/config.sub
./configure --prefix=/usr --host=i686-pc-linux-gnu --mandir=/usr/share/man --infodir=/usr/share/info --datadir=/usr/share --sysconfdir=/etc --localstatedir=/var/lib --enable-static --enable-x11 --enable-fbdev --enable-mmx --enable-sse --enable-jpeg --enable-png --enable-gif --enable-freetype --disable-multi --disable-debug --enable-sysfs --enable-zlib --enable-video4linux --enable-video4linux2 --disable-sdl --with-gfxdrivers=none --with-inputdrivers=keyboard --disable-vnc --build=i686-pc-linux-gnu
[cut]
Building Graphics Drivers:
  3Dfx Voodoo               no
  ATI Mach64                no
  ATI Rage 128              no
  ATI Radeon                no
  Cirrus EP9X               no
  Intel i810                no
  Intel i830                no
  Matrox                    no
  NeoMagic                  no
  NSC Geode                 no
  nVidia                    no
  Renesas SH7722/SH7723     no
  S3 Savage                 no
  SiS 315                   no
  TI Davinci                no
  TI OMAP                   no
  TVIA CyberPro             no
  VIA CLE266                no
  VIA UniChrome             no
  VMWare                    no

Inspecting what files belong to the package I see no files resembling ati or radeon drivers. I think NONE was really compiled/installed as summarized by the above output from configure.

Anybody willing to prepare patches for 1.2.7? ;-)
Comment 12 Daniel Pielmeier gentoo-dev 2009-02-02 19:36:45 UTC
(In reply to comment #11)
> 
> Inspecting what files belong to the package I see no files resembling ati or
> radeon drivers. I think NONE was really compiled/installed as summarized by the
> above output from configure.
> 
> Anybody willing to prepare patches for 1.2.7? ;-)
> 

Take a look at the previous patches and do your own for 1.2.7 :-). Also I guess that the old patches will also apply for 1.2.7
Comment 13 Peter Alfredsen (RETIRED) gentoo-dev 2009-03-07 14:54:29 UTC
All the patches that have been proposed here only scratch the surface. The patch by Daniel at least sets up the right USE flags, but it overwrites the VIDEO_CARDS variable. DirectFB needs to start treating VIDEO_CARDS and INPUT_DEVICES like USE flags in the form of:
for x in IUSE_INPUT_DEVICES; do
    IUSE="${IUSE} input_devices_${x}"
done
as done in Daniel's patch. It then needs to work with those USE flags in the body of the ebuild instead of manipulating variables, since USE flags can be masked.
Comment 14 Felix Schuster 2009-04-20 12:57:47 UTC
(In reply to comment #12)
> (In reply to comment #11)
> > Anybody willing to prepare patches for 1.2.7? ;-)
> > 
> 
> Take a look at the previous patches and do your own for 1.2.7 :-). Also I guess
> that the old patches will also apply for 1.2.7

It does. Why is this bug still NEW?
Comment 15 Markus Rathgeb 2009-04-22 17:30:17 UTC
> It does. Why is this bug still NEW?

I believe because it is not fixed in the portage tree. Or is it?

Comment 16 Felix Schuster 2009-04-22 22:41:57 UTC
(In reply to comment #15)
> I believe because it is not fixed in the portage tree. Or is it?

Someone should accept and assign the bug firstly.
Comment 17 Christopher Hogan 2009-05-23 11:56:59 UTC
DirectFB-1.2.6-r1.patch didn't work for me. VIDEO_CARDS and INPUT_DEVICES showed up correctly with emerge -pv. However, configure showed --with-gfxdrivers=none --with-inputdrivers=none

I changed references to VIDEO_CARDS and INPUT_DEVICES in the patch back to IUSE_VIDEO_CARDS and IUSE_INPUT_DEVICES and the patch worked against 1.2.7.

I believe these lines are responsible:
has ${card} ${IUSE_VIDEO_CARDS} && vidcards="${vidcards},${card}"
has ${input} ${IUSE_INPUT_DEVICES} && inputdrivers="${inputdrivers},${input}"
Comment 18 Juho-Mikko Pellinen 2009-06-24 20:20:14 UTC
With the latest patch and the instructions from Christopher Hogan I recompiled the version 1.2.7 successfully.
The previous recompile with original ebuild (again 1.2.7 due to some changes I made) failed and caused everything to break because of the lack of drivers.

Please, apply the changes to ebuild and create a 1.2.7-r1 version of DirectFB.
Comment 19 Martin Mokrejš 2009-07-29 10:34:38 UTC
Isn't this x11 stuff?
Comment 20 Juho-Mikko Pellinen 2009-07-29 10:59:38 UTC
Not necessarily. I use DirectFB on my media-server which has X installed, but it is not running. Independent programs, such as mplayer, use it to display graphics.
Comment 21 Rémi Cardona (RETIRED) gentoo-dev 2009-07-29 11:28:51 UTC
DirectFB isn't part of the x11 herd.

Thanks
Comment 22 Attila Stehr 2009-08-04 16:25:59 UTC
I use links w/ DirectFB for having images etc. in links (_console_ web browser)... Anyway - sam problem here.
Comment 23 SpanKY gentoo-dev 2009-09-29 20:50:47 UTC
*** Bug 258093 has been marked as a duplicate of this bug. ***
Comment 24 SpanKY gentoo-dev 2009-12-21 22:32:29 UTC
this was fixed a while ago