Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 193549 - =net-wireless/madwifi-ng-9999 and madwifi-ng-tools-9999
Summary: =net-wireless/madwifi-ng-9999 and madwifi-ng-tools-9999
Status: RESOLVED OBSOLETE
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High enhancement (vote)
Assignee: Steev Klimaszewski (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-09-23 17:44 UTC by Bjoern Olausson
Modified: 2012-12-21 17:53 UTC (History)
10 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
madwifi-ng-tools-9999.ebuild (madwifi-ng-tools-9999.ebuild,1.67 KB, text/plain)
2007-09-23 17:45 UTC, Bjoern Olausson
Details
madwifi-ng-9999.ebuild (madwifi-ng-9999.ebuild,2.46 KB, text/plain)
2007-09-23 17:46 UTC, Bjoern Olausson
Details
madwifi-ng-9999-uudecode-gcda-fix.patch (madwifi-ng-9999-uudecode-gcda-fix.patch,340 bytes, patch)
2007-09-23 17:46 UTC, Bjoern Olausson
Details | Diff
madwifi-ng-r1886.patch (madwifi-ng-r1886.patch,965 bytes, patch)
2007-09-23 17:47 UTC, Bjoern Olausson
Details | Diff
madwifi-ng-tools-9999.ebuild (madwifi-ng-tools-9999.ebuild,1.67 KB, text/plain)
2007-10-07 13:02 UTC, Bjoern Olausson
Details
madwifi-ng-9999.ebuild (madwifi-ng-9999.ebuild,2.47 KB, text/plain)
2007-10-07 13:02 UTC, Bjoern Olausson
Details
madwifi-ng-ebuild.patch (madwifi-ng-ebuild.patch,2.68 KB, patch)
2008-02-14 07:30 UTC, Alexandre Ghisoli
Details | Diff
diff for madwifi-ng-9999.ebuild (madwifi-ng-9999.patch,1.58 KB, patch)
2009-04-15 10:11 UTC, Sebastian Lüttich
Details | Diff
diff for madwifi-ng-tools-9999.ebuild (madwifi-ng-tools-9999.patch,1.24 KB, patch)
2009-04-15 10:11 UTC, Sebastian Lüttich
Details | Diff
changed injection patch for madwifi-ng trunk (madwifi-ng-injection.patch,889 bytes, patch)
2009-04-15 10:12 UTC, Sebastian Lüttich
Details | Diff
Updated ebuild with changed svn archive URL (madwifi-ng-tools-9999.ebuild,1.70 KB, text/plain)
2010-05-25 21:02 UTC, Peter Fox
Details
Updated ebuild with changed svn archive URL, and no patches (madwifi-ng-9999.ebuild,2.55 KB, text/plain)
2010-05-25 21:03 UTC, Peter Fox
Details
Disable warnings as errors in the net80211 directory (Wno-error.patch,276 bytes, patch)
2010-07-19 22:51 UTC, Peter Fox
Details | Diff
Updated ebuild to use the Wno-error patch (madwifi-ng-9999.ebuild,2.58 KB, text/plain)
2010-07-19 22:52 UTC, Peter Fox
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Bjoern Olausson 2007-09-23 17:44:47 UTC
SVN version of the current madwifi-ng madwifi-ng-tools ebuild.

Compiles fine on amd64
Compiles fine agains vanilla-2.6.23_rc7

(thanks for the help albert1, eliasp)

regards
Bjoern

Reproducible: Always
Comment 1 Bjoern Olausson 2007-09-23 17:45:41 UTC
Created attachment 131716 [details]
madwifi-ng-tools-9999.ebuild
Comment 2 Bjoern Olausson 2007-09-23 17:46:02 UTC
Created attachment 131718 [details]
madwifi-ng-9999.ebuild
Comment 3 Bjoern Olausson 2007-09-23 17:46:30 UTC
Created attachment 131719 [details, diff]
madwifi-ng-9999-uudecode-gcda-fix.patch
Comment 4 Bjoern Olausson 2007-09-23 17:47:02 UTC
Created attachment 131721 [details, diff]
madwifi-ng-r1886.patch
Comment 5 Albert Zeyer 2007-09-23 17:49:29 UTC
compiles fine on x86 against gentoo-2.6.22-r5 on my MacBook

thanks for the ebuild
Comment 6 teidakankan 2007-09-23 22:19:57 UTC
... and it compiles fine here on ~x86 with the following setup:

Portage 2.1.3.9 (default-linux/x86/2007.0, gcc-4.2.0, glibc-2.6.1-r0, 2.6.22-gentoo-r7 i686)
=================================================================
System uname: 2.6.22-gentoo-r7 i686 Intel(R) Pentium(R) M processor 1400MHz
Timestamp of tree: Sun, 23 Sep 2007 21:20:01 +0000
ccache version 2.4 [enabled]
app-shells/bash:     3.2_p17-r1
dev-java/java-config: 1.3.7, 2.0.33-r1
dev-lang/python:     2.5.1-r2
dev-python/pycrypto: 2.0.1-r6
dev-util/ccache:     2.4-r7
sys-apps/baselayout: 2.0.0_rc4-r1
sys-apps/sandbox:    1.2.18.1
sys-devel/autoconf:  2.13, 2.61-r1
sys-devel/automake:  1.4_p6, 1.5, 1.6.3, 1.7.9-r1, 1.8.5-r3, 1.9.6-r2, 1.10
sys-devel/binutils:  2.18.50.0.1
sys-devel/gcc-config: 1.4.0-r2
sys-devel/libtool:   1.5.24
virtual/os-headers:  2.6.22-r2
ACCEPT_KEYWORDS="x86 ~x86"
......

Thanks for your work.
Comment 7 teidakankan 2007-10-07 02:37:14 UTC
Just an update here:

The ESVN_REPO_URI="http://svn.madwifi.org/trunk" for both ebuilds need to be changed to:

ESVN_REPO_URI="http://svn.madwifi.org/madwifi/trunk/"

Then you will need to delete your madwifi-ng & madwifi-ng-tools svn-src folders for it to compile as it will complain about the ESVN_REPO_URI's being different.
Comment 8 Bjoern Olausson 2007-10-07 13:02:22 UTC
Created attachment 132822 [details]
madwifi-ng-tools-9999.ebuild

Updated to the new SVN URI (ESVN_REPO_URI="http://svn.madwifi.org/madwifi/trunk/")
Comment 9 Bjoern Olausson 2007-10-07 13:02:58 UTC
Created attachment 132824 [details]
madwifi-ng-9999.ebuild

Updated to the new SVN URI (ESVN_REPO_URI="http://svn.madwifi.org/madwifi/trunk/")
Comment 10 Gerrit M. Albrecht 2007-10-16 19:46:16 UTC
Network: AR5005G 802.11abg NIC (rev 01); amd64, sys-kernel/gentoo-sources 2.6.23

suggested patch worked fine for me. haven't needed an overlay, added the one line and continued with ebuild compile ...

Thanks, Gerrit.
Comment 11 teidakankan 2007-11-25 08:45:55 UTC
I've been getting this build failure lately with madwifi-ng and got it to compile by removing the madwifi-ng-r1886.patch. (At revision 2963.)

Evidently something has changed.

* Preparing ath_pci module
make -C /lib/modules/2.6.23-gentoo-r2/build M=/var/tmp/portage/net-wireless/madwifi-ng-9999/work/madwifi-ng-9999/ath modules
make[1]: Entering directory `/usr/src/linux-2.6.23-gentoo-r2'
  CC [M]  /var/tmp/portage/net-wireless/madwifi-ng-9999/work/madwifi-ng-9999/ath/if_ath.o
cc1: warnings being treated as errors
/var/tmp/portage/net-wireless/madwifi-ng-9999/work/madwifi-ng-9999/ath/if_ath.c: In function 'ath_intr':
/var/tmp/portage/net-wireless/madwifi-ng-9999/work/madwifi-ng-9999/ath/if_ath.c:1993: warning: unused variable 'ic'
/var/tmp/portage/net-wireless/madwifi-ng-9999/work/madwifi-ng-9999/ath/if_ath.c: In function 'ath_tx_startraw':
/var/tmp/portage/net-wireless/madwifi-ng-9999/work/madwifi-ng-9999/ath/if_ath.c:2659: error: 'ic' undeclared (first use in this function)
/var/tmp/portage/net-wireless/madwifi-ng-9999/work/madwifi-ng-9999/ath/if_ath.c:2659: error: (Each undeclared identifier is reported only once
/var/tmp/portage/net-wireless/madwifi-ng-9999/work/madwifi-ng-9999/ath/if_ath.c:2659: error: for each function it appears in.)
make[2]: *** [/var/tmp/portage/net-wireless/madwifi-ng-9999/work/madwifi-ng-9999/ath/if_ath.o] Error 1
make[1]: *** [_module_/var/tmp/portage/net-wireless/madwifi-ng-9999/work/madwifi-ng-9999/ath] Error 2
make[1]: Leaving directory `/usr/src/linux-2.6.23-gentoo-r2'
make: *** [all] Error 2
Comment 12 Johann 2007-12-25 08:41:45 UTC
(In reply to comment #11)
> I've been getting this build failure lately with madwifi-ng and got it to
> compile by removing the madwifi-ng-r1886.patch. (At revision 2963.)
> 
> Evidently something has changed.

I believe the r1886.patch was included from the 0.9.3 ebuild. Since the patched file had existed in the repo, the patch wouldn't do anything. However, it looks like the code has been changed a little.

I'm going to do some injection tests, but I'm guessing we can remove that patch and remove the injection USE tag.
Comment 13 Albert Zeyer 2007-12-30 10:00:42 UTC
The patch madwifi-ng-r1886.patch isn't working for me anymore for revision 3102. The module itself works good without but I haven't tried the injection.
Comment 14 Bjoern Olausson 2007-12-30 13:14:08 UTC
I am wondering if anyone is using injection...

IMHO we could remove the

a) the patch
b) the injection useflag?

regards
Bjoern
Comment 15 Bjoern Olausson 2007-12-30 13:27:58 UTC
by the way, any discusion I can find about injection is "old" and points me to
madwifi-ng-r2277.patch from aircrack (http://patches.aircrack-ng.org/madwifi-ng-r2277.patch)

it would be easy to patch the new sources. allwe have to do is

-       try0 = ph->try0;
+	try0 = (ic->ic_opmode == IEEE80211_M_MONITOR) ? 1 : ph->try0;
+	/*
+	 * The retry value has to be patched to 1 when injecting,
+	 * otherwise the sequence number will be overwritten
+	 */

That was what I found when comparing the code. Thought I am not a coder!
So if anyone could proof the quote...

regards
Bjoern
Comment 16 Bjoern Olausson 2007-12-30 13:30:57 UTC
ah sry heres's the source:
http://madwifi.org/browser/madwifi/trunk/ath/if_ath.c

line 2665

Line 2976 (struct ieee80211com *ic = &sc->sc_ic;) from the patch has mad it into madwifi-ng code

Comment 17 Alexandre Ghisoli 2008-02-14 07:30:37 UTC
Created attachment 143469 [details, diff]
madwifi-ng-ebuild.patch

This patch backport some modifications of the madwifi-ng-0.9.4 ebuild and make repoman more happy.

Please also note that this patch install the new minstrel rate engine module.
Comment 18 Alexandre Ghisoli 2008-02-14 07:33:16 UTC
(In reply to comment #17)
> Created an attachment (id=143469) [edit]
> madwifi-ng-ebuild.patch
> 
> This patch backport some modifications of the madwifi-ng-0.9.4 ebuild and make
> repoman more happy.
> 
> Please also note that this patch install the new minstrel rate engine module.
> 

Oops, and forgot to mention that the injection patch seems not working right now (it's commented out to make it compile in all cases .. not a so good idea )
Comment 19 Jakob Dettner 2008-09-20 05:54:03 UTC
works well on x86 with a Atheros AR5418 802.11a/b/g/n Wireless PCI Express Adapter (rev 01).

(Added ~x86 to to madwifi-ng-tools-9999.ebuild KEYWORDS)

Thx for the ebuild.
Comment 20 Sebastian Lüttich 2009-04-15 10:10:21 UTC
In case someone need this:

I updated and cleaned madwifi-ng-9999.ebuild and madwifi-ng-tools-9999.patch
and added madwifi-ng-injection.patch.

Compiles on ~x86 and ~amd64.

diffs and file follow.
Comment 21 Sebastian Lüttich 2009-04-15 10:11:28 UTC
Created attachment 188410 [details, diff]
diff for madwifi-ng-9999.ebuild
Comment 22 Sebastian Lüttich 2009-04-15 10:11:55 UTC
Created attachment 188412 [details, diff]
diff for madwifi-ng-tools-9999.ebuild
Comment 23 Sebastian Lüttich 2009-04-15 10:12:59 UTC
Created attachment 188413 [details, diff]
changed injection patch for madwifi-ng trunk
Comment 24 Peter Fox 2010-05-25 21:02:44 UTC
Created attachment 232919 [details]
Updated ebuild with changed svn archive URL
Comment 25 Peter Fox 2010-05-25 21:03:57 UTC
Created attachment 232921 [details]
Updated ebuild with changed svn archive URL, and no patches

I found the latest SVN version works on my Aspire One without any patches.
Comment 26 Peter Fox 2010-07-19 22:51:11 UTC
Created attachment 239465 [details, diff]
Disable warnings as errors in the net80211 directory

Since updating to gcc-4.4.3 madwifi-ng-9999 no longer builds:

cc1: warnings being treated as errors
In file included from /usr/src/linux-2.6.34-gentoo-r2/arch/x86/include/asm/uaccess.h:571,
                 from include/net/checksum.h:25,
                 from include/linux/skbuff.h:28,
                 from include/linux/if_ether.h:124,
                 from include/linux/netdevice.h:29,
                 from /var/tmp/portage/net-wireless/madwifi-ng-9999/work/madwifi-ng-9999/net80211/../include/compat.h:45,
                 from <command-line>:0:
In function 'copy_from_user',
    inlined from 'ieee80211_ioctl_setmode' at /var/tmp/portage/net-wireless/madwifi-ng-9999/work/madwifi-ng-9999/net80211/ieee80211_wireless.c:2126:
/usr/src/linux-2.6.34-gentoo-r2/arch/x86/include/asm/uaccess_32.h:212: error: call to 'copy_from_user_overflow' declared with attribute warning: copy_from_user() buffer size is not provably correct
make[2]: *** [/var/tmp/portage/net-wireless/madwifi-ng-9999/work/madwifi-ng-9999/net80211/ieee80211_wireless.o] Error 1
make[1]: *** [_module_/var/tmp/portage/net-wireless/madwifi-ng-9999/work/madwifi-ng-9999/net80211] Error 2
make[1]: Leaving directory `/usr/src/linux-2.6.34-gentoo-r2'
make: *** [all] Error 2

I patch the net80211 makefile to disable warnings as errors, and it then builds ok:
In file included from /usr/src/linux-2.6.34-gentoo-r2/arch/x86/include/asm/uaccess.h:571,
                 from include/net/checksum.h:25,
                 from include/linux/skbuff.h:28,
                 from include/linux/if_ether.h:124,
                 from include/linux/netdevice.h:29,
                 from /var/tmp/portage/net-wireless/madwifi-ng-9999/work/madwifi-ng-9999/net80211/../include/compat.h:45,
                 from <command-line>:0:
In function 'copy_from_user',
    inlined from 'ieee80211_ioctl_setmode' at /var/tmp/portage/net-wireless/madwifi-ng-9999/work/madwifi-ng-9999/net80211/ieee80211_wireless.c:2126:
/usr/src/linux-2.6.34-gentoo-r2/arch/x86/include/asm/uaccess_32.h:212: warning: call to 'copy_from_user_overflow' declared with attribute warning: copy_from_user() buffer size is not provably correct
Comment 27 Peter Fox 2010-07-19 22:52:14 UTC
Created attachment 239467 [details]
Updated ebuild to use the Wno-error patch
Comment 28 Rick Farina (Zero_Chaos) gentoo-dev 2012-12-21 17:53:35 UTC
Madwifi has been masked as it has been replaced by ath5k/ath9k upstream for years now.  Please migrate to a maintained driver.