Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 191968 - Add mal use flag to kpilot ebuild.
Summary: Add mal use flag to kpilot ebuild.
Status: RESOLVED NEEDINFO
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: x86 Linux
: High normal (vote)
Assignee: Gentoo Linux bug wranglers
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-09-10 11:27 UTC by Bertjan Broeksema
Modified: 2007-09-10 17:07 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
Patch to enable/disable mal (kpilot-mal-patch.diff,540 bytes, text/plain)
2007-09-10 11:27 UTC, Bertjan Broeksema
Details
Patch to enable/disable mal. (patch2.diff,540 bytes, text/plain)
2007-09-10 11:31 UTC, Bertjan Broeksema
Details
Made mal conduit optional (kpilot-mal-patch.diff,923 bytes, text/plain)
2007-09-10 16:19 UTC, Bertjan Broeksema
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Bertjan Broeksema 2007-09-10 11:27:12 UTC
Attached patch contains a small modification of the kpilot ebuild. The patch {en/dis}ables the mal conduit.

Also I strongly suggest to stabilize kpilot-3.5.7 as soon as possible because it contains some fixes for serious bugs. I've seen that pilot-link-0.12.2 is in portage now. I use that version for about half a year now and it works perfect here.

Reproducible: Always
Comment 1 Bertjan Broeksema 2007-09-10 11:27:40 UTC
Created attachment 130485 [details]
Patch to enable/disable mal
Comment 2 Bertjan Broeksema 2007-09-10 11:31:16 UTC
Created attachment 130487 [details]
Patch to enable/disable mal.

The previous patch was in the wrong direction =:)
Comment 3 Jakub Moc (RETIRED) gentoo-dev 2007-09-10 11:35:09 UTC
And what should that use flag do? It doesn't do anything with your patch, except for making a library dependency optional without affecting configure/compile in any way - that's not a valid usage of USE flags.
Comment 4 Bertjan Broeksema 2007-09-10 11:52:27 UTC
No additional actions are needed. The kpilot configure script will disable the mal-conduit if it doesn't find mal.

So this flag enables you to install kpilot without the mal-conduit and therefore without the libmal dependence. The mal conduit is for syncing avantgo which is not supported by every pda, or at least not used by every user. (At least not by me ;)
Comment 5 Jakub Moc (RETIRED) gentoo-dev 2007-09-10 12:01:27 UTC
(In reply to comment #4)
> No additional actions are needed. The kpilot configure script will disable the
> mal-conduit if it doesn't find mal.

Which is completely broken behaviour, please see http://www.gentoo.org/proj/en/qa/automagic.xml
Comment 6 Bertjan Broeksema 2007-09-10 12:23:12 UTC
Gah, i see =:(. Ok sorry for bothering then... I don't think so it's very usefull to invest more time in this because we're focussing on getting KPilot trunk stable. I'll make sure we can get a bit more advanced ebuild, which makes it possible to {en/dis}able conduits for that one.

(In reply to comment #5)
> (In reply to comment #4)
> > No additional actions are needed. The kpilot configure script will disable the
> > mal-conduit if it doesn't find mal.
> 
> Which is completely broken behaviour, please see
> http://www.gentoo.org/proj/en/qa/automagic.xml
> 

Comment 7 Bertjan Broeksema 2007-09-10 12:55:49 UTC
Err, just found out that mal can be disabled by passing --disable-mal to the configure script. I don't know how to add that in the ebuild. If you could give me a hint on that i'll adjust the patch and test it.
Comment 8 Bertjan Broeksema 2007-09-10 16:19:38 UTC
Created attachment 130512 [details]
Made mal conduit optional

Did some research myself. Added --disable-mal to $myconf when the useflag is not set.
Comment 9 Arfrever Frehtes Taifersar Arahesis (RETIRED) gentoo-dev 2007-09-10 17:07:07 UTC
$(use_enable mal) is better, but anyway please reopen this bug.