Bug 126624 – net-analyzer/nbtscan-1.5.0* suffers from -pedantic warnings.

• Status: RESOLVED LATER
• Product: Gentoo Linux

[Description Beech Horn 2006-03-17 21:18:46 UTC]

I have fixed all CFLAGS="-pedantic" warnings.

[Comment 1 Beech Horn 2006-03-17 21:20:21 UTC]

Created attachment 82434 [details, diff]
nbtscan-1.5-pedantic-rc1.patch

[Comment 2 Beech Horn 2006-03-17 21:21:07 UTC]

Created attachment 82435 [details]
nbtscan-1.5.1-r2.ebuild

[Comment 3 Beech Horn 2006-03-17 21:21:24 UTC]

Created attachment 82436 [details]
ChangeLog

[Comment 4 Jakub Moc (RETIRED) 2006-03-18 02:37:41 UTC]

This should be really submitted upstream instead...

[Comment 5 Beech Horn 2006-03-18 09:23:37 UTC]

I will try upstream - but if it works and upstream don't deem the fixes worthy of a version bump yet - would it not be worth including into Gentoo to stop compiler warnings?

[Comment 6 Marcelo Goes (RETIRED) 2006-03-18 09:58:36 UTC]

This doesn't really add any functionality or fix any errors to end users, so I'd rather wait on upstream before including this patch.

[Comment 7 Beech Horn 2006-03-18 10:06:22 UTC]

Ok, I'm just going through packages with -pedantic and finding bugs in some along the way (people missing out commas in string arrays and it concatenating - i.e. sys-libs/pwdb-0.62, etc).

This package had no bug problems I just assumed that no -pedantic warnings mean't better portability and would improve the standard of code, I am now duplicate submitting for bugs and upstream only for -pedantic warnings.

Assume this is correct behaviour?

[Comment 8 Marcelo Goes (RETIRED) 2006-03-18 10:37:23 UTC]

Guess so. At least what I do when I fix this type of bug (like say, unsigned warnings) is to ship it to upstream so that they have a chance of looking at it first. Warning fixes generally are accepted very quickly with any upstream that is alive.

[Comment 9 Beech Horn 2006-03-18 10:41:48 UTC]

Thanks for the advice,

I am just getting bored of warning messages so anything that is a < 1 minute compile which I can fix is getting fixed in the not too distant future.

Nothing is worse than trying to demonstrate how bug free Open Source is to a client when all you see are warnings and the occasional bug.

Hope upstream is active - if I don't hear anything back in the next couple of weeks I'll post back on here.

[Comment 10 Markus Ullmann (RETIRED) 2006-03-26 17:04:26 UTC]

Please reopen if you don't get a response from upstream, marking LATER for now