Bug 110605 – app-misc/mc-4.6.0-r14 doesn't build ext2 undelete feature

• Status: VERIFIED TEST-REQUEST
• Product: Gentoo Linux

[Description Ruben Garcia 2005-10-27 03:07:31 UTC]

I emerged mc, but the ext2fs recover is not in the menus.

emerge mc shows:
........
checking for ext2fs/ext2fs.h... no
configure: not using ext2fs file recovery code
........

I downloaded the sources from
http://www.ibiblio.org/pub/Linux/utils/file/managers/mc/
recompiled and installed, and I have now e2fs recovery.




Reproducible: Always
Steps to Reproduce:
1.emerge mc
2.mc
3.Open the utilities menu

Actual Results:  
The menu doesn't contain ext2 undelete

Expected Results:  
The menu should contain ext2 undelete

[Comment 1 Andrew Ross (RETIRED) 2005-10-27 05:19:12 UTC]

A quick check of the ebuild show that configure is being called with "--ext2undel", but I am seeing the 
same ./configure output as Ruben:

"checking linux/ext2_fs.h usability... yes
checking linux/ext2_fs.h presence... yes
checking for linux/ext2_fs.h... yes
checking for ext2fs/ext2fs.h... no
configure: not using ext2fs file recovery code"

I'll attach config.log which seems to indicate a bug in the configure script.


Portage 2.0.51.22-r3 (hardened/x86/2.6, gcc-3.3.6, glibc-2.3.5-r2, 2.6.11-hardened-r15 i686)
===============================================================
System uname: 2.6.11-hardened-r15 i686 Pentium III (Coppermine)
Gentoo Base System version 1.6.13
dev-lang/python:     2.3.5-r2, 2.4.2
sys-apps/sandbox:    1.2.12
sys-devel/autoconf:  2.13, 2.59-r6
sys-devel/automake:  1.4_p6, 1.5, 1.6.3, 1.7.9-r1, 1.8.5-r3, 1.9.6-r1
sys-devel/binutils:  2.15.92.0.2-r10
sys-devel/libtool:   1.5.20
virtual/os-headers:  2.6.11-r2
ACCEPT_KEYWORDS="x86"
AUTOCLEAN="yes"
CBUILD="i686-pc-linux-gnu"
CFLAGS="-march=pentium3 -O2 -pipe -fomit-frame-pointer"
CHOST="i686-pc-linux-gnu"
CONFIG_PROTECT="/etc /usr/kde/2/share/config /usr/kde/3/share/config /usr/share/config /var/
qmail/control"
CONFIG_PROTECT_MASK="/etc/gconf /etc/terminfo /etc/env.d"
CXXFLAGS="-march=pentium3 -O2 -pipe -fomit-frame-pointer"
DISTDIR="/usr/portage/distfiles"
FEATURES="autoconfig distlocks sandbox sfperms strict"
GENTOO_MIRRORS="ftp://mirror.aarnet.edu.au/pub/gentoo ftp://mirror.pacific.net.au/pub/gentoo 
http://distfiles.gentoo.org http://www.ibiblio.org/pub/Linux/distributions/gentoo"
PKGDIR="/usr/portage//packages/x86/"
PORTAGE_TMPDIR="/var/tmp"
PORTDIR="/usr/portage/"
PORTDIR_OVERLAY="/usr/local/portage"
SYNC="rsync://rsync.au.gentoo.org/gentoo-portage"
USE="bash-completion berkdb crypt dlloader hardened mysql ncurses nls pam perl pic python readline 
samba ssl symlink tcpd udev unicode userlocales x86 zlib userland_GNU kernel_linux elibc_glibc"
Unset:  ASFLAGS, CTARGET, LANG, LC_ALL, LDFLAGS, LINGUAS, MAKEOPTS

[Comment 2 Andrew Ross (RETIRED) 2005-10-27 05:29:36 UTC]

Created attachment 71560 [details]
config.log from ./configure run where ext2undel wasn't built.

The following extract from config.log reveals the problem:

"configure:18078: checking for ext2fs/ext2fs.h
configure:18096: i686-pc-linux-gnu-gcc -c -march=pentium3 -O2 -pipe
-fomit-frame-pointer -I/usr/include/gssapi -Wall  -I$(top_builddir)/intl
-I$(top_srcdir)/intl -I$(top_srcdir) conftest.c >&5
In file included from /usr/include/linux/ext2_fs.h:20,
		 from configure:18240:
/usr/include/linux/ext2_fs_sb.h:40: error: syntax error before "uid_t"
/usr/include/linux/ext2_fs_sb.h:56: error: syntax error before '}' token
configure:18099: $? = 1
configure: failed program was:
| #line 18083 "configure"

uid_t is defined in sys/types.h but this doesn't appear to be #include'd
anywhere.

[Comment 3 Andrew Ross (RETIRED) 2005-10-27 05:51:58 UTC]

Created attachment 71561 [details, diff]
Patch to ./configure

I don't know if this is the best way to address the problem, but it does allow
ext2undel support to be built.

My understanding of header files is that they should #include any dependencies
directly, so perhaps this is actually a bug in sys-fs/e2fsprogs?

[Comment 4 Ruben Garcia 2005-11-18 05:04:59 UTC]

Tested, worked well.
Please apply and send upstream.
Thanks

[Comment 5 Jakub Moc (RETIRED) 2006-04-17 13:52:56 UTC]

Not reproducible with 4.6.1, please test that version and report back.

<snip>
checking ext2fs/ext2_fs.h usability... yes
checking ext2fs/ext2_fs.h presence... yes
checking for ext2fs/ext2_fs.h... yes
checking for ext2fs/ext2fs.h... yes
checking for ext2_ino_t... yes
configure: using ext2fs file recovery code

...

configure: running /bin/sh './configure' --prefix=/usr  '--prefix=/usr' '--host=i686-pc-linux-gnu' '--mandir=/usr/share/man' '--infodir=/usr/share/info' '--datadir=/usr/share' '--sysconfdir=/etc' '--localstatedir=/var/lib' '--with-vfs' '--with-ext2undel' '--with-edit' '--enable-charset' '--with-screen=ncurses' '--with-gpm-mouse' '--with-included-gettext' '--with-x' '--with-samba' '--with-configdir=/etc/samba' '--with-codepagedir=/var/lib/samba/codepages' '--with-privatedir=/etc/samba/private' '--build=i686-pc-linux-gnu' '--cache-file' 'config.cache' 'CFLAGS=-march=athlon-xp -O2 -pipe -fomit-frame-pointer -fforce-addr -ftree-vectorize -I/usr/include/gssapi' 'LDFLAGS=-Wl,-O1 -Wl,--sort-common' 'build_alias=i686-pc-linux-gnu' 'host_alias=i686-pc-linux-gnu' --cache-file=../../config.cache --srcdir=.
</snip>