Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 93213 - kopete msn protocol won't connect to msn with new protocol change
Summary: kopete msn protocol won't connect to msn with new protocol change
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] KDE (show other bugs)
Hardware: All All
: High major (vote)
Assignee: Gentoo KDE team
URL:
Whiteboard:
Keywords:
: 93794 (view as bug list)
Depends on:
Blocks:
 
Reported: 2005-05-19 06:50 UTC by Elliot Pahl
Modified: 2005-06-07 07:24 UTC (History)
18 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
kdenetwork-3.4.0-kopete-msn.patch (kdenetwork-3.4.0-kopete-msn.patch,32.48 KB, patch)
2005-05-19 13:22 UTC, Raul Metsma
Details | Diff
kdenetwork-3.3.2-kopete-msn.patch (kdenetwork-3.3.2-kopete-msn.patch,31.87 KB, patch)
2005-05-19 13:54 UTC, Raul Metsma
Details | Diff
kdenetwork-3.4.0-kopete-msnlogin.patch (kdenetwork-3.4.0-kopete-msnlogin.patch,25.18 KB, patch)
2005-05-19 14:25 UTC, Alberto Garcia Hierro (Skyhusker)
Details | Diff
kdenetwork-3.4.0-r3.ebuild (kdenetwork-3.4.0-r3.ebuild,1.76 KB, text/plain)
2005-05-19 14:31 UTC, Alberto Garcia Hierro (Skyhusker)
Details
kdenetwork-3.4.0-kopete-msn-2.patch (kdenetwork-3.4.0-kopete-msn-2.patch,32.48 KB, patch)
2005-05-20 01:04 UTC, Raul Metsma
Details | Diff
Kopete ebuild for the split-ebuild setup (kopete-3.4.0-r3.ebuild,841 bytes, text/plain)
2005-05-20 09:22 UTC, Bauke Fahner
Details
kdenetwork-3.4.0-kopete-msn-3.patch (kdenetwork-3.4.0-kopete-msn-3.patch,35.25 KB, patch)
2005-05-21 03:19 UTC, Raul Metsma
Details | Diff
kdenetwork-3.3.2-kopete-msn-2.patch (kdenetwork-3.3.2-kopete-msn-2.patch,33.88 KB, patch)
2005-05-21 04:23 UTC, Raul Metsma
Details | Diff
Candidate for kdenetwork-3.3.2-r1.ebuild with backported patch (kdenetwork-3.3.2-r1.ebuild,1.24 KB, text/plain)
2005-05-21 12:50 UTC, Gard Spreemann
Details
Modified the split-ebuild version for msn-3 patch (kopete-3.4.0-r3.ebuild,862 bytes, text/plain)
2005-05-22 14:54 UTC, stephan
Details
Added ${PATCHES1} to split-ebuild version for msn-3 patch (kopete-3.4.0-r3.ebuild,874 bytes, text/plain)
2005-05-24 01:06 UTC, stephan
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Elliot Pahl 2005-05-19 06:50:48 UTC
there is a fix for this in kde svn, from #kde topic: 
 
Problems with kopete connecting to MSN is fixed in svn, both trunk and branch.  
Instructions for building it are here:  
http://wiki.kde.org/tiki-index.php?page=Kopete+SVN  

Reproducible: Always
Steps to Reproduce:
1.
2.
3.
Comment 1 José Costa 2005-05-19 08:15:53 UTC
fixed SVN commit 415681 by ogoffart from 
http://websvn.kde.org/tags/?rev=415681&view=rev   
Comment 2 Paulo Fidalgo 2005-05-19 08:55:59 UTC
please get a fixed version on portage as soo as you devs can... 
this is a very annoing bug... 
Comment 3 Patrick ALLAERT 2005-05-19 12:47:27 UTC
Same problem with profile 2005.0 under AMD64
Comment 4 Raul Metsma 2005-05-19 13:21:23 UTC
I ported the patch from svn to kde 3.4.0

least i hope so :)
Comment 5 Raul Metsma 2005-05-19 13:22:53 UTC
Created attachment 59321 [details, diff]
kdenetwork-3.4.0-kopete-msn.patch
Comment 6 Cyrill Helg 2005-05-19 13:37:25 UTC
can I just copy this patch into the "files" directory in the kopete portage
directory?
Comment 7 Nathan Toone 2005-05-19 13:41:57 UTC
put it in the files directory and add something like this: 
# fix kde bug 105929. Applied for 3.4.1. 
PATCHES1="${PATCHES1} 
${FILESDIR}/kdenetwork-3.4.0-kopete-msn.patch" 
 
to the end of your ebuild file... 
 
I'd do this in your overlay directory (/usr/local/portage) though...since the 
change will get overwritten next time you sync... 
Comment 8 Raul Metsma 2005-05-19 13:43:54 UTC
Ok it works

I try backport it 3.3.2 to, I need it at work :)
Comment 9 Cyrill Helg 2005-05-19 13:48:30 UTC
ok, but I also needed to digest the ebuild, because I got: 

>>> emerge (1 of 1) kde-base/kopete-3.4.0-r2 to /
!!! Security Violation: A file exists that is not in the manifest.
!!! File: files/kdenetwork-3.4.0-kopete-msn.patch

Thank you!
Comment 10 Raul Metsma 2005-05-19 13:54:20 UTC
Created attachment 59324 [details, diff]
kdenetwork-3.3.2-kopete-msn.patch
Comment 11 Raul Metsma 2005-05-19 13:55:01 UTC
I cant test 3.3.2 patch before tomorrow
Comment 12 Alberto Garcia Hierro (Skyhusker) 2005-05-19 14:25:42 UTC
Created attachment 59329 [details, diff]
kdenetwork-3.4.0-kopete-msnlogin.patch

This patch fixes the problem.
Comment 13 Alberto Garcia Hierro (Skyhusker) 2005-05-19 14:31:16 UTC
Created attachment 59330 [details]
kdenetwork-3.4.0-r3.ebuild

Updated ebuild.
BTW, sorry for the sending the patch again, it wasn't present when I looked at
the page, so I made the patch, tested it and submited. When the page reloaded
after sending the patch, I saw someone had already sent it while I was testing.
Comment 14 Jos Delbar 2005-05-19 15:10:01 UTC
(In reply to comment #4) 
> I ported the patch from svn to kde 3.4.0 
>  
> least i hope so :) 
 
Thanks Raul, this patch seems to work nicely. 
Comment 15 Paulo Fidalgo 2005-05-19 15:18:11 UTC
now we have the patch... time to get it into portage...
Devs please do it ASAP
Thanks
Comment 16 Nathan Toone 2005-05-19 15:22:42 UTC
The patch worked for me - but I wasn't able to compile with USE flag 
"kdeenablefinal"... 
 
I don't remember the exact error, something about a redundant 
declaration or something.... 
 
it worked fine with "-kdeenablefinal" though.... 
 
Just a warning - I don't know if they want to include it into portage until it 
works in all cases. 
 
I used the first patch - (kdenetwork-3.4.0-kopete-msn.patch)  I can't speak 
for the second one....and I really don't have the time to keep recompiling 
to test patches. 
Comment 17 Raul Metsma 2005-05-19 23:13:21 UTC
Intresting
I have kdeenablefinal turned on at home and it works

Comment 18 Raul Metsma 2005-05-20 01:04:42 UTC
Created attachment 59348 [details, diff]
kdenetwork-3.4.0-kopete-msn-2.patch

Small typo fix, changed one sslloginhandler.o -> sslloginhandler.lo in
Makefile.in
dunno if that helps, im not c++ expert
Comment 19 Raul Metsma 2005-05-20 01:06:27 UTC
And i can confirm that kde 3.3.2 patch works
the last typo fix is already in kde-3.3.2 patch
Comment 20 Niels Laukens 2005-05-20 06:38:42 UTC
for the forum-users redirected to this place:
a quick how-to-apply-the-3.3.2-patch:

* become root (mostly 'su')
* cd /usr/portage/kde-base/kdenetwork/
* edit kdenetwork-3.3.2.ebuild to become this:
[---snip---]
src_unpack() {
    kde_src_unpack

    epatch "${FILESDIR}/${P}-kopete-msn.patch"
}
[---snip---]

* Download that file in the patch-list above and save it to
/usr/portage/kde-base/kdenetwork/files/
* run 'ebuild kdenetwork-3.3.2.ebuild digest' to add the digest of the file.
* run 'emerge kdenetwork' to update

WARNING: this manual update WILL BE DELETED once you run 'emerge sync'. (unless
the dev's have made that update to portage.
Comment 21 Matthijs Langenberg 2005-05-20 08:15:55 UTC
(In reply to comment #16) 
> The patch worked for me - but I wasn't able to compile with USE flag  
> "kdeenablefinal"...  
>   
> I don't remember the exact error, something about a redundant  
> declaration or something....  
>   
> it worked fine with "-kdeenablefinal" though....  
 
It doesn't compile for me with the 'kdeenablefinal' either. 
 
 
Comment 22 Bauke Fahner 2005-05-20 09:22:44 UTC
Created attachment 59387 [details]
Kopete ebuild for the split-ebuild setup

This ebuild seems to work for me. It works with the provided patch.
Comment 23 Raul Metsma 2005-05-20 14:15:11 UTC
can you please post compile output 
I think it is something about the Makefile.am part
Comment 24 Hans Hvelplund Odborg 2005-05-20 16:57:26 UTC
I could not compile kopete with USE="kdeenablefinal". With  
USE="-kdeenablefinal" kopete compiles succesfully. 
I used the split ebuild. Here is the error I get:  
  
creating libkopete_msn_shared_la.all_cpp.cpp ...  
/bin/sh ../../../libtool --silent --mode=compile --tag=CXX  
i686-pc-linux-gnu-g++ -DHAVE_CONFIG_H -I. -I. -I../../..  -I./ui -I./ui  
-I../../../kopete/libkopete -I../../../kopete/libkopete/ui  
-I../../../kopete/libkopete/ui -I/usr/kde/3.4/include -I/usr/qt/3/include -I.   
-DQT_THREAD_SUPPORT  -D_REENTRANT -D_FILE_OFFSET_BITS=64  -Wnon-virtual-dtor  
-Wno-long-long -Wundef -ansi -D_XOPEN_SOURCE=500 -D_BSD_SOURCE -Wcast-align  
-Wconversion -Wchar-subscripts -Wall -W -Wpointer-arith -Wwrite-strings  
-DNDEBUG -DNO_DEBUG -O2 -O2 -march=athlon-xp -pipe -mmmx -m3dnow -msse  
-fomit-frame-pointer -Wformat-security -Wmissing-format-attribute  
-fno-exceptions -fno-check-new -fno-common -fno-exceptions -fno-check-new  
-fno-common -DQT_CLEAN_NAMESPACE -DQT_NO_ASCII_CAST -DQT_NO_STL -DQT_NO_COMPAT  
-DQT_NO_TRANSLATION  -c -o libkopete_msn_shared_la.all_cpp.lo `test -f  
'libkopete_msn_shared_la.all_cpp.cpp' || echo  
'./'`libkopete_msn_shared_la.all_cpp.cpp  
distcc[17702] ERROR: compile /root/.ccache/libkopete_.tmp.giga.17698.ii on  
localhost failed  
In file included from libkopete_msn_shared_la.all_cpp.cpp:4:  
msnaddcontactpage.cpp: In member function `  
   MSNAddContactPage::MSNAddContactPage(bool, QWidget*, const char*)':  
msnaddcontactpage.cpp:29: warning: unused parameter `bool connected'  
In file included from /usr/kde/3.4/include/kssl.h:25,  
                 from sslloginhandler.cpp:29,  
                 from libkopete_msn_shared_la.all_cpp.cpp:18:  
/usr/kde/3.4/include/ksslpeerinfo.h: At global scope:  
/usr/kde/3.4/include/ksslpeerinfo.h:31: error: use of `KInetSocketAddress' is  
   ambiguous  
/usr/kde/3.4/include/ksockaddr.h:234: error:   first declared as `class  
   KInetSocketAddress' here  
/usr/kde/3.4/include/ksocketaddress.h:642: error:   also declared as `class  
   KNetwork::KInetSocketAddress' here  
/usr/kde/3.4/include/ksslpeerinfo.h:31: error: `KInetSocketAddress' denotes an  
   ambiguous type  
/usr/kde/3.4/include/ksockaddr.h:234: error:   first type here  
/usr/kde/3.4/include/ksocketaddress.h:642: error:   other type here  
make[5]: *** [libkopete_msn_shared_la.all_cpp.lo] Fejl 1  
make[5]: Leaving directory  
`/var/tmp/portage/kopete-3.4.0-r3/work/kopete-3.4.0/kopete/protocols/msn'  
make[4]: *** [all-recursive] Fejl 1  
make[4]: Leaving directory  
`/var/tmp/portage/kopete-3.4.0-r3/work/kopete-3.4.0/kopete/protocols/msn'  
make[3]: *** [all-recursive] Fejl 1  
make[3]: Leaving directory  
`/var/tmp/portage/kopete-3.4.0-r3/work/kopete-3.4.0/kopete/protocols'  
make[2]: *** [all-recursive] Fejl 1  
make[2]: Leaving directory  
`/var/tmp/portage/kopete-3.4.0-r3/work/kopete-3.4.0/kopete'  
make[1]: *** [all-recursive] Fejl 1  
make[1]: Leaving directory  
`/var/tmp/portage/kopete-3.4.0-r3/work/kopete-3.4.0'  
make: *** [all] Fejl 2  
  
!!! ERROR: kde-base/kopete-3.4.0-r3 failed.  
  
Comment 25 Raul Metsma 2005-05-21 03:19:10 UTC
Created attachment 59447 [details, diff]
kdenetwork-3.4.0-kopete-msn-3.patch

From kde svn log
"SVN commit 416060 by wstephens:

SSLLoginHandler breaks --enable-final because it uses the old style
KInetSocketAddress class and the rest of MSN uses the new
KNetwork::KInetSocketAddress."

Patched again Makefile.in
Comment 26 Raul Metsma 2005-05-21 04:23:55 UTC
Created attachment 59448 [details, diff]
kdenetwork-3.3.2-kopete-msn-2.patch
Comment 27 Gard Spreemann 2005-05-21 12:50:15 UTC
Created attachment 59476 [details]
Candidate for kdenetwork-3.3.2-r1.ebuild with backported patch

Trivial ebuild update for kdenetwork-3.3.2 to apply the backported patch
(http://bugs.gentoo.org/attachment.cgi?id=59448&action=view).
The only change, apart from appending -r1 to the version number, was the
addition of the following line after line 19:
epatch ${FILESDIR}/kdenetwork-3.3.2-kopete-msn-2.patch

Hey, the new ebuild had to be put up, nomatter how trivial, right? :-P
At least the impatient will have something to stuff in their overlay to get MSN
working with Kopete/KDE-3.3.2 again, without having to upgrade to 3.4.x.
Comment 28 stephan 2005-05-22 14:54:24 UTC
Created attachment 59589 [details]
Modified the split-ebuild version for msn-3 patch

Modified the split-ebuild version of kopete-3.4.0-r3 to macht msn-3 patch since
kdenetwork-3.4.0-kopete-msn-2.patch became obsolete
Comment 29 Raul Metsma 2005-05-23 13:43:37 UTC
I wanted ask is the 3.3.2 still failing?
maybe can some dev add it to portage
Comment 30 Matthew Stapleton 2005-05-23 20:04:37 UTC
The split-ebuild doesn't include all of the previous patches.  The msn patch  
line should be prefixed with ${PATCHES1} 
Comment 31 stephan 2005-05-24 01:06:25 UTC
Created attachment 59678 [details]
Added ${PATCHES1} to split-ebuild version for msn-3 patch
Comment 32 stephan 2005-05-24 01:09:05 UTC
Comment on attachment 59678 [details]
Added ${PATCHES1} to split-ebuild version for msn-3 patch

Sorry, didn't noticed that ${PATCHES1} wasn't in the split-ebuild in the first
place
Comment 33 Jakub Moc (RETIRED) gentoo-dev 2005-05-24 04:48:12 UTC
*** Bug 93794 has been marked as a duplicate of this bug. ***
Comment 34 Jakub Moc (RETIRED) gentoo-dev 2005-05-24 04:49:37 UTC
0.10.1 is out and should work with MSN again... 

http://kopete.kde.org/index.php?page=downloads
Comment 35 Guard][an 2005-05-26 02:02:13 UTC
portage should have kde-base/kopete/kopete-3.4.0-r3.ebuild with the following fix:

# fix for kopete login bug: 93213
# fix kde bug 105929
PATCHES1="${PATCHES1} ${FILESDIR}/kdenetwork-3.4.0-kopete-msn-3.patch"


because all users wont switch to 3.4.1 which is currently hard masked
Comment 36 Gregorio Guidi (RETIRED) gentoo-dev 2005-05-26 02:55:24 UTC
I added the patch for kdenetwork-3.3.2. Thanks. 
 
About kde 3.4: kde 3.4.1 will be available just in a few days, it will be 
unmasked as soon as it is officially released. 
 
Comment 37 Sebastien Raveau 2005-05-26 11:39:44 UTC
(In reply to comment #36) 
> I added the patch for kdenetwork-3.3.2. Thanks.  
>   
> About kde 3.4: kde 3.4.1 will be available just in a few days, it will be  
> unmasked as soon as it is officially released.  
>   
 
(from the Kopete developers on IRC): 
with KDE 3.4.1 will come Kopete 0.10.2 
 
So there is no need to hard-mask Kopete 0.10.1, as it is designed to work with 
KDE 3.4.0 
Comment 38 Guard][an 2005-05-30 00:30:09 UTC
(In reply to comment #36)
> About kde 3.4: kde 3.4.1 will be available just in a few days, it will be 
> unmasked as soon as it is officially released.

It's not that smart to let people wait 2 weeks for a fix, even if kde 3.4.1 is
about to be released.

Think about users that don't know how to overlay portage / patch manually ...
Comment 39 Mike Nerone 2005-05-30 22:48:01 UTC
Sorry, but I have to me-too comment #38. Fixing packages already marked stable
should be one of the highest priorities if we want Gentoo to be an acceptable
distro for users, and a respected distro among its peers.
Comment 40 Gregorio Guidi (RETIRED) gentoo-dev 2005-05-31 00:43:29 UTC
(In reply to comment #39) 
> Sorry, but I have to me-too comment #38. Fixing packages already marked 
stable 
> should be one of the highest priorities if we want Gentoo to be an 
acceptable 
> distro for users, and a respected distro among its peers. 
 
kde 3.4 is not marked stable. 
 
Comment 41 Mike Nerone 2005-05-31 00:54:35 UTC
You're absolutely right. Forgive my sleepy brain. :)

I do think that such an easy fix should be put out more quickly (under ~arch in
this case), but at least it's not as bad as I was thinking.
Comment 42 Gregorio Guidi (RETIRED) gentoo-dev 2005-05-31 09:24:13 UTC
kde 3.4.1 is available now, closing. 
 
Sorry that nobody was around last week to fix it immediately, that just 
happens. 
 
Comment 43 giovanni.bobbio 2005-06-07 07:24:39 UTC
 (In reply to comment #40)  
> (In reply to comment #39)   
> > Sorry, but I have to me-too comment #38. Fixing packages already marked   
> stable   
> > should be one of the highest priorities if we want Gentoo to be an   
> acceptable   
> > distro for users, and a respected distro among its peers.   
>    
> kde 3.4 is not marked stable.   
    
But the fixed kdenetwork isn't available for the stable (3.3.2) release, 
either, so the previous comments still make sense.